[ZOOKEEPER-1015] DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance

• Type: Bug
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.3.2
• Component/s: server
• Labels: newbie
• Assignee: Bill Havanki
• Reporter: Xiaoming Shi
• Created: 13/Mar/11 03:00
• Updated: 03/Mar/16 02:44

Description

In the file

 
./zookeeper-3.3.2/src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java line:103

DateFormat.getDateTimeInstance() is called many times in the for loop. We can cache the result and improve the performance

This is similar to the Apache bug https://issues.apache.org/bugzilla/show_bug.cgi?id=48778

Similar code can be found:

./zookeeper-3.3.2/src/java/main/org/apache/zookeeper/server/TraceFormatter.java
./zookeeper-3.3.2/src/java/main/org/apache/zookeeper/server/LogFormatter.java

Issue Links

• is duplicated by: ZOOKEEPER-1014 DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance