ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1013

zkServer.sh usage message should mention all startup options

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.0
    • Component/s: server
    • Labels:
      None
    • Release Note:
      patch to zkServer.sh to show all startup options

      Description

      currently the "Usage" message for zkServer shows:

      echo "Usage: $0

      {start|stop|restart|status}

      "

      But it seems to me that it should show the other startup options as well, which are currently: start-foreground, upgrade, print-cmd.

      1. ZOOKEEPER-1013.patch
        0.3 kB
        Eugene Koontz

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12473430/ZOOKEEPER-1013.patch
        against trunk revision 1074995.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/182//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/182//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/182//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12473430/ZOOKEEPER-1013.patch against trunk revision 1074995. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/182//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/182//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/182//console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        +1 patch looks good.

        Show
        Mahadev konar added a comment - +1 patch looks good.
        Hide
        Mahadev konar added a comment -

        I just committed this to trunk. thanks Eugene!

        Show
        Mahadev konar added a comment - I just committed this to trunk. thanks Eugene!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1123 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1123/)
        ZOOKEEPER-1013 zkServer.sh usage message should mention all startup options (eugene koontz via mahadev)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1123 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1123/ ) ZOOKEEPER-1013 zkServer.sh usage message should mention all startup options (eugene koontz via mahadev)

          People

          • Assignee:
            Eugene Koontz
            Reporter:
            Eugene Koontz
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 5m
              5m
              Remaining:
              Remaining Estimate - 5m
              5m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development