Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.3
    • Fix Version/s: 3.4.0
    • Component/s: c client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      On line 1957, zookeeper_process() returns without cleaning up the "ia" buffer that was previously allocated. I don't know how often this code path is taken, but I thought it was worth reporting. I will attach a simple patch shortly.

      1. zookeeper-1007.patch
        0.4 kB
        Jeremy Stribling
      2. zookeeper-1007.patch
        0.4 kB
        Mahadev konar

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12472712/zookeeper-1007.patch
        against trunk revision 1074995.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/178//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/178//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/178//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12472712/zookeeper-1007.patch against trunk revision 1074995. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/178//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/178//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/178//console This message is automatically generated.
        Hide
        Jeremy Stribling added a comment -

        I'm guessing new tests aren't required for checking memory leaks in error conditions, but if someone disagrees let me know and I'll try to figure out how to write one when I get some time.

        Show
        Jeremy Stribling added a comment - I'm guessing new tests aren't required for checking memory leaks in error conditions, but if someone disagrees let me know and I'll try to figure out how to write one when I get some time.
        Hide
        Mahadev konar added a comment -

        jeremy, would you be able to create a patch against zookeeper trunk and also relative to zookeeper home directory?

        Show
        Mahadev konar added a comment - jeremy, would you be able to create a patch against zookeeper trunk and also relative to zookeeper home directory?
        Hide
        Mahadev konar added a comment -

        patch against trunk.

        Show
        Mahadev konar added a comment - patch against trunk.
        Hide
        Jeremy Stribling added a comment -

        Thanks Mahadev. Anything else you need from me?

        Show
        Jeremy Stribling added a comment - Thanks Mahadev. Anything else you need from me?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12473723/zookeeper-1007.patch
        against trunk revision 1081896.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/188//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/188//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/188//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12473723/zookeeper-1007.patch against trunk revision 1081896. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/188//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/188//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/188//console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        thanks jeremy. The patch looks good to me. Ill commit this to trunk.

        Show
        Mahadev konar added a comment - thanks jeremy. The patch looks good to me. Ill commit this to trunk.
        Hide
        Mahadev konar added a comment -

        I just committed this to trunk. thanks jeremy.

        Show
        Mahadev konar added a comment - I just committed this to trunk. thanks jeremy.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1123 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1123/)
        ZOOKEEPER-1007. iarchive leak in C client (jeremy stribling via mahadev)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1123 (See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1123/ ) ZOOKEEPER-1007 . iarchive leak in C client (jeremy stribling via mahadev)

          People

          • Assignee:
            Jeremy Stribling
            Reporter:
            Jeremy Stribling
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development