Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.5, 0.5.6, 0.6.0
    • Fix Version/s: 0.7.0
    • Component/s: GUI
    • Labels:
      None

      Description

      Currently %spark is the default interpreter.

      If I use, say %pyspark for 10 cells, I need to specify %pyspark 10 times.

      Within a notebook it should work implicitly: if cell #3 (from the top) is %pyspark, all the others (#4; #5 and so on) should be %pyspark, until I change it, say going back to %spark.

      %spark would still be the default, but this would simplify typing and increase readability.

        Issue Links

          Activity

          Hide
          moon Lee moon soo added a comment -

          How about slightly different approach? instead of implicit interpreter selection, keep explicit interpreter selection, but automatically adds %pyspark in the code area after paragraph created, if previous paragrpah is %pyspark.

          While Zeppelin can mix multiple interpreter in a single notebook, i think it's still useful to keep explicit interpreter selection for readability.

          Show
          moon Lee moon soo added a comment - How about slightly different approach? instead of implicit interpreter selection, keep explicit interpreter selection, but automatically adds %pyspark in the code area after paragraph created, if previous paragrpah is %pyspark. While Zeppelin can mix multiple interpreter in a single notebook, i think it's still useful to keep explicit interpreter selection for readability.
          Hide
          minwoo.kang Minwoo Kang added a comment -

          Could you mind if I contribute this issue?

          Show
          minwoo.kang Minwoo Kang added a comment - Could you mind if I contribute this issue?
          Hide
          moon Lee moon soo added a comment -

          Please feel free to make any contribution!

          Show
          moon Lee moon soo added a comment - Please feel free to make any contribution!
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user mwkang opened a pull request:

          https://github.com/apache/incubator-zeppelin/pull/806

          ZEPPELIN-707Automatically adds %.* of previous paragraph

              1. What is this PR for?
                Automatically adds %pyspark in the code area after paragraph created, if previous paragrpah is %pyspark.
              1. What type of PR is it?
                New Feature
              1. What is the Jira issue?
                https://issues.apache.org/jira/browse/ZEPPELIN-707
              1. How should this be tested?
                Run-time checking

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/mwkang/incubator-zeppelin ZEPPELIN-707

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-zeppelin/pull/806.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #806


          commit aebcaba2c923d722f587585a2493164f1e9786e3
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-03-30T00:59:54Z

          ZEPPELIN-707Automatically adds %.* of previous paragraph in the code area


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user mwkang opened a pull request: https://github.com/apache/incubator-zeppelin/pull/806 ZEPPELIN-707 Automatically adds %.* of previous paragraph What is this PR for? Automatically adds %pyspark in the code area after paragraph created, if previous paragrpah is %pyspark. What type of PR is it? New Feature What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-707 How should this be tested? Run-time checking You can merge this pull request into a Git repository by running: $ git pull https://github.com/mwkang/incubator-zeppelin ZEPPELIN-707 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-zeppelin/pull/806.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #806 commit aebcaba2c923d722f587585a2493164f1e9786e3 Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-03-30T00:59:54Z ZEPPELIN-707 Automatically adds %.* of previous paragraph in the code area
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-203682574

          Zeppelin automatically adds new paragraph when last paragraph runs.
          Isn't it make sense to add %.* to this auto added paragraph?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-203682574 Zeppelin automatically adds new paragraph when last paragraph runs. Isn't it make sense to add %.* to this auto added paragraph?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-203707670

          I agree with you. This commit is too hasty.
          I'm so sorry. I'm looking in that.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-203707670 I agree with you. This commit is too hasty. I'm so sorry. I'm looking in that.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-203746988

          @Leemoonsoo
          I change some code. Could you mind if I request to review this?

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-203746988 @Leemoonsoo I change some code. Could you mind if I request to review this?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-203796268

          Isn't it possible not to have any front-end code for that?
          Why not just include the `%..` in the empty note in the backend?

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-203796268 Isn't it possible not to have any front-end code for that? Why not just include the `%..` in the empty note in the backend?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-203810062

          The purpose of this front-end code is to track the recent usage of the interpteter(by the users).
          Okay. include the `%...` in the empty note.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-203810062 The purpose of this front-end code is to track the recent usage of the interpteter(by the users). Okay. include the `%...` in the empty note.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user felixcheung commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-204586660

          Does this work when the user has not included `%interpreter` in the previous paragraph? (ie. using the default interpreter)

          Show
          githubbot ASF GitHub Bot added a comment - Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-204586660 Does this work when the user has not included `%interpreter` in the previous paragraph? (ie. using the default interpreter)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-204680411

          @felixcheung
          Yes, it works.
          If user doesn't any %interpreter in previous paragraphs, `%..`(default interpreter) will be added.
          If user add %interpreter in previous paragraphs, %interpreter will be added.

          e.g.)
          paragraph-1 (no interpreters) -> paragraph-2 (no interpreters) -> paragraph-3 (`%..` will be added.)
          paragraph-1 (%sh) -> paragraph-2 (no interpreters) -> paragraph-3 (`%sh` will be added.)

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-204680411 @felixcheung Yes, it works. If user doesn't any %interpreter in previous paragraphs, `%..`(default interpreter) will be added. If user add %interpreter in previous paragraphs, %interpreter will be added. e.g.) paragraph-1 (no interpreters) -> paragraph-2 (no interpreters) -> paragraph-3 (`%..` will be added.) paragraph-1 (%sh) -> paragraph-2 (no interpreters) -> paragraph-3 (`%sh` will be added.)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-204681172

          Is there anything wrong?

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-204681172 Is there anything wrong?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bzz commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205101417

          @mwkang CI is failing now, you probably need to check in `zeppelin-webapp` what does `./grunt jshint` complain about.

          Show
          githubbot ASF GitHub Bot added a comment - Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205101417 @mwkang CI is failing now, you probably need to check in `zeppelin-webapp` what does `./grunt jshint` complain about.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205101528

          For me, same comment as before.
          There is no need for any front-end code.

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205101528 For me, same comment as before. There is no need for any front-end code.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205102549

          @bzz Thank you for your review.
          @corneadoug Okay, I will change the code does not use a front-end code.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205102549 @bzz Thank you for your review. @corneadoug Okay, I will change the code does not use a front-end code.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205158691

          @corneadoug I have a question. If User doesn't run paragraph, Always add `%..`. Because I couldn't know what is recent usage of the interpreter(by the users). Is it okay?

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205158691 @corneadoug I have a question. If User doesn't run paragraph, Always add `%..`. Because I couldn't know what is recent usage of the interpreter(by the users). Is it okay?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205160036

          If we create a new empty paragraph, we should add the `%..` (default, or previous).
          So this should be working for: running the last paragraph of the note + adding a new paragraph

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205160036 If we create a new empty paragraph, we should add the `%..` (default, or previous). So this should be working for: running the last paragraph of the note + adding a new paragraph
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205164365

          I change my code it is use only backend. I force push my remote branch. So remove previous commit.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205164365 I change my code it is use only backend. I force push my remote branch. So remove previous commit.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-208182170

          @corneadoug
          Could you review this?

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-208182170 @corneadoug Could you review this?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-208200553

          @mwkang

          I found 2 problems:

          1) Content of the first line is copied instead of interpreter sign only, for example:
          ```
          %md hello
          ```
          Will copy `%md hello` to the new paragraph, instead of `%md `

          2) Default interpreter is not copied
          If you type code using the default interpreter, it will add the previous paragraph interpreter sign instead.
          So If you have:

                1. Paragraph 1
                  ```
                  %md
                  hello
                  ```
                1. Paragraph 2
                  ```
                  println("Hello")
                  ```

          The new paragraph will have `%md`

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-208200553 @mwkang I found 2 problems: 1) Content of the first line is copied instead of interpreter sign only, for example: ``` %md hello ``` Will copy `%md hello` to the new paragraph, instead of `%md ` 2) Default interpreter is not copied If you type code using the default interpreter, it will add the previous paragraph interpreter sign instead. So If you have: Paragraph 1 ``` %md hello ``` Paragraph 2 ``` println("Hello") ``` The new paragraph will have `%md`
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-215607826

          @mwkang Do you have time to fix this PR?

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-215607826 @mwkang Do you have time to fix this PR?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-215705028

          @corneadoug
          Yes, Sorry for delay.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-215705028 @corneadoug Yes, Sorry for delay.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-216021157

          @corneadoug
          I fixed that problems.
          Could you mind if I request review to you?

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-216021157 @corneadoug I fixed that problems. Could you mind if I request review to you?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-217761459

          I'm so sorry. CI was failed.
          I'll try to fix it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-217761459 I'm so sorry. CI was failed. I'll try to fix it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-218011682

          @mwkang no problem
          It seems some tests and selectors are broken with the new changes.
          I will try the branch again and post if I find what is breaking at the same time

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-218011682 @mwkang no problem It seems some tests and selectors are broken with the new changes. I will try the branch again and post if I find what is breaking at the same time
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-219896471

          @corneadoug @Leemoonsoo Yeah! I passed all test.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-219896471 @corneadoug @Leemoonsoo Yeah! I passed all test.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-221419244

          @mwkang
          Sorry for late answer, I tested again and have 2 comments:

          • When you create a new notebook, the interpreter is listed as: `%..`. Any way to get the default interpreter from back-end and insert it instead?
          • After running a query, the cursor is placed on the next paragraph where the interpreter name was injected, however the cursor is placed at the beginning of the line (so you can't start typing)
          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-221419244 @mwkang Sorry for late answer, I tested again and have 2 comments: When you create a new notebook, the interpreter is listed as: `%..`. Any way to get the default interpreter from back-end and insert it instead? After running a query, the cursor is placed on the next paragraph where the interpreter name was injected, however the cursor is placed at the beginning of the line (so you can't start typing)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-221421745

          @corneadoug
          Thank you for your comment.
          I am sorry I don't understand clearly.
          Could you explain more?
          What is the meaning get the default interpreter from back-end and insert it instead?

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-221421745 @corneadoug Thank you for your comment. I am sorry I don't understand clearly. Could you explain more? What is the meaning get the default interpreter from back-end and insert it instead?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-221423385

          I don't remember if there was a way to change the default interpreter.
          But at least without config, it uses '%spark' by default, so
          `sc.version` == `%spark sc.version`

          In our case, if we try running
          ```
          %..
          sc.version
          ```

          You will get a: `%.. interpreter not found`

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-221423385 I don't remember if there was a way to change the default interpreter. But at least without config, it uses '%spark' by default, so `sc.version` == `%spark sc.version` In our case, if we try running ``` %.. sc.version ``` You will get a: `%.. interpreter not found`
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-221424620

          @corneadoug
          Oh... I don't consider about that.
          Thanks for mention that,
          I will fix my code.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-221424620 @corneadoug Oh... I don't consider about that. Thanks for mention that, I will fix my code.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-222479738

          • [ ] When you create a new notebook, the interpreter is listed as: %... Any way to get the default interpreter from back-end and insert it instead?
          • [ ] After running a query, the cursor is placed on the next paragraph where the interpreter name was injected, however the cursor is placed at the beginning of the line (so you can't start typing)
          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-222479738 [ ] When you create a new notebook, the interpreter is listed as: %... Any way to get the default interpreter from back-end and insert it instead? [ ] After running a query, the cursor is placed on the next paragraph where the interpreter name was injected, however the cursor is placed at the beginning of the line (so you can't start typing)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-222498405

          @corneadoug
          Hello, I have a question.
          Only after running a query, the cursor go to line end in new paragraph.
          If It is added manually, the cursor doesn't go to line end.
          Added manually meaning is using paragraph add menu or click add button between two paragraphs.
          Is it Okay?
          Or Have I to make the cursor go to line end without exception?

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-222498405 @corneadoug Hello, I have a question. Only after running a query, the cursor go to line end in new paragraph. If It is added manually, the cursor doesn't go to line end. Added manually meaning is using paragraph add menu or click add button between two paragraphs. Is it Okay? Or Have I to make the cursor go to line end without exception?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/806

          Since the cursor is moving in the text editor of the new paragraph, it should also go at the end of the line

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806 Since the cursor is moving in the text editor of the new paragraph, it should also go at the end of the line
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          @corneadoug I fix whole issue. Can you check my code?

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 @corneadoug I fix whole issue. Can you check my code?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          @mwkang I still get `%..` when I create a new note, is it normal?

          Could you also add a space after the %interpreter when you add it to the note?
          That way we can start typing directly without having to add that space

          @jongyoul If you could test that using some jdbc or other interpreters cases, that would be nice

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/806 @mwkang I still get `%..` when I create a new note, is it normal? Could you also add a space after the %interpreter when you add it to the note? That way we can start typing directly without having to add that space @jongyoul If you could test that using some jdbc or other interpreters cases, that would be nice
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          It works well with another default interpreter except `%spark`. See the below.
          <img width="659" alt="screen shot 2016-06-10 at 6 05 11 pm" src="https://cloud.githubusercontent.com/assets/3612566/15959490/0720f9e6-2f36-11e6-9f8b-ad6f627c4582.png">
          <img width="448" alt="screen shot 2016-06-10 at 6 05 22 pm" src="https://cloud.githubusercontent.com/assets/3612566/15959503/108bf364-2f36-11e6-98db-f8648d8f582e.png">

          But I also don't think it's good idea to display `%..` by default. It would be better display actual default name of interpreter like `%spark` or `%jdbc`. It prevent new users from confusing and trying to understand what that means.

          @mwkang Could you please try to fix it? and OccupiedInterpreter looks redundant because it stores noteId-interpreterName map only and returns interpreterName with noteId. This can be parsed from InterpreterFactory or another class directly. What's the benefit to create OccupiedInterpreter class?

          I also think it's simple to choose default interpreter when we create notebook and store it into note.json and use it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/806 It works well with another default interpreter except `%spark`. See the below. <img width="659" alt="screen shot 2016-06-10 at 6 05 11 pm" src="https://cloud.githubusercontent.com/assets/3612566/15959490/0720f9e6-2f36-11e6-9f8b-ad6f627c4582.png"> <img width="448" alt="screen shot 2016-06-10 at 6 05 22 pm" src="https://cloud.githubusercontent.com/assets/3612566/15959503/108bf364-2f36-11e6-98db-f8648d8f582e.png"> But I also don't think it's good idea to display `%..` by default. It would be better display actual default name of interpreter like `%spark` or `%jdbc`. It prevent new users from confusing and trying to understand what that means. @mwkang Could you please try to fix it? and OccupiedInterpreter looks redundant because it stores noteId-interpreterName map only and returns interpreterName with noteId. This can be parsed from InterpreterFactory or another class directly. What's the benefit to create OccupiedInterpreter class? I also think it's simple to choose default interpreter when we create notebook and store it into note.json and use it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          Okay. I am going to fix it.
          I show real interpreter name instead of '%..'

          @jongyoul I think about single responsibility. But if you have thought it is redundant, I will change code.
          You think it is redundant, don't you?

          (It's redundant.. And I think I lack of develop experience. So I sometimes have a mistake. But I have a can-do attitdue to learn from other's opinion.)

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 Okay. I am going to fix it. I show real interpreter name instead of '%..' @jongyoul I think about single responsibility. But if you have thought it is redundant, I will change code. You think it is redundant, don't you? (It's redundant.. And I think I lack of develop experience. So I sometimes have a mistake. But I have a can-do attitdue to learn from other's opinion.)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          I'll fix after this branch rebases onto develop.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 I'll fix after this branch rebases onto develop.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          @jongyoul @corneadoug
          Can you review my codes?
          (I had rebased my branch because branch had conflict)

          (Um.. CI is failed. :cry: )

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 @jongyoul @corneadoug Can you review my codes? (I had rebased my branch because branch had conflict) (Um.. CI is failed. :cry: )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          @mwkang Could you please re-trigger this PR? Close and reopen this issue.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/806 @mwkang Could you please re-trigger this PR? Close and reopen this issue.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          There's no test case for your implementation. Could you please add some test cases on your feature? I think NoteTest is one of the best point to write tests

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/806 There's no test case for your implementation. Could you please add some test cases on your feature? I think NoteTest is one of the best point to write tests
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          I am not sure that this test case is you expected

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 I am not sure that this test case is you expected
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          @mwkang Those tests are enough. I've tested it and LGTM. Thanks for contribution.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/806 @mwkang Those tests are enough. I've tested it and LGTM. Thanks for contribution.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          @mwkang I have one more question. See below.
          <img width="202" alt="screen shot 2016-06-17 at 11 03 44 pm" src="https://cloud.githubusercontent.com/assets/3612566/16153092/d3b8e618-34df-11e6-9649-3540c11f86cd.png">

          Can you fix the case of wrong interpreter name? Or do you have any idea to deal with?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/806 @mwkang I have one more question. See below. <img width="202" alt="screen shot 2016-06-17 at 11 03 44 pm" src="https://cloud.githubusercontent.com/assets/3612566/16153092/d3b8e618-34df-11e6-9649-3540c11f86cd.png"> Can you fix the case of wrong interpreter name? Or do you have any idea to deal with?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          @jongyoul If user enter wrong name, I ignore that name. Is it okay?
          Or do I try to figure similar name out ?

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 @jongyoul If user enter wrong name, I ignore that name. Is it okay? Or do I try to figure similar name out ?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          @mwkang It would be ok to ignore it. BTW, I suggest that you handle this issue with another PR because you should rebase your PR again and again. If you rebase this PR this time, I'll merge it into master.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/806 @mwkang It would be ok to ignore it. BTW, I suggest that you handle this issue with another PR because you should rebase your PR again and again. If you rebase this PR this time, I'll merge it into master.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          @jongyoul I rebase this PR onto master. I'll create new PR about It ignore wrong interpreter name

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 @jongyoul I rebase this PR onto master. I'll create new PR about It ignore wrong interpreter name
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          @mwkang Could you please re-trigger test once again?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/806 @mwkang Could you please re-trigger test once again?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang closed the pull request at:

          https://github.com/apache/zeppelin/pull/806

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/806
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user mwkang reopened a pull request:

          https://github.com/apache/zeppelin/pull/806

          ZEPPELIN-707Automatically adds %.* of previous paragraph's typing

              1. What is this PR for?
                Automatically adds %pyspark in the code area after paragraph created, if previous paragraph's typing is %pyspark.
              1. What type of PR is it?
                New Feature
              1. What is the Jira issue?
                https://issues.apache.org/jira/browse/ZEPPELIN-707
              1. How should this be tested?
                unit test
                Run-time checking
              1. Screenshots (if appropriate)

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/mwkang/incubator-zeppelin ZEPPELIN-707

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/806.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #806


          commit f1e59b2273dbc852b3cb5ff323f1ebf8b5d59e02
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-04-04T06:57:38Z

          ZEPPELIN-707Automatically adds %.. of previous paragraph's typing

          commit 83003f5dd2d0514c8413c0016c27bb0983e28d0c
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-04-06T02:31:01Z

          ZEPPELIN-707Fixed test

          commit 011f4e39614f56932d36d764fdc8aa40856f87b7
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-05-01T07:01:00Z

          ZEPPELIN-707Fixed interpreter parsing problems

          commit 27f3925cfe861b843ab4976f37c19ac2241753ff
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-05-17T23:59:24Z

          ZEPPELIN-707Fixed ParagraphActionsIT test

          commit 7dd3f68a8aefa3f5f041aeb30a9225e6a3da0ea0
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-05-30T12:10:55Z

          ZEPPELIN-707Make %.. is default interpreter

          commit 3c7485d7cc9eeac990883e1494dde5f31f6f543d
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-05-30T13:47:50Z

          ZEPPELIN-707Fix go to line end

          commit 854e96b8cbc0867143480af60546f8cc24e06fec
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-05-30T14:08:29Z

          ZEPPELIN-707Fix 'paragraphId' used out of scope.

          commit caeb9a23ef367de3185abb5ae601df978ef94d22
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-06-07T07:55:05Z

          ZEPPELIN-707Use ConcurrentHashMap instead of HashMap

          commit 2366709734741cdfdb18ed4845441dd0c8ac073b
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-06-07T08:06:46Z

          ZEPPELIN-707Use ConcurrentHashMap instead of HashMap

          commit 1484d1cf84941e8489963c6a3dc4c12428c714e7
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-06-10T04:40:22Z

          ZEPPELIN-707Change cursor of new paragraph go at the end of the line

          commit 532e98edb615a7e47be3096cfd39017726d2a8b1
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-06-10T04:47:02Z

          ZEPPELIN-707Fix cannot find symbol error

          commit f3ab5ea7d49e1d1d62d05a9c804d0b54868768da
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-06-10T04:47:35Z

          ZEPPELIN-707Fix cannot find symbol error

          commit 334b15ff7a81a083ecff6bcc780fd56b867cbcfe
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-06-16T04:56:51Z

          ZEPPELIN-707Remove OccupiedInterpreter class. Add lastReplName in Note.java

          commit 85ee14b738c7ceeed2959e41a5ad25fa132de2a9
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-06-16T05:36:35Z

          ZEPPELIN-707Fix test in error

          commit 0fd122c34d2821ffbe11c7fd5806f608a2e8d24f
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-06-16T08:08:09Z

          ZEPPELIN-707Modify checking nullable list location

          commit 4c0904bc77106c5dcc6b41524af2fe78050f875e
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-06-16T08:19:14Z

          ZEPPELIN-707Resolved conflicts

          commit 720ffba3aa725e04e863dfa89819b530789e2b20
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-06-16T08:19:39Z

          ZEPPELIN-707Add note.setLastReplName in Rest API

          commit a159903a136677faf60d7dc72e8dbf53b0f79b34
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-06-16T14:07:37Z

          ZEPPELIN-707Modify return empty string when repl name is blank

          commit 3652dbbfb0d4f9dd75fa79a8b7591651388a9a17
          Author: Minwoo Kang <minwoo.kang@outlook.com>
          Date: 2016-06-16T14:15:12Z

          ZEPPELIN-707Add test case


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user mwkang reopened a pull request: https://github.com/apache/zeppelin/pull/806 ZEPPELIN-707 Automatically adds %.* of previous paragraph's typing What is this PR for? Automatically adds %pyspark in the code area after paragraph created, if previous paragraph's typing is %pyspark. What type of PR is it? New Feature What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-707 How should this be tested? unit test Run-time checking Screenshots (if appropriate) default interpreter ! [zeppelin-707] ( https://cloud.githubusercontent.com/assets/10624086/15649172/79a67dcc-26aa-11e6-87c9-3f6e4e62effe.png ) while run paragraph, go to line end ! [zeppelin-707-2] ( https://cloud.githubusercontent.com/assets/10624086/15651085/3a98166e-26b8-11e6-9244-ba0d3ec82c99.png ) You can merge this pull request into a Git repository by running: $ git pull https://github.com/mwkang/incubator-zeppelin ZEPPELIN-707 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/806.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #806 commit f1e59b2273dbc852b3cb5ff323f1ebf8b5d59e02 Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-04-04T06:57:38Z ZEPPELIN-707 Automatically adds %.. of previous paragraph's typing commit 83003f5dd2d0514c8413c0016c27bb0983e28d0c Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-04-06T02:31:01Z ZEPPELIN-707 Fixed test commit 011f4e39614f56932d36d764fdc8aa40856f87b7 Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-05-01T07:01:00Z ZEPPELIN-707 Fixed interpreter parsing problems commit 27f3925cfe861b843ab4976f37c19ac2241753ff Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-05-17T23:59:24Z ZEPPELIN-707 Fixed ParagraphActionsIT test commit 7dd3f68a8aefa3f5f041aeb30a9225e6a3da0ea0 Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-05-30T12:10:55Z ZEPPELIN-707 Make %.. is default interpreter commit 3c7485d7cc9eeac990883e1494dde5f31f6f543d Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-05-30T13:47:50Z ZEPPELIN-707 Fix go to line end commit 854e96b8cbc0867143480af60546f8cc24e06fec Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-05-30T14:08:29Z ZEPPELIN-707 Fix 'paragraphId' used out of scope. commit caeb9a23ef367de3185abb5ae601df978ef94d22 Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-06-07T07:55:05Z ZEPPELIN-707 Use ConcurrentHashMap instead of HashMap commit 2366709734741cdfdb18ed4845441dd0c8ac073b Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-06-07T08:06:46Z ZEPPELIN-707 Use ConcurrentHashMap instead of HashMap commit 1484d1cf84941e8489963c6a3dc4c12428c714e7 Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-06-10T04:40:22Z ZEPPELIN-707 Change cursor of new paragraph go at the end of the line commit 532e98edb615a7e47be3096cfd39017726d2a8b1 Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-06-10T04:47:02Z ZEPPELIN-707 Fix cannot find symbol error commit f3ab5ea7d49e1d1d62d05a9c804d0b54868768da Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-06-10T04:47:35Z ZEPPELIN-707 Fix cannot find symbol error commit 334b15ff7a81a083ecff6bcc780fd56b867cbcfe Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-06-16T04:56:51Z ZEPPELIN-707 Remove OccupiedInterpreter class. Add lastReplName in Note.java commit 85ee14b738c7ceeed2959e41a5ad25fa132de2a9 Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-06-16T05:36:35Z ZEPPELIN-707 Fix test in error commit 0fd122c34d2821ffbe11c7fd5806f608a2e8d24f Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-06-16T08:08:09Z ZEPPELIN-707 Modify checking nullable list location commit 4c0904bc77106c5dcc6b41524af2fe78050f875e Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-06-16T08:19:14Z ZEPPELIN-707 Resolved conflicts commit 720ffba3aa725e04e863dfa89819b530789e2b20 Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-06-16T08:19:39Z ZEPPELIN-707 Add note.setLastReplName in Rest API commit a159903a136677faf60d7dc72e8dbf53b0f79b34 Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-06-16T14:07:37Z ZEPPELIN-707 Modify return empty string when repl name is blank commit 3652dbbfb0d4f9dd75fa79a8b7591651388a9a17 Author: Minwoo Kang <minwoo.kang@outlook.com> Date: 2016-06-16T14:15:12Z ZEPPELIN-707 Add test case
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          I reopened this PR. But I think I have to fix some test case.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 I reopened this PR. But I think I have to fix some test case.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          Results :

          Failed tests:
          ParagraphActionsIT.testTitleButton:343 After Show Title : The title field contains
          Expected: "Untitled"
          but: was ""

          Tests in error:
          ParagraphActionsIT.testRemoveButton:143->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWait:110 쨩 Timeout
          ParagraphActionsIT.testMoveUpAndDown:180->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWait:110 쨩 Timeout
          ParagraphActionsIT.testCreateNewButton:75->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWait:110 쨩 Timeout
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 [ ] https://travis-ci.org/apache/zeppelin/jobs/138874097 `ZeppelinSparkClusterTest.sparkRTest:90` [ ] https://travis-ci.org/apache/zeppelin/jobs/138874103 ``` Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 104.235 sec - in org.apache.zeppelin.integration.ZeppelinIT Results : Failed tests: ParagraphActionsIT.testTitleButton:343 After Show Title : The title field contains Expected: "Untitled" but: was "" Tests in error: ParagraphActionsIT.testRemoveButton:143->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWait:110 쨩 Timeout ParagraphActionsIT.testMoveUpAndDown:180->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWait:110 쨩 Timeout ParagraphActionsIT.testCreateNewButton:75->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWait:110 쨩 Timeout ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          Yes, those test are not relevant to you. LGTM. I'll merge it into master.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/806 Yes, those test are not relevant to you. LGTM. I'll merge it into master.
          Hide
          jongyoul Jongyoul Lee added a comment -

          Issue resolved by pull request 806
          https://github.com/apache/zeppelin/pull/806

          Show
          jongyoul Jongyoul Lee added a comment - Issue resolved by pull request 806 https://github.com/apache/zeppelin/pull/806
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/806

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/806
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          Thanks for the contribution. I'm looking forward to see your next PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/806 Thanks for the contribution. I'm looking forward to see your next PR.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mwkang commented on the issue:

          https://github.com/apache/zeppelin/pull/806

          Wow thanks for your patience. This PR is a long period and lots of comments. I'll keep on trying my best.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 Wow thanks for your patience. This PR is a long period and lots of comments. I'll keep on trying my best.
          Hide
          bzz Alexander Bezzubov added a comment -

          Guys, I wanted to resume the discussion on whether it's the best way to handle this issue - it's quite annoying now that every paragraph have `%something` - even if I have chosen the default interpreter already!

          More then that, when the new paragraph gets created - the cursor stays on the same line as `%something ` (with the whitespace at the end!) which makes me hit enter before actually start coding.

          In both cases I feel current solution distracts more than helps.

          Looking for feedback to address the described problems!

          Show
          bzz Alexander Bezzubov added a comment - Guys, I wanted to resume the discussion on whether it's the best way to handle this issue - it's quite annoying now that every paragraph have `%something` - even if I have chosen the default interpreter already! More then that, when the new paragraph gets created - the cursor stays on the same line as `%something ` (with the whitespace at the end!) which makes me hit enter before actually start coding. In both cases I feel current solution distracts more than helps. Looking for feedback to address the described problems!
          Hide
          jongyoul Jongyoul Lee added a comment - - edited

          I agree that printing out '%somthing' feels uncomfortable sometimes. I thought it had a benefit to show default interpreter clearly and it would help to let user know which interpreter they use. Do you think we need to discuss more about this feature?

          Show
          jongyoul Jongyoul Lee added a comment - - edited I agree that printing out '%somthing' feels uncomfortable sometimes. I thought it had a benefit to show default interpreter clearly and it would help to let user know which interpreter they use. Do you think we need to discuss more about this feature?
          Hide
          moon Lee moon soo added a comment -

          How about display current interpreter selection as a button?
          Space or newline after the interpreter selection text (%xxxx) automatically convert it into button.
          I made a mockup. take a look.

          It gives visual separation between code and interpreter selection. and much easier to recognize type of paragraph. In this case, having this button in every paragraph make feel more comfortable even if it's default interpreter.

          What do you think?

          Show
          moon Lee moon soo added a comment - How about display current interpreter selection as a button? Space or newline after the interpreter selection text (%xxxx) automatically convert it into button. I made a mockup. take a look. It gives visual separation between code and interpreter selection. and much easier to recognize type of paragraph. In this case, having this button in every paragraph make feel more comfortable even if it's default interpreter. What do you think?
          Hide
          jongyoul Jongyoul Lee added a comment -

          It's similar to what IBM shows. I like this kind of view. It would be better to support backend natively, not parsing text from front-side.

          Show
          jongyoul Jongyoul Lee added a comment - It's similar to what IBM shows. I like this kind of view. It would be better to support backend natively, not parsing text from front-side.
          Hide
          moon Lee moon soo added a comment -

          Right, similar to design proposed here https://cwiki.apache.org/confluence/display/ZEPPELIN/Zeppelin+UX+Roadmap.

          Once backend knows the type of interpreter (parsing alias -> find interpreter), backend can store type of interpreter (interpreter group name, name) in note.json file. Then i think information can be used somehow for importing notebook with interpreter alias support ZEPPELIN-1012.

          Show
          moon Lee moon soo added a comment - Right, similar to design proposed here https://cwiki.apache.org/confluence/display/ZEPPELIN/Zeppelin+UX+Roadmap . Once backend knows the type of interpreter (parsing alias -> find interpreter), backend can store type of interpreter (interpreter group name, name) in note.json file. Then i think information can be used somehow for importing notebook with interpreter alias support ZEPPELIN-1012 .
          Hide
          jongyoul Jongyoul Lee added a comment -

          Sure, It would be helpful to catch an interpreter setting without parsing paragraph text.

          Show
          jongyoul Jongyoul Lee added a comment - Sure, It would be helpful to catch an interpreter setting without parsing paragraph text.
          Hide
          bzz Alexander Bezzubov added a comment - - edited

          I like button idea, thank you for sharing the mock! But can we make it clear that it is UI element that is outside of the paragraph text? (on the mock, it looks like it's inside the paragraph)

          The reason is - I think we strive for best text editing experience inside the input area of the paragraph and so it would be reasonable to keep that space for text only, and have buttons on top, as we do in right hand corner.

          And indeed it would be cool to know that interpreter binded to the paragraph without parsing it's text

          What do you think?

          Show
          bzz Alexander Bezzubov added a comment - - edited I like button idea, thank you for sharing the mock! But can we make it clear that it is UI element that is outside of the paragraph text? (on the mock, it looks like it's inside the paragraph) The reason is - I think we strive for best text editing experience inside the input area of the paragraph and so it would be reasonable to keep that space for text only, and have buttons on top, as we do in right hand corner. And indeed it would be cool to know that interpreter binded to the paragraph without parsing it's text What do you think?
          Hide
          moon Lee moon soo added a comment - - edited

          I thought placing button inside of text editor helps text editing experience.

          Because we can make 'overlay' button disappear in case of cursor moves to position of the button.
          Then text editing experience continuing and user can change interpreter selection without using mouse.

          At the same time, we can display dropdown list when button click, to change interpreter with mouse.

          If 'looknfeel' can customize location and style of button, that would be the best i think.
          At least current 'default' looknfeel, i tried place button outside of editor, and it doesn't look good.

          Show
          moon Lee moon soo added a comment - - edited I thought placing button inside of text editor helps text editing experience. Because we can make 'overlay' button disappear in case of cursor moves to position of the button. Then text editing experience continuing and user can change interpreter selection without using mouse. At the same time, we can display dropdown list when button click, to change interpreter with mouse. If 'looknfeel' can customize location and style of button, that would be the best i think. At least current 'default' looknfeel, i tried place button outside of editor, and it doesn't look good.
          Hide
          bzz Alexander Bezzubov added a comment - - edited

          Got it, thanks for explanation.

          If we could have as "Overlay" button that disappears on editing - that sounds interesting.

          The only thing is that - if it does not disappear after loosing focus - it kind of does not solve the issue that I was rising here initially. The issue was that even with just text, as it is now, having EVERY paragraph in my notebook start with %python or %spark - looks really distractive in case where I do not mix the interpreters.

          It is information that distracts author from writing new paragraphs, esp. in case when editing cursor in the new paragraph is ends up on this line by default: suddenly instead of focusing on the code I'm about to write - I'm forced to acknowledge that it's again %python interpreter and to press Enter to move to the line. This does not help productivity on writing and also looks not well on reading (repetitive, useless information overload).

          I feel that in case of a button that is present in every paragraph - on read that might look even more distractive, as all those buttons will have color, etc.

          Does it make sense, what do you guys think?

          Show
          bzz Alexander Bezzubov added a comment - - edited Got it, thanks for explanation. If we could have as "Overlay" button that disappears on editing - that sounds interesting. The only thing is that - if it does not disappear after loosing focus - it kind of does not solve the issue that I was rising here initially. The issue was that even with just text, as it is now, having EVERY paragraph in my notebook start with %python or %spark - looks really distractive in case where I do not mix the interpreters. It is information that distracts author from writing new paragraphs, esp. in case when editing cursor in the new paragraph is ends up on this line by default: suddenly instead of focusing on the code I'm about to write - I'm forced to acknowledge that it's again %python interpreter and to press Enter to move to the line. This does not help productivity on writing and also looks not well on reading (repetitive, useless information overload). I feel that in case of a button that is present in every paragraph - on read that might look even more distractive, as all those buttons will have color, etc. Does it make sense, what do you guys think?

            People

            • Assignee:
              minwoo.kang Minwoo Kang
              Reporter:
              enzoma Enzo Mar
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development