[ZEPPELIN-639] JDBCInterpreter should check for null

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.6.0
• Fix Version/s: 0.6.0
• Component/s: Interpreters
• Labels: jdbc
• Assignee: Unassigned
• Reporter: Chris Matta
• Created: 29/Jan/16 15:10
• Updated: 20/Feb/16 15:14
• Resolved: 20/Feb/16 15:14

Description

JDBCInterpreter.java should check for a null return on resultSet column instead of simply calling getString. Some incomplete, or poorly implemented JDBC drivers may not check for you. I've observed this behavior in the sqlline project.

Fix could be something like:

          while (resultSet.next() && displayRowCount < getMaxResult()) {
            for (int i = 1; i < md.getColumnCount() + 1; i++) {
              o = resultSet.getObject(i);
              if (o == null) {
                v = "null";
              } else {
                v = o.toString();
              }

              msg.append(replaceReservedChars(isTableType, v));