[ZEPPELIN-5927] Solve the concurrency calls to `saveNoteAuth`

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.0, 0.10.0, 0.10.1
• Fix Version/s: 0.11.0
• Component/s: zeppelin-zengine
• Assignee: Unassigned
• Reporter: yousj
• Created: 09/Jun/23 04:44
• Updated: 12/Jun/23 09:24
• Resolved: 12/Jun/23 09:24

Description

I have problems the concurrency calls to `saveNoteAuth`.
[related pull request |https://github.com/apache/zeppelin/pull/4563,] this pull request migrates solve the concurrency problem caused by multiple concurrent calls to `org.apache.zeppelin.notebook.AuthorizationService#saveNoteAuth`, but this can result in concurrent modifications to `notebook authorization.json`, then throw java.nio.file.NoSuchFileException.

Caused by: java.nio.file.NoSuchFileException: /usr/local/zeppelin-0.10.1-bin-all/conf/notebook-authorization.json
    at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
    at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
    at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
    at sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:447)
    at sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:262)
    at java.nio.file.Files.move(Files.java:1395)
    at org.apache.zeppelin.util.FileUtils.atomicWriteToFile(FileUtils.java:60)
    at org.apache.zeppelin.util.FileUtils.atomicWriteToFile(FileUtils.java:71)
    at org.apache.zeppelin.storage.LocalConfigStorage.save(LocalConfigStorage.java:71)
    at org.apache.zeppelin.notebook.AuthorizationService.saveNoteAuth(AuthorizationService.java:109)
    at org.apache.zeppelin.notebook.Notebook.createNote(Notebook.java:258)
    at org.apache.zeppelin.service.NotebookService.createNote(NotebookService.java:168) 

Issue Links

• links to: GitHub Pull Request #4613