[ZEPPELIN-4305] LocalStorageConfig.atomicWriteToFile incorrectly works with several mount points

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.9.0
• Fix Version/s: 0.9.0
• Assignee: Alex Ott
• Reporter: Alex Ott
• Created: 18/Aug/19 16:41
• Updated: 24/Dec/20 03:18
• Resolved: 29/Aug/19 10:13

Description

The hotfix made on 24th July, changed the code of that function to

      file.getParentFile().mkdirs();
      Files.move(tempFile.toPath(), destinationFilePath,
              StandardCopyOption.ATOMIC_MOVE);

but this generates AtomicMoveNotSupportedException when temporary directory is on separate disk as destination directory (like in my case, where /home is on separate disk):

java.nio.file.AtomicMoveNotSupportedException: /tmp/interpreter.json2988796503687403554.tmp -> /home/ott/work/zeppelin/zeppelin-ksql/conf/interpreter.json: Invalid cross-device link
	at sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:394)
	at sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:262)
	at java.nio.file.Files.move(Files.java:1395)
	at org.apache.zeppelin.storage.LocalConfigStorage.atomicWriteToFile(LocalConfigStorage.java:126)
	at org.apache.zeppelin.storage.LocalConfigStorage.save(LocalConfigStorage.java:59)
	at org.apache.zeppelin.interpreter.InterpreterSettingManager.saveToFile(InterpreterSettingManager.java:311)

Issue Links

• links to: GitHub Pull Request #3428
• links to: GitHub Pull Request #3439