Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-2850

changing the method of save-as.service.js from URI data scheme to createobjectURL + File API's blob feature

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.7.2
    • 0.8.0
    • None
    • None
    • CHROME!!

    Description

      in save-as.service.js, if we use URI Data scheme, which is the current situation, we could only contain 2MB data in chrome. using the createObjectURL and File API's blob feature, i managed to upgrade the capacity to about 900MB. plus this update is better in debugging too. if we exceed the 2MB limit in URI data scheme, the download just failed with no accurate console log originally, so it was kinda hard to know why this happens. But using this technique, if it exceeds the 900MB limit, the console log points directly about what the problem is. like this : Uncaught RangeError: Failed to construct 'Blob': Array length exceeds supported limit.

      https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/save-as/save-as.service.js

      Attachments

        Issue Links

          Activity

            People

              imnotkind imnotkind
              imnotkind imnotkind
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: