Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-2846

Add selenium test case for AnyOfRolesAuthorizationFilter

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: front-end
    • Labels:
      None

      Description

      This is to test the new feature that was brought in with ZEPPELIN-2825 (org.apache.zeppelin.utils.AnyOfRolesAuthorizationFilter)

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user prabhjyotsingh opened a pull request:

          https://github.com/apache/zeppelin/pull/2524

          ZEPPELIN-2846 Add selenium test case for AnyOfRolesAuthorizationFilter

              1. What is this PR for?
                This is to test the new feature that was brought in with ZEPPELIN-2825 (org.apache.zeppelin.utils.AnyOfRolesAuthorizationFilter)
              1. What type of PR is it?
                [Improvement]
              1. What is the Jira issue?
              1. How should this be tested?
                CI should be green
              1. Questions:
          • Does the licenses files need update? N/A
          • Is there breaking changes for older versions? N/A
          • Does this needs documentation? N/A

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2846

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/2524.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2524


          commit e2a7ad548516a91c774afeb80d905859c47f8983
          Author: Prabhjyot Singh <prabhjyotsingh@gmail.com>
          Date: 2017-08-10T23:27:28Z

          add selenium test case for AnyOfRolesAuthorizationFilter


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2524 ZEPPELIN-2846 Add selenium test case for AnyOfRolesAuthorizationFilter What is this PR for? This is to test the new feature that was brought in with ZEPPELIN-2825 (org.apache.zeppelin.utils.AnyOfRolesAuthorizationFilter) What type of PR is it? [Improvement] What is the Jira issue? ZEPPELIN-2846 ( https://issues.apache.org/jira/browse/ZEPPELIN-2846 ) How should this be tested? CI should be green Questions: Does the licenses files need update? N/A Is there breaking changes for older versions? N/A Does this needs documentation? N/A You can merge this pull request into a Git repository by running: $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2846 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2524.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2524 commit e2a7ad548516a91c774afeb80d905859c47f8983 Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Date: 2017-08-10T23:27:28Z add selenium test case for AnyOfRolesAuthorizationFilter
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user prabhjyotsingh commented on the issue:

          https://github.com/apache/zeppelin/pull/2524

          Ready for review, https://travis-ci.org/prabhjyotsingh/zeppelin/builds/263300475. 439.2 Failed which is unrelated (have restarted it).

          Show
          githubbot ASF GitHub Bot added a comment - Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2524 Ready for review, https://travis-ci.org/prabhjyotsingh/zeppelin/builds/263300475 . 439.2 Failed which is unrelated (have restarted it).
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user prabhjyotsingh closed the pull request at:

          https://github.com/apache/zeppelin/pull/2524

          Show
          githubbot ASF GitHub Bot added a comment - Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2524
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user prabhjyotsingh reopened a pull request:

          https://github.com/apache/zeppelin/pull/2524

          ZEPPELIN-2846 Add selenium test case for AnyOfRolesAuthorizationFilter

              1. What is this PR for?
                This is to test the new feature that was brought in with ZEPPELIN-2825 (org.apache.zeppelin.utils.AnyOfRolesAuthorizationFilter)
              1. What type of PR is it?
                [Improvement]
              1. What is the Jira issue?
              1. How should this be tested?
                CI should be green
              1. Questions:
          • Does the licenses files need update? N/A
          • Is there breaking changes for older versions? N/A
          • Does this needs documentation? N/A

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2846

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/2524.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2524


          commit e2a7ad548516a91c774afeb80d905859c47f8983
          Author: Prabhjyot Singh <prabhjyotsingh@gmail.com>
          Date: 2017-08-10T23:27:28Z

          add selenium test case for AnyOfRolesAuthorizationFilter


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2524 ZEPPELIN-2846 Add selenium test case for AnyOfRolesAuthorizationFilter What is this PR for? This is to test the new feature that was brought in with ZEPPELIN-2825 (org.apache.zeppelin.utils.AnyOfRolesAuthorizationFilter) What type of PR is it? [Improvement] What is the Jira issue? ZEPPELIN-2846 ( https://issues.apache.org/jira/browse/ZEPPELIN-2846 ) How should this be tested? CI should be green Questions: Does the licenses files need update? N/A Is there breaking changes for older versions? N/A Does this needs documentation? N/A You can merge this pull request into a Git repository by running: $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2846 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2524.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2524 commit e2a7ad548516a91c774afeb80d905859c47f8983 Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Date: 2017-08-10T23:27:28Z add selenium test case for AnyOfRolesAuthorizationFilter
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user prabhjyotsingh commented on the issue:

          https://github.com/apache/zeppelin/pull/2524

          @1ambda @Leemoonsoo @VipinRathor Please help review this.

          Show
          githubbot ASF GitHub Bot added a comment - Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2524 @1ambda @Leemoonsoo @VipinRathor Please help review this.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user VipinRathor commented on the issue:

          https://github.com/apache/zeppelin/pull/2524

          Reviewed. Looks good to me.

          Show
          githubbot ASF GitHub Bot added a comment - Github user VipinRathor commented on the issue: https://github.com/apache/zeppelin/pull/2524 Reviewed. Looks good to me.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/2524

          LGTM!

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2524 LGTM!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user prabhjyotsingh commented on the issue:

          https://github.com/apache/zeppelin/pull/2524

          Thanks for the review will merge this if no more discussion.

          Show
          githubbot ASF GitHub Bot added a comment - Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2524 Thanks for the review will merge this if no more discussion.
          Hide
          prabhjyotsingh Prabhjyot Singh added a comment -

          Issue resolved by pull request 2524
          https://github.com/apache/zeppelin/pull/2524

          Show
          prabhjyotsingh Prabhjyot Singh added a comment - Issue resolved by pull request 2524 https://github.com/apache/zeppelin/pull/2524
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/2524

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2524

            People

            • Assignee:
              prabhjyotsingh Prabhjyot Singh
              Reporter:
              prabhjyotsingh Prabhjyot Singh
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development