Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-247

UI assumes WebSocket connection state as disconnected

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.5.5
    • GUI
    • None

    Description

      UI (navbar.controller.js) assumes WebSocket connection as disconnected.
      It should get the state from WebSocketService.

      var vm = this;
      vm.notes = notebookListDataFactory;
      vm.connected = false
      vm.websocketMsgSrv = websocketMsgSrv;
      

      where as it should be something like

      vm.connected = websocketMsgSrv.isConnected();
      

      Attachments

        Activity

          prabhjyotsingh Prabhjyot Singh created issue -
          githubbot ASF GitHub Bot added a comment -

          GitHub user prabhjyotsingh opened a pull request:

          https://github.com/apache/incubator-zeppelin/pull/236

          ZEPPELIN-247: fix; navbar.controller.js used to assumes WebSocket connection as disconnected.

          ZEPPELIN-247: fix; navbar.controller.js used to assumes WebSocket connection as disconnected.
          It should get the state from WebSocketService.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/prabhjyotsingh/incubator-zeppelin ZEPPELIN-247

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-zeppelin/pull/236.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #236


          commit 16465305b8338170ffcb77279a99157b36e67068
          Author: Prabhjyot Singh <prabhjyotsingh@gmail.com>
          Date: 2015-08-21T06:18:01Z

          ZEPPELIN-247: fix; navbar.controller.js used to assumes WebSocket connection as disconnected.
          It should get the state from WebSocketService.


          githubbot ASF GitHub Bot added a comment - GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/incubator-zeppelin/pull/236 ZEPPELIN-247 : fix; navbar.controller.js used to assumes WebSocket connection as disconnected. ZEPPELIN-247 : fix; navbar.controller.js used to assumes WebSocket connection as disconnected. It should get the state from WebSocketService. You can merge this pull request into a Git repository by running: $ git pull https://github.com/prabhjyotsingh/incubator-zeppelin ZEPPELIN-247 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-zeppelin/pull/236.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #236 commit 16465305b8338170ffcb77279a99157b36e67068 Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Date: 2015-08-21T06:18:01Z ZEPPELIN-247 : fix; navbar.controller.js used to assumes WebSocket connection as disconnected. It should get the state from WebSocketService.
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/236#issuecomment-133485488

          LGTM!

          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/236#issuecomment-133485488 LGTM!
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-zeppelin/pull/236

          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/236
          moon Lee Moon Soo made changes -
          Field Original Value New Value
          Fix Version/s 0.6.0 [ 12332761 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          moon Lee Moon Soo made changes -
          Fix Version/s 0.5.5 [ 12333531 ]
          Fix Version/s 0.6.0 [ 12332761 ]

          People

            prabhjyotsingh Prabhjyot Singh
            prabhjyotsingh Prabhjyot Singh
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: