[ZEPPELIN-2410] (Windows) Helium.java fails to create HeliumOnlineRegistry

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8.0
• Fix Version/s: 0.8.0
• Component/s: zeppelin-zengine

Environment

Windows 7

• Assignee: Christian Fries
• Reporter: Christian Fries
• Created: 16/Apr/17 22:36
• Updated: 23/Apr/17 02:15
• Resolved: 23/Apr/17 02:15

Description

I have to do further testing, but it appears as if the line

registry.add(new HeliumOnlineRegistry(uri, uri, registryCacheDir));

in Helium.java
https://github.com/apache/zeppelin/blame/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/Helium.java#L112
causes a problem, because the uri is used as filename (first argument of HeliumOnlineRegistry). This will create a file of the name https://s3.amazonaws.com/helium-package/helium.json

(the full uri is the file name). The : after https will cause problems in windows.

The following is an extract from the Zeppelin log on a Windows 7 system:

 WARN [2017-04-16 02:31:46,006] ({main} Helium.java[loadConf]:122) - Z:\Dokumente\Development\Repositories\cfries-zeppelin\conf/helium.json does not exists
ERROR [2017-04-16 02:31:47,629] ({main} Helium.java[getAllPackageInfo]:207) - Directory 'Z:\Dokumente\Development\Repositories\cfries-zeppelin\local-repo\helium-registry-cache\https:\s3.amazonaws.com\helium-package' could not be created
java.io.IOException: Directory 'Z:\Dokumente\Development\Repositories\cfries-zeppelin\local-repo\helium-registry-cache\https:\s3.amazonaws.com\helium-package' could not be created

The following is a console output on a macOS Sierra system:

Vesper:helium-package fries$ pwd
/[...]/zeppelin/local-repo/helium-registry-cache/https:/s3.amazonaws.com/helium-package
Vesper:helium-package fries$ ls
helium.json

Alternatives I see:

• use only helium.json as file name
• use a hash on the URI as file name
• remove the https: and use the remainder as file name

If you like, I can prepare a pull request.

Issue Links

• relates to: ZEPPELIN-2440 [Umbrella] Platform Compatibility Issues
• links to: GitHub Pull Request #2276