Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-2164

Typo in Insufficient Privileges popup of Zeppelin

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 0.7.1, 0.8.0
    • GUI
    • None

    Description

      When trying to delete a note of another user Zeppelin correctly throws a popup for insufficient privileges but has a small typo "removenote" (no space between remove note). Similar issue exist for renaming notebook "renamenote".

      Attachments

        1. removenote.png
          72 kB
          Deepesh Khandelwal
        2. renamenote.png
          69 kB
          Deepesh Khandelwal

        Issue Links

          Activity

            Attaching screenshot depicting the issue.

            deepesh Deepesh Khandelwal added a comment - Attaching screenshot depicting the issue.
            githubbot ASF GitHub Bot added a comment -

            GitHub user prabhjyotsingh opened a pull request:

            https://github.com/apache/zeppelin/pull/2064

            ZEPPELIN-2164 Typo in Insufficient Privileges popup of Zeppelin

                1. What is this PR for?
                  When trying to delete a note of another user Zeppelin correctly throws a popup for insufficient privileges but has a small typo "removenote" (no space between remove note). Similar issue exist for renaming notebook "renamenote".
                1. What type of PR is it?
                  [Bug Fix]
                1. What is the Jira issue?
                1. How should this be tested?
                  Refer before/after screen shot
                1. Screenshots (if appropriate)
                  Before:
                  <img width="628" alt="screen shot 2017-02-24 at 11 49 59 am 1" src="https://cloud.githubusercontent.com/assets/674497/23292690/66b808fa-fa87-11e6-9bde-4f9fbbb1cb67.png">

            After:
            <img width="645" alt="screen shot 2017-02-24 at 11 48 35 am" src="https://cloud.githubusercontent.com/assets/674497/23292691/66c0e9c0-fa87-11e6-9abc-16dc7b52ce3c.png">

                1. Questions:
            • Does the licenses files need update?
            • Is there breaking changes for older versions?
            • Does this needs documentation?

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2164

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/zeppelin/pull/2064.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #2064


            commit c4c8222f83114655956d160f684858b5c6e21fe3
            Author: Prabhjyot Singh <prabhjyotsingh@gmail.com>
            Date: 2017-02-24T06:17:24Z

            ZEPPELIN-2164: Typo in Insufficient Privileges popup of Zeppelin


            githubbot ASF GitHub Bot added a comment - GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2064 ZEPPELIN-2164 Typo in Insufficient Privileges popup of Zeppelin What is this PR for? When trying to delete a note of another user Zeppelin correctly throws a popup for insufficient privileges but has a small typo "removenote" (no space between remove note). Similar issue exist for renaming notebook "renamenote". What type of PR is it? [Bug Fix] What is the Jira issue? ZEPPELIN-2164 ( https://issues.apache.org/jira/browse/ZEPPELIN-2164 ) How should this be tested? Refer before/after screen shot Screenshots (if appropriate) Before: <img width="628" alt="screen shot 2017-02-24 at 11 49 59 am 1" src="https://cloud.githubusercontent.com/assets/674497/23292690/66b808fa-fa87-11e6-9bde-4f9fbbb1cb67.png"> After: <img width="645" alt="screen shot 2017-02-24 at 11 48 35 am" src="https://cloud.githubusercontent.com/assets/674497/23292691/66c0e9c0-fa87-11e6-9abc-16dc7b52ce3c.png"> Questions: Does the licenses files need update? Is there breaking changes for older versions? Does this needs documentation? You can merge this pull request into a Git repository by running: $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2164 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2064.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2064 commit c4c8222f83114655956d160f684858b5c6e21fe3 Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Date: 2017-02-24T06:17:24Z ZEPPELIN-2164 : Typo in Insufficient Privileges popup of Zeppelin
            githubbot ASF GitHub Bot added a comment -

            Github user prabhjyotsingh commented on the issue:

            https://github.com/apache/zeppelin/pull/2064

            @Leemoonsoo help review this.

            githubbot ASF GitHub Bot added a comment - Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2064 @Leemoonsoo help review this.
            githubbot ASF GitHub Bot added a comment -

            Github user r-kamath commented on the issue:

            https://github.com/apache/zeppelin/pull/2064

            LGTM

            githubbot ASF GitHub Bot added a comment - Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/2064 LGTM
            githubbot ASF GitHub Bot added a comment -

            Github user khalidhuseynov commented on the issue:

            https://github.com/apache/zeppelin/pull/2064

            LGTM

            githubbot ASF GitHub Bot added a comment - Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2064 LGTM
            githubbot ASF GitHub Bot added a comment -

            Github user prabhjyotsingh commented on the issue:

            https://github.com/apache/zeppelin/pull/2064

            Merging this to master and branch-0.7 if no more discussion.

            githubbot ASF GitHub Bot added a comment - Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2064 Merging this to master and branch-0.7 if no more discussion.
            githubbot ASF GitHub Bot added a comment -

            Github user prabhjyotsingh commented on the issue:

            https://github.com/apache/zeppelin/pull/2064

            On re-triggering CI is green now. https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204868665.

            githubbot ASF GitHub Bot added a comment - Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2064 On re-triggering CI is green now. https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204868665 .
            githubbot ASF GitHub Bot added a comment -

            Github user AhyoungRyu commented on the issue:

            https://github.com/apache/zeppelin/pull/2064

            @prabhjyotsingh FYI, you can change the red light to the green by closing and reopening this PR

            githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2064 @prabhjyotsingh FYI, you can change the red light to the green by closing and reopening this PR
            githubbot ASF GitHub Bot added a comment -

            Github user prabhjyotsingh closed the pull request at:

            https://github.com/apache/zeppelin/pull/2064

            githubbot ASF GitHub Bot added a comment - Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2064
            githubbot ASF GitHub Bot added a comment -

            GitHub user prabhjyotsingh reopened a pull request:

            https://github.com/apache/zeppelin/pull/2064

            ZEPPELIN-2164 Typo in Insufficient Privileges popup of Zeppelin

                1. What is this PR for?
                  When trying to delete a note of another user Zeppelin correctly throws a popup for insufficient privileges but has a small typo "removenote" (no space between remove note). Similar issue exist for renaming notebook "renamenote".
                1. What type of PR is it?
                  [Bug Fix]
                1. What is the Jira issue?
                1. How should this be tested?
                  Refer before/after screen shot
                1. Screenshots (if appropriate)
                  Before:
                  <img width="628" alt="screen shot 2017-02-24 at 11 49 59 am 1" src="https://cloud.githubusercontent.com/assets/674497/23292690/66b808fa-fa87-11e6-9bde-4f9fbbb1cb67.png">

            After:
            <img width="645" alt="screen shot 2017-02-24 at 11 48 35 am" src="https://cloud.githubusercontent.com/assets/674497/23292691/66c0e9c0-fa87-11e6-9abc-16dc7b52ce3c.png">

                1. Questions:
            • Does the licenses files need update?
            • Is there breaking changes for older versions?
            • Does this needs documentation?

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2164

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/zeppelin/pull/2064.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #2064


            commit c4c8222f83114655956d160f684858b5c6e21fe3
            Author: Prabhjyot Singh <prabhjyotsingh@gmail.com>
            Date: 2017-02-24T06:17:24Z

            ZEPPELIN-2164: Typo in Insufficient Privileges popup of Zeppelin


            githubbot ASF GitHub Bot added a comment - GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2064 ZEPPELIN-2164 Typo in Insufficient Privileges popup of Zeppelin What is this PR for? When trying to delete a note of another user Zeppelin correctly throws a popup for insufficient privileges but has a small typo "removenote" (no space between remove note). Similar issue exist for renaming notebook "renamenote". What type of PR is it? [Bug Fix] What is the Jira issue? ZEPPELIN-2164 ( https://issues.apache.org/jira/browse/ZEPPELIN-2164 ) How should this be tested? Refer before/after screen shot Screenshots (if appropriate) Before: <img width="628" alt="screen shot 2017-02-24 at 11 49 59 am 1" src="https://cloud.githubusercontent.com/assets/674497/23292690/66b808fa-fa87-11e6-9bde-4f9fbbb1cb67.png"> After: <img width="645" alt="screen shot 2017-02-24 at 11 48 35 am" src="https://cloud.githubusercontent.com/assets/674497/23292691/66c0e9c0-fa87-11e6-9abc-16dc7b52ce3c.png"> Questions: Does the licenses files need update? Is there breaking changes for older versions? Does this needs documentation? You can merge this pull request into a Git repository by running: $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2164 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2064.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2064 commit c4c8222f83114655956d160f684858b5c6e21fe3 Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Date: 2017-02-24T06:17:24Z ZEPPELIN-2164 : Typo in Insufficient Privileges popup of Zeppelin
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/zeppelin/pull/2064

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2064

            Issue resolved by pull request 2064
            https://github.com/apache/zeppelin/pull/2064

            prabhjyotsingh Prabhjyot Singh added a comment - Issue resolved by pull request 2064 https://github.com/apache/zeppelin/pull/2064

            People

              prabhjyotsingh Prabhjyot Singh
              deepesh Deepesh Khandelwal
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: