Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-1825

Use version controlled notebook repo by default.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: None
    • Labels:
      None

      Description

      After ZEPPELIN-1190, user can create and view checkpoints of note.

      However, default notebook repo (VFSNotebookRepo) does not implement checkpoint() and user will see "Couldn't checkpoint note revision: possibly storage doesn't support versioning. Please check the logs for more details." message.

      How about use notebook repo that support checkpoint() as a default?
      So user can use checkpoint feature with zero configuration.

      I think we can use GitNotebookRepo as a default one

        Issue Links

          Activity

          Hide
          khalidhuseynov Khalid Huseynov added a comment -

          I was planning to do from long time ago once versioning in git fully completed

          Show
          khalidhuseynov Khalid Huseynov added a comment - I was planning to do from long time ago once versioning in git fully completed
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user khalidhuseynov opened a pull request:

          https://github.com/apache/zeppelin/pull/1844

          ZEPPELIN-1825 Use versioned notebook storage by default

              1. What is this PR for?
                Due to recent work on versioned notes under ZEPPELIN-1044, we can use by default Git storage which extends local storage. so the behaviour will be same as before with additional ability to use versioning out of box without configuring it.
              1. What type of PR is it?
                Improvement | Refactoring
              1. Todos
          • [x] - change VFS to Git
              1. What is the Jira issue?
                ZEPPELIN-1825(https://issues.apache.org/jira/browse/ZEPPELIN-1825)
              1. How should this be tested?
                start zeppelin and by default be able to use version control (if git client installed)
              1. Screenshots (if appropriate)
              1. Questions:
          • Does the licenses files need update? no
          • Is there breaking changes for older versions? no
          • Does this needs documentation? no

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/khalidhuseynov/incubator-zeppelin default-git-repo

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1844.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1844


          commit cb9e9fb394851ae6028003bdf6d9f7af6a7b4ec1
          Author: Khalid Huseynov <khalidhnv@gmail.com>
          Date: 2017-01-05T05:24:50Z

          modify default storage to git repo

          commit 5edd5e0a321c10b94100ff9dcdca67e35bf5ac2c
          Author: Khalid Huseynov <khalidhnv@gmail.com>
          Date: 2017-01-05T05:32:01Z

          fix in zeppelin-site.xml


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1844 ZEPPELIN-1825 Use versioned notebook storage by default What is this PR for? Due to recent work on versioned notes under ZEPPELIN-1044 , we can use by default Git storage which extends local storage. so the behaviour will be same as before with additional ability to use versioning out of box without configuring it. What type of PR is it? Improvement | Refactoring Todos [x] - change VFS to Git What is the Jira issue? ZEPPELIN-1825 ( https://issues.apache.org/jira/browse/ZEPPELIN-1825 ) How should this be tested? start zeppelin and by default be able to use version control (if git client installed) Screenshots (if appropriate) Questions: Does the licenses files need update? no Is there breaking changes for older versions? no Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/khalidhuseynov/incubator-zeppelin default-git-repo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1844.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1844 commit cb9e9fb394851ae6028003bdf6d9f7af6a7b4ec1 Author: Khalid Huseynov <khalidhnv@gmail.com> Date: 2017-01-05T05:24:50Z modify default storage to git repo commit 5edd5e0a321c10b94100ff9dcdca67e35bf5ac2c Author: Khalid Huseynov <khalidhnv@gmail.com> Date: 2017-01-05T05:32:01Z fix in zeppelin-site.xml
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user khalidhuseynov closed the pull request at:

          https://github.com/apache/zeppelin/pull/1844

          Show
          githubbot ASF GitHub Bot added a comment - Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1844
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user khalidhuseynov reopened a pull request:

          https://github.com/apache/zeppelin/pull/1844

          ZEPPELIN-1825 Use versioned notebook storage by default

              1. What is this PR for?
                Due to recent work on versioned notes under ZEPPELIN-1044, we can use by default Git storage which extends local storage. so the behaviour will be same as before with additional ability to use versioning out of box without configuring it.
              1. What type of PR is it?
                Improvement | Refactoring
              1. Todos
          • [x] - change VFS to Git
              1. What is the Jira issue?
                ZEPPELIN-1825(https://issues.apache.org/jira/browse/ZEPPELIN-1825)
              1. How should this be tested?
                start zeppelin and by default be able to use version control (if git client installed)
              1. Screenshots (if appropriate)
              1. Questions:
          • Does the licenses files need update? no
          • Is there breaking changes for older versions? no
          • Does this needs documentation? no

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/khalidhuseynov/incubator-zeppelin default-git-repo

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1844.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1844


          commit cb9e9fb394851ae6028003bdf6d9f7af6a7b4ec1
          Author: Khalid Huseynov <khalidhnv@gmail.com>
          Date: 2017-01-05T05:24:50Z

          modify default storage to git repo

          commit 5edd5e0a321c10b94100ff9dcdca67e35bf5ac2c
          Author: Khalid Huseynov <khalidhnv@gmail.com>
          Date: 2017-01-05T05:32:01Z

          fix in zeppelin-site.xml


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user khalidhuseynov reopened a pull request: https://github.com/apache/zeppelin/pull/1844 ZEPPELIN-1825 Use versioned notebook storage by default What is this PR for? Due to recent work on versioned notes under ZEPPELIN-1044 , we can use by default Git storage which extends local storage. so the behaviour will be same as before with additional ability to use versioning out of box without configuring it. What type of PR is it? Improvement | Refactoring Todos [x] - change VFS to Git What is the Jira issue? ZEPPELIN-1825 ( https://issues.apache.org/jira/browse/ZEPPELIN-1825 ) How should this be tested? start zeppelin and by default be able to use version control (if git client installed) Screenshots (if appropriate) Questions: Does the licenses files need update? no Is there breaking changes for older versions? no Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/khalidhuseynov/incubator-zeppelin default-git-repo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1844.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1844 commit cb9e9fb394851ae6028003bdf6d9f7af6a7b4ec1 Author: Khalid Huseynov <khalidhnv@gmail.com> Date: 2017-01-05T05:24:50Z modify default storage to git repo commit 5edd5e0a321c10b94100ff9dcdca67e35bf5ac2c Author: Khalid Huseynov <khalidhnv@gmail.com> Date: 2017-01-05T05:32:01Z fix in zeppelin-site.xml
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user felixcheung commented on the issue:

          https://github.com/apache/zeppelin/pull/1844

          LGTM
          any documentation to update?

          Show
          githubbot ASF GitHub Bot added a comment - Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1844 LGTM any documentation to update?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user khalidhuseynov commented on the issue:

          https://github.com/apache/zeppelin/pull/1844

          @felixcheung i didn't see much places to update docs, but maybe @AhyoungRyu knows if there's something to be updated?

          Show
          githubbot ASF GitHub Bot added a comment - Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1844 @felixcheung i didn't see much places to update docs, but maybe @AhyoungRyu knows if there's something to be updated?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1844

          `VFSNotebookRepo` can be configured to use [other filesystems](https://commons.apache.org/proper/commons-vfs/filesystems.html) instead of local filesystem.
          Those user might be confused when (default) notebook repo is changed to `GitNotebookRepo`.

          How about add an item in [upgrade.md](https://github.com/apache/zeppelin/blob/master/docs/install/upgrade.md#upgrading-from-zeppelin-06-to-07) for this change?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1844 `VFSNotebookRepo` can be configured to use [other filesystems] ( https://commons.apache.org/proper/commons-vfs/filesystems.html ) instead of local filesystem. Those user might be confused when (default) notebook repo is changed to `GitNotebookRepo`. How about add an item in [upgrade.md] ( https://github.com/apache/zeppelin/blob/master/docs/install/upgrade.md#upgrading-from-zeppelin-06-to-07 ) for this change?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user khalidhuseynov commented on the issue:

          https://github.com/apache/zeppelin/pull/1844

          @Leemoonsoo makes sense, added in 7cb133c8dc59357b0572c4f462ae04d5bbb55cce

          Show
          githubbot ASF GitHub Bot added a comment - Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1844 @Leemoonsoo makes sense, added in 7cb133c8dc59357b0572c4f462ae04d5bbb55cce
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1844

          Thanks @khalidhuseynov for the improvement.

          LGTM and merge if no more comments!

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1844 Thanks @khalidhuseynov for the improvement. LGTM and merge if no more comments!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1844

          @khalidhuseynov Seems a default value of `ZEPPELIN_NOTEBOOK_STORAGE ` under [Apache Zeppelin configuration](https://github.com/apache/zeppelin/blob/master/docs/install/install.md#apache-zeppelin-configuration) table also needs to be updated

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1844 @khalidhuseynov Seems a default value of `ZEPPELIN_NOTEBOOK_STORAGE ` under [Apache Zeppelin configuration] ( https://github.com/apache/zeppelin/blob/master/docs/install/install.md#apache-zeppelin-configuration ) table also needs to be updated
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user khalidhuseynov commented on the issue:

          https://github.com/apache/zeppelin/pull/1844

          thanks @AhyoungRyu, updated!

          Show
          githubbot ASF GitHub Bot added a comment - Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1844 thanks @AhyoungRyu, updated!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1844

          LGTM 👍

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1844 LGTM 👍
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/1844

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1844

            People

            • Assignee:
              khalidhuseynov Khalid Huseynov
              Reporter:
              moon Lee moon soo
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development