Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-1785

Remove ZEPPELIN_NOTEBOOK_DIR and ZEPPELIN_INTERPRETER_DIR from common.sh

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.7.0
    • 0.7.0
    • None
    • None

    Description

      The current issue I found is that zeppelin.notebook.dir defined in zeppelin-site.xml doesn't take effect. Because we define it in https://github.com/apache/zeppelin/blob/master/bin/common.sh#L52 and ZeppelinConfiguration will pick up configugration through enviroment variable over property defined in zeppelin-site.xml. (https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L192). I think some other conf like zeppelin.interpreter.dir are the same.

      There're 2 approaches for it.

      • Remove them in common.sh
      • Preferer property in zeppelin-site.xml over enviroment variable.

      Personally, I prefer the second approach. As I think property is easier to understand, and we should use zeppelin-site as the central place for all the configurations. This is also the approach what spark use.
      \cc moon luciano resende anthonycorbacho jongyoul

      Attachments

        Activity

          People

            zjffdu Jeff Zhang
            zjffdu Jeff Zhang
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: