Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-1683

Let PythonInterpreter runs python process in docker container

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: python-interpreter
    • Labels:
      None

      Description

      It would be useful if %python.docker interpreter behave similar to %python.conda and provide ability to run python process in docker container.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Leemoonsoo opened a pull request:

          https://github.com/apache/zeppelin/pull/1654

          ZEPPELIN-1683 Run python process in docker container

              1. What is this PR for?
                Inspired by ZEPPELIN-1671 conda interpreter.
                Docker can provides kind of virtual environment for python like conda does.
                This PR implements %python.docker interpreter that helps run python process in docker container.
                This PR implements feature on top of https://github.com/apache/zeppelin/pull/1645
              1. What type of PR is it?
                Feature
              1. Todos
          • [x] - basic feature
          • [ ] - unittest
          • [ ] - documentation
              1. What is the Jira issue?
                https://issues.apache.org/jira/browse/ZEPPELIN-1683
              1. How should this be tested?
                see screenshot
              1. Screenshots (if appropriate)
                ![pydocker](https://cloud.githubusercontent.com/assets/1540981/20421814/38a93a9c-ad1b-11e6-8a64-2d0230ff4d8a.gif)
              1. Questions:
          • Does the licenses files need update? no
          • Is there breaking changes for older versions? no
          • Does this needs documentation? yes

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Leemoonsoo/zeppelin pydocker

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1654.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1654


          commit 394cf8c00641d251fe023d63cda31a4f872cf3dd
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-16T04:18:08Z

          Conda interpreter implementation

          commit 1223796931b38af1c2351fdda91ad31b4dcf814c
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-16T04:28:21Z

          Remove unnecessary log

          commit 6b9525f303154c5eda65f12256b9bfc13d7c4c58
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-17T18:40:13Z

          Fix unittest

          commit 171cbeb003f59c82af90713807faafea281829b1
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T03:55:47Z

          make sure single char interpreter name can be parsed

          commit 9ae553b55797c3545b04858928ec2715cbe81d43
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T03:56:17Z

          Format output and add usage command

          commit b889443008aa91f786a6b6c1dec974dccd51595a
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T03:59:31Z

          add usage template

          commit d979c6af9aed1383844cd306f4f6fd5490ba1dcb
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T05:40:38Z

          Add unittest

          commit 4842b0ae2431d77d0980af628a91dd3f71254b22
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T05:59:12Z

          Add usage in doc

          commit c20cb9daf82699d33818ed98c7e869f9e0fbfeb4
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T07:14:42Z

          Add PythonDockerInterpreter


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1654 ZEPPELIN-1683 Run python process in docker container What is this PR for? Inspired by ZEPPELIN-1671 conda interpreter. Docker can provides kind of virtual environment for python like conda does. This PR implements %python.docker interpreter that helps run python process in docker container. This PR implements feature on top of https://github.com/apache/zeppelin/pull/1645 What type of PR is it? Feature Todos [x] - basic feature [ ] - unittest [ ] - documentation What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1683 How should this be tested? see screenshot Screenshots (if appropriate) ! [pydocker] ( https://cloud.githubusercontent.com/assets/1540981/20421814/38a93a9c-ad1b-11e6-8a64-2d0230ff4d8a.gif ) Questions: Does the licenses files need update? no Is there breaking changes for older versions? no Does this needs documentation? yes You can merge this pull request into a Git repository by running: $ git pull https://github.com/Leemoonsoo/zeppelin pydocker Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1654.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1654 commit 394cf8c00641d251fe023d63cda31a4f872cf3dd Author: Lee moon soo <moon@apache.org> Date: 2016-11-16T04:18:08Z Conda interpreter implementation commit 1223796931b38af1c2351fdda91ad31b4dcf814c Author: Lee moon soo <moon@apache.org> Date: 2016-11-16T04:28:21Z Remove unnecessary log commit 6b9525f303154c5eda65f12256b9bfc13d7c4c58 Author: Lee moon soo <moon@apache.org> Date: 2016-11-17T18:40:13Z Fix unittest commit 171cbeb003f59c82af90713807faafea281829b1 Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T03:55:47Z make sure single char interpreter name can be parsed commit 9ae553b55797c3545b04858928ec2715cbe81d43 Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T03:56:17Z Format output and add usage command commit b889443008aa91f786a6b6c1dec974dccd51595a Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T03:59:31Z add usage template commit d979c6af9aed1383844cd306f4f6fd5490ba1dcb Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T05:40:38Z Add unittest commit 4842b0ae2431d77d0980af628a91dd3f71254b22 Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T05:59:12Z Add usage in doc commit c20cb9daf82699d33818ed98c7e869f9e0fbfeb4 Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T07:14:42Z Add PythonDockerInterpreter
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Leemoonsoo reopened a pull request:

          https://github.com/apache/zeppelin/pull/1654

          ZEPPELIN-1683 Run python process in docker container

              1. What is this PR for?
                Inspired by ZEPPELIN-1671 conda interpreter.
                Docker can provides kind of virtual environment for python like conda does.
                This PR implements %python.docker interpreter that helps run python process in docker container.
                This PR implements feature on top of https://github.com/apache/zeppelin/pull/1645
              1. What type of PR is it?
                Feature
              1. Todos
          • [x] - basic feature
          • [x] - unittest
          • [x] - documentation
              1. What is the Jira issue?
                https://issues.apache.org/jira/browse/ZEPPELIN-1683
              1. How should this be tested?
                see screenshot
              1. Screenshots (if appropriate)
                ![pydocker](https://cloud.githubusercontent.com/assets/1540981/20421814/38a93a9c-ad1b-11e6-8a64-2d0230ff4d8a.gif)
              1. Questions:
          • Does the licenses files need update? no
          • Is there breaking changes for older versions? no
          • Does this needs documentation? yes

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Leemoonsoo/zeppelin pydocker

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1654.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1654


          commit 394cf8c00641d251fe023d63cda31a4f872cf3dd
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-16T04:18:08Z

          Conda interpreter implementation

          commit 1223796931b38af1c2351fdda91ad31b4dcf814c
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-16T04:28:21Z

          Remove unnecessary log

          commit 6b9525f303154c5eda65f12256b9bfc13d7c4c58
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-17T18:40:13Z

          Fix unittest

          commit 171cbeb003f59c82af90713807faafea281829b1
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T03:55:47Z

          make sure single char interpreter name can be parsed

          commit 9ae553b55797c3545b04858928ec2715cbe81d43
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T03:56:17Z

          Format output and add usage command

          commit b889443008aa91f786a6b6c1dec974dccd51595a
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T03:59:31Z

          add usage template

          commit d979c6af9aed1383844cd306f4f6fd5490ba1dcb
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T05:40:38Z

          Add unittest

          commit 4842b0ae2431d77d0980af628a91dd3f71254b22
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T05:59:12Z

          Add usage in doc

          commit c20cb9daf82699d33818ed98c7e869f9e0fbfeb4
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T07:14:42Z

          Add PythonDockerInterpreter

          commit d0bac40e388388271cbc4b84444ed7338f18666a
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T16:07:47Z

          Add unittest

          commit 14dedec398a86e4111525b622fcea5a0205a51bd
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T16:26:18Z

          add docs


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/1654 ZEPPELIN-1683 Run python process in docker container What is this PR for? Inspired by ZEPPELIN-1671 conda interpreter. Docker can provides kind of virtual environment for python like conda does. This PR implements %python.docker interpreter that helps run python process in docker container. This PR implements feature on top of https://github.com/apache/zeppelin/pull/1645 What type of PR is it? Feature Todos [x] - basic feature [x] - unittest [x] - documentation What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1683 How should this be tested? see screenshot Screenshots (if appropriate) ! [pydocker] ( https://cloud.githubusercontent.com/assets/1540981/20421814/38a93a9c-ad1b-11e6-8a64-2d0230ff4d8a.gif ) Questions: Does the licenses files need update? no Is there breaking changes for older versions? no Does this needs documentation? yes You can merge this pull request into a Git repository by running: $ git pull https://github.com/Leemoonsoo/zeppelin pydocker Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1654.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1654 commit 394cf8c00641d251fe023d63cda31a4f872cf3dd Author: Lee moon soo <moon@apache.org> Date: 2016-11-16T04:18:08Z Conda interpreter implementation commit 1223796931b38af1c2351fdda91ad31b4dcf814c Author: Lee moon soo <moon@apache.org> Date: 2016-11-16T04:28:21Z Remove unnecessary log commit 6b9525f303154c5eda65f12256b9bfc13d7c4c58 Author: Lee moon soo <moon@apache.org> Date: 2016-11-17T18:40:13Z Fix unittest commit 171cbeb003f59c82af90713807faafea281829b1 Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T03:55:47Z make sure single char interpreter name can be parsed commit 9ae553b55797c3545b04858928ec2715cbe81d43 Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T03:56:17Z Format output and add usage command commit b889443008aa91f786a6b6c1dec974dccd51595a Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T03:59:31Z add usage template commit d979c6af9aed1383844cd306f4f6fd5490ba1dcb Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T05:40:38Z Add unittest commit 4842b0ae2431d77d0980af628a91dd3f71254b22 Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T05:59:12Z Add usage in doc commit c20cb9daf82699d33818ed98c7e869f9e0fbfeb4 Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T07:14:42Z Add PythonDockerInterpreter commit d0bac40e388388271cbc4b84444ed7338f18666a Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T16:07:47Z Add unittest commit 14dedec398a86e4111525b622fcea5a0205a51bd Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T16:26:18Z add docs
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo closed the pull request at:

          https://github.com/apache/zeppelin/pull/1654

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/1654
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Leemoonsoo reopened a pull request:

          https://github.com/apache/zeppelin/pull/1654

          ZEPPELIN-1683 Run python process in docker container

              1. What is this PR for?
                Inspired by ZEPPELIN-1671 conda interpreter.
                Docker can provides kind of virtual environment for python like conda does.
                This PR implements %python.docker interpreter that helps run python process in docker container.
                This PR implements feature on top of https://github.com/apache/zeppelin/pull/1645
              1. What type of PR is it?
                Feature
              1. Todos
          • [x] - basic feature
          • [x] - unittest
          • [x] - documentation
              1. What is the Jira issue?
                https://issues.apache.org/jira/browse/ZEPPELIN-1683
              1. How should this be tested?
                see screenshot
              1. Screenshots (if appropriate)
                ![pydocker](https://cloud.githubusercontent.com/assets/1540981/20421814/38a93a9c-ad1b-11e6-8a64-2d0230ff4d8a.gif)
              1. Questions:
          • Does the licenses files need update? no
          • Is there breaking changes for older versions? no
          • Does this needs documentation? yes

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Leemoonsoo/zeppelin pydocker

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1654.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1654


          commit 394cf8c00641d251fe023d63cda31a4f872cf3dd
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-16T04:18:08Z

          Conda interpreter implementation

          commit 1223796931b38af1c2351fdda91ad31b4dcf814c
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-16T04:28:21Z

          Remove unnecessary log

          commit 6b9525f303154c5eda65f12256b9bfc13d7c4c58
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-17T18:40:13Z

          Fix unittest

          commit 171cbeb003f59c82af90713807faafea281829b1
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T03:55:47Z

          make sure single char interpreter name can be parsed

          commit 9ae553b55797c3545b04858928ec2715cbe81d43
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T03:56:17Z

          Format output and add usage command

          commit b889443008aa91f786a6b6c1dec974dccd51595a
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T03:59:31Z

          add usage template

          commit d979c6af9aed1383844cd306f4f6fd5490ba1dcb
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T05:40:38Z

          Add unittest

          commit 4842b0ae2431d77d0980af628a91dd3f71254b22
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T05:59:12Z

          Add usage in doc

          commit c20cb9daf82699d33818ed98c7e869f9e0fbfeb4
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T07:14:42Z

          Add PythonDockerInterpreter

          commit d0bac40e388388271cbc4b84444ed7338f18666a
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T16:07:47Z

          Add unittest

          commit 14dedec398a86e4111525b622fcea5a0205a51bd
          Author: Lee moon soo <moon@apache.org>
          Date: 2016-11-18T16:26:18Z

          add docs


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/1654 ZEPPELIN-1683 Run python process in docker container What is this PR for? Inspired by ZEPPELIN-1671 conda interpreter. Docker can provides kind of virtual environment for python like conda does. This PR implements %python.docker interpreter that helps run python process in docker container. This PR implements feature on top of https://github.com/apache/zeppelin/pull/1645 What type of PR is it? Feature Todos [x] - basic feature [x] - unittest [x] - documentation What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1683 How should this be tested? see screenshot Screenshots (if appropriate) ! [pydocker] ( https://cloud.githubusercontent.com/assets/1540981/20421814/38a93a9c-ad1b-11e6-8a64-2d0230ff4d8a.gif ) Questions: Does the licenses files need update? no Is there breaking changes for older versions? no Does this needs documentation? yes You can merge this pull request into a Git repository by running: $ git pull https://github.com/Leemoonsoo/zeppelin pydocker Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1654.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1654 commit 394cf8c00641d251fe023d63cda31a4f872cf3dd Author: Lee moon soo <moon@apache.org> Date: 2016-11-16T04:18:08Z Conda interpreter implementation commit 1223796931b38af1c2351fdda91ad31b4dcf814c Author: Lee moon soo <moon@apache.org> Date: 2016-11-16T04:28:21Z Remove unnecessary log commit 6b9525f303154c5eda65f12256b9bfc13d7c4c58 Author: Lee moon soo <moon@apache.org> Date: 2016-11-17T18:40:13Z Fix unittest commit 171cbeb003f59c82af90713807faafea281829b1 Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T03:55:47Z make sure single char interpreter name can be parsed commit 9ae553b55797c3545b04858928ec2715cbe81d43 Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T03:56:17Z Format output and add usage command commit b889443008aa91f786a6b6c1dec974dccd51595a Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T03:59:31Z add usage template commit d979c6af9aed1383844cd306f4f6fd5490ba1dcb Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T05:40:38Z Add unittest commit 4842b0ae2431d77d0980af628a91dd3f71254b22 Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T05:59:12Z Add usage in doc commit c20cb9daf82699d33818ed98c7e869f9e0fbfeb4 Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T07:14:42Z Add PythonDockerInterpreter commit d0bac40e388388271cbc4b84444ed7338f18666a Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T16:07:47Z Add unittest commit 14dedec398a86e4111525b622fcea5a0205a51bd Author: Lee moon soo <moon@apache.org> Date: 2016-11-18T16:26:18Z add docs
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1654

          CI Green now. please review this.
          Once it's merged, i'd like to add some tutorials that leverage this feature.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1654 CI Green now. please review this. Once it's merged, i'd like to add some tutorials that leverage this feature.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user felixcheung commented on the issue:

          https://github.com/apache/zeppelin/pull/1654

          LGTM. Looking forward to see more interesting use cases for this!

          Show
          githubbot ASF GitHub Bot added a comment - Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1654 LGTM. Looking forward to see more interesting use cases for this!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1654

          Thanks @felixcheung for the review. Merge to mater if there is no more comment!

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1654 Thanks @felixcheung for the review. Merge to mater if there is no more comment!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/1654

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1654

            People

            • Assignee:
              moon Lee moon soo
              Reporter:
              moon Lee moon soo
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development