Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-1643

Ability to access Spark Web UI from interpreters page

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: None
    • Labels:
      None

      Description

      Ability to access Spark Web UI from interpreters page

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user karup1990 opened a pull request:

          https://github.com/apache/zeppelin/pull/1613

          ZEPPELIN-1643:Make spark web UI accesible from interpreters page

              1. What is this PR for?
                Make spark web UI accesible from interpreters page
              1. What type of PR is it?
                Improvement
              1. Todos
                NA
              1. What is the Jira issue?
                ZEPPELIN-1643
              1. How should this be tested?
                Start sparkcontext.
                Goto interpreters page. Corresponding to the spark interpreter used in notebook, there will be spark ui button.
                Clicking the button should open a new tab with the application's spark web UI.
              1. Screenshots (if appropriate)
                ![zscpr58qdi](https://cloud.githubusercontent.com/assets/5082742/20110797/c6852202-a60b-11e6-8264-93437a58f752.gif)
              1. Questions:
          • Does the licenses files need update? NA
          • Is there breaking changes for older versions? No
          • Does this needs documentation? No

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/karup1990/incubator-zeppelin ZEPPELIN-1643

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1613.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1613


          commit 3b47fe6dd2dc5125efd86e58a91bc66772d6c011
          Author: karuppayya <karuppayya1990@gmail.com>
          Date: 2016-11-08T17:50:09Z

          Change to make spark web UI accesible from interpreters page


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user karup1990 opened a pull request: https://github.com/apache/zeppelin/pull/1613 ZEPPELIN-1643 :Make spark web UI accesible from interpreters page What is this PR for? Make spark web UI accesible from interpreters page What type of PR is it? Improvement Todos NA What is the Jira issue? ZEPPELIN-1643 How should this be tested? Start sparkcontext. Goto interpreters page. Corresponding to the spark interpreter used in notebook, there will be spark ui button. Clicking the button should open a new tab with the application's spark web UI. Screenshots (if appropriate) ! [zscpr58qdi] ( https://cloud.githubusercontent.com/assets/5082742/20110797/c6852202-a60b-11e6-8264-93437a58f752.gif ) Questions: Does the licenses files need update? NA Is there breaking changes for older versions? No Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/karup1990/incubator-zeppelin ZEPPELIN-1643 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1613.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1613 commit 3b47fe6dd2dc5125efd86e58a91bc66772d6c011 Author: karuppayya <karuppayya1990@gmail.com> Date: 2016-11-08T17:50:09Z Change to make spark web UI accesible from interpreters page
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user karup1990 commented on the issue:

          https://github.com/apache/zeppelin/pull/1613

          @Leemoonsoo Thanks for the suggestions.
          I have refactored the code now.

          Show
          githubbot ASF GitHub Bot added a comment - Github user karup1990 commented on the issue: https://github.com/apache/zeppelin/pull/1613 @Leemoonsoo Thanks for the suggestions. I have refactored the code now.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user karup1990 commented on the issue:

          https://github.com/apache/zeppelin/pull/1613

          Ready for review

          Show
          githubbot ASF GitHub Bot added a comment - Github user karup1990 commented on the issue: https://github.com/apache/zeppelin/pull/1613 Ready for review
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user karup1990 closed the pull request at:

          https://github.com/apache/zeppelin/pull/1613

          Show
          githubbot ASF GitHub Bot added a comment - Github user karup1990 closed the pull request at: https://github.com/apache/zeppelin/pull/1613
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user karup1990 reopened a pull request:

          https://github.com/apache/zeppelin/pull/1613

          ZEPPELIN-1643:Make spark web UI accesible from interpreters page

              1. What is this PR for?
                Make spark web UI accesible from interpreters page
              1. What type of PR is it?
                Improvement
              1. Todos
                NA
              1. What is the Jira issue?
                ZEPPELIN-1643
              1. How should this be tested?
                Start sparkcontext.
                Goto interpreters page. Corresponding to the spark interpreter used in notebook, there will be spark ui button.
                Clicking the button should open a new tab with the application's spark web UI.
              1. Screenshots (if appropriate)
                ![zscpr58qdi](https://cloud.githubusercontent.com/assets/5082742/20110797/c6852202-a60b-11e6-8264-93437a58f752.gif)
              1. Questions:
          • Does the licenses files need update? NA
          • Is there breaking changes for older versions? No
          • Does this needs documentation? No

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/karup1990/incubator-zeppelin ZEPPELIN-1643

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1613.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1613


          commit 3b47fe6dd2dc5125efd86e58a91bc66772d6c011
          Author: karuppayya <karuppayya1990@gmail.com>
          Date: 2016-11-08T17:50:09Z

          Change to make spark web UI accesible from interpreters page

          commit a0ff3dbfdebc7a303d25058c6eee50e360c53c87
          Author: karuppayya <karuppayya1990@gmail.com>
          Date: 2016-11-08T18:08:16Z

          Remove comments

          commit 2d065c818133539d6a3634c82183dcd1b7042622
          Author: karuppayya <karuppayya1990@gmail.com>
          Date: 2016-11-09T16:28:58Z

          Address feedback

          commit 8f08385862ad6e45c37122ca4f25499e6e8635a5
          Author: karuppayya <karuppayya1990@gmail.com>
          Date: 2016-11-09T17:23:09Z

          Fix test failure

          commit 538225ce11d5c1dd5139182a8640b6f36937352f
          Author: Karup <karuppayya@outlook.com>
          Date: 2016-11-12T17:25:54Z

          Fix typo


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user karup1990 reopened a pull request: https://github.com/apache/zeppelin/pull/1613 ZEPPELIN-1643 :Make spark web UI accesible from interpreters page What is this PR for? Make spark web UI accesible from interpreters page What type of PR is it? Improvement Todos NA What is the Jira issue? ZEPPELIN-1643 How should this be tested? Start sparkcontext. Goto interpreters page. Corresponding to the spark interpreter used in notebook, there will be spark ui button. Clicking the button should open a new tab with the application's spark web UI. Screenshots (if appropriate) ! [zscpr58qdi] ( https://cloud.githubusercontent.com/assets/5082742/20110797/c6852202-a60b-11e6-8264-93437a58f752.gif ) Questions: Does the licenses files need update? NA Is there breaking changes for older versions? No Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/karup1990/incubator-zeppelin ZEPPELIN-1643 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1613.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1613 commit 3b47fe6dd2dc5125efd86e58a91bc66772d6c011 Author: karuppayya <karuppayya1990@gmail.com> Date: 2016-11-08T17:50:09Z Change to make spark web UI accesible from interpreters page commit a0ff3dbfdebc7a303d25058c6eee50e360c53c87 Author: karuppayya <karuppayya1990@gmail.com> Date: 2016-11-08T18:08:16Z Remove comments commit 2d065c818133539d6a3634c82183dcd1b7042622 Author: karuppayya <karuppayya1990@gmail.com> Date: 2016-11-09T16:28:58Z Address feedback commit 8f08385862ad6e45c37122ca4f25499e6e8635a5 Author: karuppayya <karuppayya1990@gmail.com> Date: 2016-11-09T17:23:09Z Fix test failure commit 538225ce11d5c1dd5139182a8640b6f36937352f Author: Karup <karuppayya@outlook.com> Date: 2016-11-12T17:25:54Z Fix typo
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user karup1990 commented on the issue:

          https://github.com/apache/zeppelin/pull/1613

          Failure seems unrelated.
          `03:55:19,906 ERROR org.apache.zeppelin.AbstractZeppelinIT:136 - Exception in ParagraphActionsIT while testEditOnDoubleClick `

          Show
          githubbot ASF GitHub Bot added a comment - Github user karup1990 commented on the issue: https://github.com/apache/zeppelin/pull/1613 Failure seems unrelated. `03:55:19,906 ERROR org.apache.zeppelin.AbstractZeppelinIT:136 - Exception in ParagraphActionsIT while testEditOnDoubleClick `
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1613

          LGTM. Merge if there're no further discussions.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1613 LGTM. Merge if there're no further discussions.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/1613

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1613
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zjffdu commented on the issue:

          https://github.com/apache/zeppelin/pull/1613

          If I read it correctly, this PR assume each interpreter setting has one spark ui url ? But I think this is wrong assumption, as we may have multiple spark applications for single interpreter setting. @karup1990 @Leemoonsoo

          Show
          githubbot ASF GitHub Bot added a comment - Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1613 If I read it correctly, this PR assume each interpreter setting has one spark ui url ? But I think this is wrong assumption, as we may have multiple spark applications for single interpreter setting. @karup1990 @Leemoonsoo
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1613

          @zjffdu Right. Isolated mode can create multiple spark applications.
          @karup1990 @zjffdu how can we handle multiple spark applications?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1613 @zjffdu Right. Isolated mode can create multiple spark applications. @karup1990 @zjffdu how can we handle multiple spark applications?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zjffdu commented on the issue:

          https://github.com/apache/zeppelin/pull/1613

          I think the right place to put spark ui link is in note page instead of interpreter setting page.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1613 I think the right place to put spark ui link is in note page instead of interpreter setting page.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1613

          Make sense. @karup1990 what do you think?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1613 Make sense. @karup1990 what do you think?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user karup1990 commented on the issue:

          https://github.com/apache/zeppelin/pull/1613

          @zjffdu @Leemoonsoo Thanks for letting me know.
          I will make the changes to handle isolated scope as well and create a PR

          Show
          githubbot ASF GitHub Bot added a comment - Github user karup1990 commented on the issue: https://github.com/apache/zeppelin/pull/1613 @zjffdu @Leemoonsoo Thanks for letting me know. I will make the changes to handle isolated scope as well and create a PR
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user karup1990 commented on the issue:

          https://github.com/apache/zeppelin/pull/1613

          I did a code reading to see how to fix this.. Looks like I will need to handle it per user as well.
          To complete this PR, I can quickly make the changes to show the link in interpreter page, only for per note scoped and global mode.
          Else , I will try to fix all modes(user, note, global) and then create a PR.
          @zjffdu @Leemoonsoo let me know your thoughts.

          Show
          githubbot ASF GitHub Bot added a comment - Github user karup1990 commented on the issue: https://github.com/apache/zeppelin/pull/1613 I did a code reading to see how to fix this.. Looks like I will need to handle it per user as well. To complete this PR, I can quickly make the changes to show the link in interpreter page, only for per note scoped and global mode. Else , I will try to fix all modes(user, note, global) and then create a PR. @zjffdu @Leemoonsoo let me know your thoughts.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user karup1990 commented on the issue:

          https://github.com/apache/zeppelin/pull/1613

          @zjffdu @Leemoonsoo I have handled the cases in https://github.com/apache/zeppelin/pull/1678

          Show
          githubbot ASF GitHub Bot added a comment - Github user karup1990 commented on the issue: https://github.com/apache/zeppelin/pull/1613 @zjffdu @Leemoonsoo I have handled the cases in https://github.com/apache/zeppelin/pull/1678

            People

            • Assignee:
              karup1990 Karuppayya
              Reporter:
              karup1990 Karuppayya
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development