Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: front-end, zeppelin-server
    • Labels:
      None

      Description

      Enable renaming note from the main page.

      Users can rename a note, but not from the main page. This will improve UX.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tae-jun opened a pull request:

          https://github.com/apache/zeppelin/pull/1609

          ZEPPELIN-1628 Enable renaming note from the main page

              1. What is this PR for?
                Now users can rename a note from the main page! This new feature will improve UX.

          I divided ZEPPELIN-1598(https://issues.apache.org/jira/browse/ZEPPELIN-1598) into sub-tasks since renaming folder gonna be huge. I will open PR for ZEPPELIN-1629(https://issues.apache.org/jira/browse/ZEPPELIN-1629) after merging this PR.

          By the way, I have a question! Does a `writer` can rename a note? Currently, only an owner can rename a note.

              1. What type of PR is it?
                [Feature]
              1. What is the Jira issue?
                https://issues.apache.org/jira/browse/ZEPPELIN-1628
              1. Screenshots (if appropriate)
                ![rename_note](https://cloud.githubusercontent.com/assets/8201019/20057051/a16b221c-a52c-11e6-900e-f88031ff1246.gif)
              1. Questions:
          • Does the licenses files need update? No
          • Is there breaking changes for older versions? No
          • Does this needs documentation? No

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1628

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1609.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1609



          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/1609 ZEPPELIN-1628 Enable renaming note from the main page What is this PR for? Now users can rename a note from the main page! This new feature will improve UX. I divided ZEPPELIN-1598 ( https://issues.apache.org/jira/browse/ZEPPELIN-1598 ) into sub-tasks since renaming folder gonna be huge. I will open PR for ZEPPELIN-1629 ( https://issues.apache.org/jira/browse/ZEPPELIN-1629 ) after merging this PR. By the way, I have a question! Does a `writer` can rename a note? Currently, only an owner can rename a note. What type of PR is it? [Feature] What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1628 Screenshots (if appropriate) ! [rename_note] ( https://cloud.githubusercontent.com/assets/8201019/20057051/a16b221c-a52c-11e6-900e-f88031ff1246.gif ) Questions: Does the licenses files need update? No Is there breaking changes for older versions? No Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1628 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1609.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1609
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1609

          @tae-jun Awesome!
          I tested this patch but seems it needs to prevent blank title when we rename the note. Please see the below gif img.
          ![edit_notename](https://cloud.githubusercontent.com/assets/10060731/20060790/31c6dc9e-a540-11e6-8541-0b6db19252eb.gif)

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1609 @tae-jun Awesome! I tested this patch but seems it needs to prevent blank title when we rename the note. Please see the below gif img. ! [edit_notename] ( https://cloud.githubusercontent.com/assets/10060731/20060790/31c6dc9e-a540-11e6-8541-0b6db19252eb.gif )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tae-jun commented on the issue:

          https://github.com/apache/zeppelin/pull/1609

          @AhyoungRyu Thanks for the quick review! You are right! I will fix it. Please wait 😄

          Show
          githubbot ASF GitHub Bot added a comment - Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1609 @AhyoungRyu Thanks for the quick review! You are right! I will fix it. Please wait 😄
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tae-jun commented on the issue:

          https://github.com/apache/zeppelin/pull/1609

          @AhyoungRyu I fixed it! It took some time to improve UX 😄

          Now when an input text is not valid, users can't click the button and the modal shows error message

          ![rename_note_validation](https://cloud.githubusercontent.com/assets/8201019/20105201/154ae680-a614-11e6-94d1-7464a8bce7f9.gif)

          Show
          githubbot ASF GitHub Bot added a comment - Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1609 @AhyoungRyu I fixed it! It took some time to improve UX 😄 Now when an input text is not valid, users can't click the button and the modal shows error message ! [rename_note_validation] ( https://cloud.githubusercontent.com/assets/8201019/20105201/154ae680-a614-11e6-94d1-7464a8bce7f9.gif )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tae-jun commented on the issue:

          https://github.com/apache/zeppelin/pull/1609

          CI is green!

          Show
          githubbot ASF GitHub Bot added a comment - Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1609 CI is green!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1609

          @tae-jun Thanks for your prompt response. The latest change looks good to me 👍

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1609 @tae-jun Thanks for your prompt response. The latest change looks good to me 👍
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tae-jun commented on the issue:

          https://github.com/apache/zeppelin/pull/1609

          @AhyoungRyu Thanks for the review!

          Show
          githubbot ASF GitHub Bot added a comment - Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1609 @AhyoungRyu Thanks for the review!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1609

          Thanks @tae-jun for useful feature contribution.
          LGTM and merge to master if there're no further comments.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1609 Thanks @tae-jun for useful feature contribution. LGTM and merge to master if there're no further comments.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/1609

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1609

            People

            • Assignee:
              JunKim Tae Jun Kim
              Reporter:
              JunKim Tae Jun Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development