Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-1614

Remove markdown4j dependency by adding plugins to pegdown

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.6.2
    • Fix Version/s: 0.7.0
    • Component/s: Interpreters
    • Labels:
      None

      Description

      Current implementation of the markdown interpreter uses 2 parsers. markdown4j and pegdown. But markdown4j exists just for Websequence and YUML plugins.

      By adding Websequence and YUML plugins

      • Removing markdown4j dependency which is unmanaged library currently.
      • Addtionally, we can remove markdown.parser.type options in markdown interpreter
      • Fixing some bugs in Websequence and YUML plugins
      • Uses pegdown parser syntax so that enable others to add more plugins.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user 1ambda opened a pull request:

          https://github.com/apache/zeppelin/pull/1594

          ZEPPELIN-1614 Remove markdown4j dep

              1. What is this PR for?

          Remove unmanaged, old library markdown4j dep which exists just for Websequence and YUML plugins.
          (related to https://github.com/apache/zeppelin/pull/1384)

          By adding Websequence and YUML plugins to pegdown

          • Removing markdown4j dependency which is unmanaged library currently.
          • Addtionally, we can remove `markdown.parser.type` options in *markdown interpreter*
          • Fixing some bugs in Websequence and YUML plugins
          • Enable others to add more plugins using pegdown sytnax.
              1. What type of PR is it?

          Improvement

              1. Todos
          • [ ] - Task
              1. What is the Jira issue?
              1. How should this be tested?
                Outline the steps to test the PR here.
              1. Screenshots (if appropriate)
              1. Questions:
          • Does the licenses files need update? - YES
          • Is there breaking changes for older versions? - NO
          • Does this needs documentation? - YES

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/1ambda/zeppelin feat/remove-markdown4j-dep

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1594.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1594


          commit d95c0b1fe100045a90c95ad61ca2b55ba0eb24ee
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-03T16:36:15Z

          feat: Support webseq markdown plugin

          commit 7ca1b1b196ce24bf759d7fc66bae3447d8397019
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-03T16:36:30Z

          feat: Yuml markdown plugin

          commit 314d2a86f437e80a6d0f0a2ecfb12c3c84ed7ed5
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-03T16:58:31Z

          fix: Add missing docs

          commit e9fb0df57b7b5b3737b467c7c0d9ab3de852f5e8
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T02:34:51Z

          fix: Cleanup unused Markdown4j Parser

          commit a36c86c1828ae33d967a9847d604dd539a005ff7
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T02:35:20Z

          docs: Remove markdown.parser.type option

          commit 226c1e67c8b44e22c6c68679e80b0d497d5343d4
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T02:50:23Z

          chore: Remove markdown4j dep and update license

          commit cd45d85a1e3260569b4e94e26a9b494de01f6821
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T03:51:26Z

          fix: Set {} to avoid 503

          commit 580233fb715fdf141adb3ea0920c143327720ef7
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T03:56:42Z

          fix: Parse style param optionally in webseq


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1594 ZEPPELIN-1614 Remove markdown4j dep What is this PR for? Remove unmanaged, old library markdown4j dep which exists just for Websequence and YUML plugins. (related to https://github.com/apache/zeppelin/pull/1384 ) By adding Websequence and YUML plugins to pegdown Removing markdown4j dependency which is unmanaged library currently. Addtionally, we can remove `markdown.parser.type` options in * markdown interpreter * Fixing some bugs in Websequence and YUML plugins Enable others to add more plugins using pegdown sytnax. What type of PR is it? Improvement Todos [ ] - Task What is the Jira issue? Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. ZEPPELIN-533 How should this be tested? Outline the steps to test the PR here. Screenshots (if appropriate) Questions: Does the licenses files need update? - YES Is there breaking changes for older versions? - NO Does this needs documentation? - YES You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin feat/remove-markdown4j-dep Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1594.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1594 commit d95c0b1fe100045a90c95ad61ca2b55ba0eb24ee Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-03T16:36:15Z feat: Support webseq markdown plugin commit 7ca1b1b196ce24bf759d7fc66bae3447d8397019 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-03T16:36:30Z feat: Yuml markdown plugin commit 314d2a86f437e80a6d0f0a2ecfb12c3c84ed7ed5 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-03T16:58:31Z fix: Add missing docs commit e9fb0df57b7b5b3737b467c7c0d9ab3de852f5e8 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T02:34:51Z fix: Cleanup unused Markdown4j Parser commit a36c86c1828ae33d967a9847d604dd539a005ff7 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T02:35:20Z docs: Remove markdown.parser.type option commit 226c1e67c8b44e22c6c68679e80b0d497d5343d4 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T02:50:23Z chore: Remove markdown4j dep and update license commit cd45d85a1e3260569b4e94e26a9b494de01f6821 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T03:51:26Z fix: Set {} to avoid 503 commit 580233fb715fdf141adb3ea0920c143327720ef7 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T03:56:42Z fix: Parse style param optionally in webseq
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bzz commented on the issue:

          https://github.com/apache/zeppelin/pull/1594

          Websequence are awesome, thank you @1ambda for contributing this simplification of MD interpreter.

          Looks good to me, modulo few minor issues, commented above.

          As soon as CI is green and issues addressed - will be happy to merge to master, in case there is no further discussion.

          Show
          githubbot ASF GitHub Bot added a comment - Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1594 Websequence are awesome, thank you @1ambda for contributing this simplification of MD interpreter. Looks good to me, modulo few minor issues, commented above. As soon as CI is green and issues addressed - will be happy to merge to master, in case there is no further discussion.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user felixcheung commented on the issue:

          https://github.com/apache/zeppelin/pull/1594

          This is awesome, thanks!
          +1 on @bzz 's comments

          Show
          githubbot ASF GitHub Bot added a comment - Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1594 This is awesome, thanks! +1 on @bzz 's comments
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1594

          Thanks for the review @bzz, @felixcheung! I'v just fixed

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1594 Thanks for the review @bzz, @felixcheung! I'v just fixed
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1594

          Thanks @1ambda for the contribution.
          I have compared output from markdown4j and pegdown and found some differences.

          font difference
          ![image](https://cloud.githubusercontent.com/assets/1540981/20041478/77b2d5be-a41e-11e6-8c62-e69308dcc87f.png)

          emphasis inside of `()`
          ![image](https://cloud.githubusercontent.com/assets/1540981/20041487/9730d67a-a41e-11e6-93eb-e103e767c08c.png)

          There could be more unknown differences. That means, existing notebook might render differently with pegdown and that could be unexpected result in some cases.

          So how about keep markdown4j and make pegdown default parser? That at least give user option to configure markdown interpreter with old markdown4j parser when they don't want to make change on existing notebook.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1594 Thanks @1ambda for the contribution. I have compared output from markdown4j and pegdown and found some differences. font difference ! [image] ( https://cloud.githubusercontent.com/assets/1540981/20041478/77b2d5be-a41e-11e6-8c62-e69308dcc87f.png ) emphasis inside of `()` ! [image] ( https://cloud.githubusercontent.com/assets/1540981/20041487/9730d67a-a41e-11e6-93eb-e103e767c08c.png ) There could be more unknown differences. That means, existing notebook might render differently with pegdown and that could be unexpected result in some cases. So how about keep markdown4j and make pegdown default parser? That at least give user option to configure markdown interpreter with old markdown4j parser when they don't want to make change on existing notebook.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1594

          And i think it'll be better mention in `docs/install/upgrade.html#upgrading-from-zeppelin-06-to-07` about default markdown parser change and result slightly different output rendering of markdown paragraphs. And link to markdown parser configuration section in the doc would help as well.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1594 And i think it'll be better mention in `docs/install/upgrade.html#upgrading-from-zeppelin-06-to-07` about default markdown parser change and result slightly different output rendering of markdown paragraphs. And link to markdown parser configuration section in the doc would help as well.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1594

          @Leemoonsoo Thanks for review 👍

          It would be better to

          1. Use pegdown as default
          2. Add docs for it
          3. Revert markdown4j

          Regarding to rendered output you provided, I think it is a bug of pegdown.
          But even if it is resolved, there might be differences we can miss.
          So keep markdown4j. (I overlooked backward compatibility issue)

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1594 @Leemoonsoo Thanks for review 👍 It would be better to 1. Use pegdown as default 2. Add docs for it 3. Revert markdown4j Regarding to rendered output you provided, I think it is a bug of pegdown. But even if it is resolved, there might be differences we can miss. So keep markdown4j. (I overlooked backward compatibility issue)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bzz commented on the issue:

          https://github.com/apache/zeppelin/pull/1594

          What should be the next steps here @1ambda?

          Show
          githubbot ASF GitHub Bot added a comment - Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1594 What should be the next steps here @1ambda?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1594

          @bzz Resolving CI failure will be next step. But i think it is not problem of markdown processor. All tests are failed in scalding interpreter test

          I will rebase and retrigger CI again.

          ```
          // PROFILE="-Pspark-2.0 -Phadoop-2.3 -Ppyspark -Psparkr -Pscalding -Pexamples -Pscala-2.11"
          // https://s3.amazonaws.com/archive.travis-ci.org/jobs/173808635/log.txt
          // https://s3.amazonaws.com/archive.travis-ci.org/jobs/173808636/log.txt
          // https://s3.amazonaws.com/archive.travis-ci.org/jobs/173808637/log.txt

          [INFO] Reactor Summary:
          [INFO]
          [INFO] Zeppelin ........................................... SUCCESS [ 12.258 s]
          [INFO] Zeppelin: Interpreter .............................. SUCCESS [ 17.129 s]
          [INFO] Zeppelin: Zengine .................................. SUCCESS [ 11.340 s]
          [INFO] Zeppelin: Display system apis ...................... SUCCESS [ 19.516 s]
          [INFO] Zeppelin: Spark dependencies ....................... SUCCESS [ 44.808 s]
          [INFO] Zeppelin: Spark .................................... SUCCESS [ 23.799 s]
          [INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [ 0.594 s]
          [INFO] Zeppelin: Angular interpreter ...................... SUCCESS [ 0.270 s]
          [INFO] Zeppelin: Shell interpreter ........................ SUCCESS [ 0.335 s]
          [INFO] Zeppelin: Livy interpreter ......................... SUCCESS [02:34 min]
          [INFO] Zeppelin: HBase interpreter ........................ SUCCESS [ 10.105 s]
          [INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [ 5.611 s]
          [INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [ 0.615 s]
          [INFO] Zeppelin: JDBC interpreter ......................... SUCCESS [ 1.026 s]
          [INFO] Zeppelin: File System Interpreters ................. SUCCESS [ 1.140 s]
          [INFO] Zeppelin: Flink .................................... SUCCESS [ 8.944 s]
          [INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [ 1.168 s]
          [INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [ 0.407 s]
          [INFO] Zeppelin: Python interpreter ....................... SUCCESS [ 0.397 s]
          [INFO] Zeppelin: Lens interpreter ......................... SUCCESS [ 4.180 s]
          [INFO] Zeppelin: Apache Cassandra interpreter ............. SUCCESS [01:04 min]
          [INFO] Zeppelin: Elasticsearch interpreter ................ SUCCESS [ 8.569 s]
          [INFO] Zeppelin: BigQuery interpreter ..................... SUCCESS [ 4.676 s]
          [INFO] Zeppelin: Alluxio interpreter ...................... SUCCESS [ 3.305 s]
          [INFO] Zeppelin: web Application .......................... SUCCESS [01:37 min]
          [INFO] Zeppelin: Server ................................... SUCCESS [ 22.082 s]
          [INFO] Zeppelin: Packaging distribution ................... SUCCESS [01:04 min]
          [INFO] Zeppelin: Scalding interpreter ..................... FAILURE [ 1.212 s]
          [INFO] Zeppelin: Examples ................................. SKIPPED
          [INFO] Zeppelin: Example application - Clock .............. SKIPPED
          [INFO] Zeppelin: Example application - Horizontal Bar chart SKIPPED
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD FAILURE
          [INFO] ------------------------------------------------------------------------
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1594 @bzz Resolving CI failure will be next step. But i think it is not problem of markdown processor. All tests are failed in scalding interpreter test I will rebase and retrigger CI again. ``` // PROFILE="-Pspark-2.0 -Phadoop-2.3 -Ppyspark -Psparkr -Pscalding -Pexamples -Pscala-2.11" // https://s3.amazonaws.com/archive.travis-ci.org/jobs/173808635/log.txt // https://s3.amazonaws.com/archive.travis-ci.org/jobs/173808636/log.txt // https://s3.amazonaws.com/archive.travis-ci.org/jobs/173808637/log.txt [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ........................................... SUCCESS [ 12.258 s] [INFO] Zeppelin: Interpreter .............................. SUCCESS [ 17.129 s] [INFO] Zeppelin: Zengine .................................. SUCCESS [ 11.340 s] [INFO] Zeppelin: Display system apis ...................... SUCCESS [ 19.516 s] [INFO] Zeppelin: Spark dependencies ....................... SUCCESS [ 44.808 s] [INFO] Zeppelin: Spark .................................... SUCCESS [ 23.799 s] [INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [ 0.594 s] [INFO] Zeppelin: Angular interpreter ...................... SUCCESS [ 0.270 s] [INFO] Zeppelin: Shell interpreter ........................ SUCCESS [ 0.335 s] [INFO] Zeppelin: Livy interpreter ......................... SUCCESS [02:34 min] [INFO] Zeppelin: HBase interpreter ........................ SUCCESS [ 10.105 s] [INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [ 5.611 s] [INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [ 0.615 s] [INFO] Zeppelin: JDBC interpreter ......................... SUCCESS [ 1.026 s] [INFO] Zeppelin: File System Interpreters ................. SUCCESS [ 1.140 s] [INFO] Zeppelin: Flink .................................... SUCCESS [ 8.944 s] [INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [ 1.168 s] [INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [ 0.407 s] [INFO] Zeppelin: Python interpreter ....................... SUCCESS [ 0.397 s] [INFO] Zeppelin: Lens interpreter ......................... SUCCESS [ 4.180 s] [INFO] Zeppelin: Apache Cassandra interpreter ............. SUCCESS [01:04 min] [INFO] Zeppelin: Elasticsearch interpreter ................ SUCCESS [ 8.569 s] [INFO] Zeppelin: BigQuery interpreter ..................... SUCCESS [ 4.676 s] [INFO] Zeppelin: Alluxio interpreter ...................... SUCCESS [ 3.305 s] [INFO] Zeppelin: web Application .......................... SUCCESS [01:37 min] [INFO] Zeppelin: Server ................................... SUCCESS [ 22.082 s] [INFO] Zeppelin: Packaging distribution ................... SUCCESS [01:04 min] [INFO] Zeppelin: Scalding interpreter ..................... FAILURE [ 1.212 s] [INFO] Zeppelin: Examples ................................. SKIPPED [INFO] Zeppelin: Example application - Clock .............. SKIPPED [INFO] Zeppelin: Example application - Horizontal Bar chart SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1594

          rebased

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1594 rebased
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda closed the pull request at:

          https://github.com/apache/zeppelin/pull/1594

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1594
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user 1ambda reopened a pull request:

          https://github.com/apache/zeppelin/pull/1594

          ZEPPELIN-1614 Remove markdown4j dep

              1. What is this PR for?

          Remove unmanaged, old library markdown4j dep which exists just for Websequence and YUML plugins.
          (related to https://github.com/apache/zeppelin/pull/1384)

          By adding Websequence and YUML plugins to pegdown

          • Removing markdown4j dependency which is unmanaged library currently.
          • Addtionally, we can remove `markdown.parser.type` options in *markdown interpreter*
          • Fixing some bugs in Websequence and YUML plugins
          • Enable others to add more plugins using pegdown sytnax.
              1. What type of PR is it?

          Improvement

              1. Todos

          Nothing

              1. What is the Jira issue?

          [JIRA - ZEPPELIN-1614](https://issues.apache.org/jira/browse/ZEPPELIN-1614)

              1. How should this be tested?

          Some functional tests are included.

              1. Screenshots (if appropriate)
              1. Questions:
          • Does the licenses files need update? - YES
          • Is there breaking changes for older versions? - NO
          • Does this needs documentation? - YES

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/1ambda/zeppelin feat/remove-markdown4j-dep

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1594.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1594


          commit 561fc10a7560519ba6cc991a8b0772aac318be4a
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-03T16:36:15Z

          feat: Support webseq markdown plugin

          commit 1da8826290516d6b75eaab3c45f9cdf398efc793
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-03T16:36:30Z

          feat: Yuml markdown plugin

          commit 294511208817ce27b25fbfafb2dcf8e45afd5a7c
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-03T16:58:31Z

          fix: Add missing docs

          commit b73240d4850f681312c2d25bc15a8d026275f354
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T02:34:51Z

          fix: Cleanup unused Markdown4j Parser

          commit f12ac8782518aa62e4b5f621ec0d758d0c9cc1ba
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T02:35:20Z

          docs: Remove markdown.parser.type option

          commit 8d9f7b9191e04d0503b45e9d26bc4b58b76600c2
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T02:50:23Z

          chore: Remove markdown4j dep and update license

          commit 7c75183f3cb001f5d01d0475b52429be80a40511
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T03:51:26Z

          fix: Set {} to avoid 503

          commit e35a0e5e7028584bc64992d95ef39c95a11ec2d9
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T03:56:42Z

          fix: Parse style param optionally in webseq

          commit 133d4ac9d1e3bc5f52d4c3727585863ad1d70e1c
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T06:14:37Z

          fix: style and misspell in docs

          commit cfcbbee50be0e5f870c4ad8bee6bf8c4b2d1584c
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T06:28:44Z

          fix: Propagate exception in YUML plugin

          commit f2472d170b18f2b5d72199f7945df662f1e2973d
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:22:30Z

          Revert "fix: Propagate exception in YUML plugin"

          This reverts commit f704d3ef6558f1a4c82caebed5e4c6e7ba3bb825.

          commit ec5f8d0a81f29042ef517496ec759cf2af2a16bf
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:22:48Z

          Revert "fix: style and misspell in docs"

          This reverts commit a9c619d842db7e37aea525a77dac36cddd2d4924.

          commit 7b06005b956d7f546dae6a2bc354775609b8e586
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:23:10Z

          Revert "fix: Parse style param optionally in webseq"

          This reverts commit 580233fb715fdf141adb3ea0920c143327720ef7.

          commit 62505293cfdbf22c8ead975e9c2cc00ad327b23c
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:24:14Z

          Revert "fix: Set {} to avoid 503"

          This reverts commit cd45d85a1e3260569b4e94e26a9b494de01f6821.

          commit 07c8839445023524a60ca969e89b833362bfd729
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:24:28Z

          Revert "chore: Remove markdown4j dep and update license"

          This reverts commit 226c1e67c8b44e22c6c68679e80b0d497d5343d4.

          commit 32b14af23c8634e004e794af0131e1bb10530242
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:24:47Z

          Revert "docs: Remove markdown.parser.type option"

          This reverts commit a36c86c1828ae33d967a9847d604dd539a005ff7.

          commit 86a478b43a9d3f56d2ff3e905512483de678a795
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:25:10Z

          Revert "fix: Cleanup unused Markdown4j Parser"

          This reverts commit e9fb0df57b7b5b3737b467c7c0d9ab3de852f5e8.

          commit 3c20de8951e1f9280c07101ca33295164626f495
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:33:32Z

          fix: Wrap exceptions in catch stmt

          commit 7fe093903c41ae5e09dbaeb70f2ffa5f3173414e
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:34:54Z

          fix: Parse style param optionally in webseq

          commit adb9d4842dee74ca636cc3051a418514ef3fa9c1
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:36:47Z

          chore: Cleanup duplicated markdown4j license

          commit 765a45a9bdda13d7d23d96324eda6a1e694fc2e0
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:44:11Z

          Update: interpreter setting and docs

          commit 67734c48399bf562f7bb6cb926f08591bc1524cf
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:47:09Z

          style: Use zeppelin checkstyle.xml

          commit 9e0f51f50440ef3bc481aa18db580285b5923999
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:57:06Z

          docs: Update upgrade.md for '%md'

          commit 035c1f8382307fdee667777dfb3eef1ca703c6c6
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-10T04:34:12Z

          docs: Update markdown.md


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1594 ZEPPELIN-1614 Remove markdown4j dep What is this PR for? Remove unmanaged, old library markdown4j dep which exists just for Websequence and YUML plugins. (related to https://github.com/apache/zeppelin/pull/1384 ) By adding Websequence and YUML plugins to pegdown Removing markdown4j dependency which is unmanaged library currently. Addtionally, we can remove `markdown.parser.type` options in * markdown interpreter * Fixing some bugs in Websequence and YUML plugins Enable others to add more plugins using pegdown sytnax. What type of PR is it? Improvement Todos Nothing What is the Jira issue? [JIRA - ZEPPELIN-1614] ( https://issues.apache.org/jira/browse/ZEPPELIN-1614 ) How should this be tested? Some functional tests are included. Screenshots (if appropriate) Questions: Does the licenses files need update? - YES Is there breaking changes for older versions? - NO Does this needs documentation? - YES You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin feat/remove-markdown4j-dep Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1594.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1594 commit 561fc10a7560519ba6cc991a8b0772aac318be4a Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-03T16:36:15Z feat: Support webseq markdown plugin commit 1da8826290516d6b75eaab3c45f9cdf398efc793 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-03T16:36:30Z feat: Yuml markdown plugin commit 294511208817ce27b25fbfafb2dcf8e45afd5a7c Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-03T16:58:31Z fix: Add missing docs commit b73240d4850f681312c2d25bc15a8d026275f354 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T02:34:51Z fix: Cleanup unused Markdown4j Parser commit f12ac8782518aa62e4b5f621ec0d758d0c9cc1ba Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T02:35:20Z docs: Remove markdown.parser.type option commit 8d9f7b9191e04d0503b45e9d26bc4b58b76600c2 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T02:50:23Z chore: Remove markdown4j dep and update license commit 7c75183f3cb001f5d01d0475b52429be80a40511 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T03:51:26Z fix: Set {} to avoid 503 commit e35a0e5e7028584bc64992d95ef39c95a11ec2d9 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T03:56:42Z fix: Parse style param optionally in webseq commit 133d4ac9d1e3bc5f52d4c3727585863ad1d70e1c Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T06:14:37Z fix: style and misspell in docs commit cfcbbee50be0e5f870c4ad8bee6bf8c4b2d1584c Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T06:28:44Z fix: Propagate exception in YUML plugin commit f2472d170b18f2b5d72199f7945df662f1e2973d Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:22:30Z Revert "fix: Propagate exception in YUML plugin" This reverts commit f704d3ef6558f1a4c82caebed5e4c6e7ba3bb825. commit ec5f8d0a81f29042ef517496ec759cf2af2a16bf Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:22:48Z Revert "fix: style and misspell in docs" This reverts commit a9c619d842db7e37aea525a77dac36cddd2d4924. commit 7b06005b956d7f546dae6a2bc354775609b8e586 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:23:10Z Revert "fix: Parse style param optionally in webseq" This reverts commit 580233fb715fdf141adb3ea0920c143327720ef7. commit 62505293cfdbf22c8ead975e9c2cc00ad327b23c Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:24:14Z Revert "fix: Set {} to avoid 503" This reverts commit cd45d85a1e3260569b4e94e26a9b494de01f6821. commit 07c8839445023524a60ca969e89b833362bfd729 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:24:28Z Revert "chore: Remove markdown4j dep and update license" This reverts commit 226c1e67c8b44e22c6c68679e80b0d497d5343d4. commit 32b14af23c8634e004e794af0131e1bb10530242 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:24:47Z Revert "docs: Remove markdown.parser.type option" This reverts commit a36c86c1828ae33d967a9847d604dd539a005ff7. commit 86a478b43a9d3f56d2ff3e905512483de678a795 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:25:10Z Revert "fix: Cleanup unused Markdown4j Parser" This reverts commit e9fb0df57b7b5b3737b467c7c0d9ab3de852f5e8. commit 3c20de8951e1f9280c07101ca33295164626f495 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:33:32Z fix: Wrap exceptions in catch stmt commit 7fe093903c41ae5e09dbaeb70f2ffa5f3173414e Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:34:54Z fix: Parse style param optionally in webseq commit adb9d4842dee74ca636cc3051a418514ef3fa9c1 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:36:47Z chore: Cleanup duplicated markdown4j license commit 765a45a9bdda13d7d23d96324eda6a1e694fc2e0 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:44:11Z Update: interpreter setting and docs commit 67734c48399bf562f7bb6cb926f08591bc1524cf Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:47:09Z style: Use zeppelin checkstyle.xml commit 9e0f51f50440ef3bc481aa18db580285b5923999 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:57:06Z docs: Update upgrade.md for '%md' commit 035c1f8382307fdee667777dfb3eef1ca703c6c6 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-10T04:34:12Z docs: Update markdown.md
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda closed the pull request at:

          https://github.com/apache/zeppelin/pull/1594

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1594
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user 1ambda reopened a pull request:

          https://github.com/apache/zeppelin/pull/1594

          ZEPPELIN-1614 Remove markdown4j dep

              1. What is this PR for?

          Remove unmanaged, old library markdown4j dep which exists just for Websequence and YUML plugins.
          (related to https://github.com/apache/zeppelin/pull/1384)

          By adding Websequence and YUML plugins to pegdown

          • Removing markdown4j dependency which is unmanaged library currently.
          • Addtionally, we can remove `markdown.parser.type` options in *markdown interpreter*
          • Fixing some bugs in Websequence and YUML plugins
          • Enable others to add more plugins using pegdown sytnax.
              1. What type of PR is it?

          Improvement

              1. Todos

          Nothing

              1. What is the Jira issue?

          [JIRA - ZEPPELIN-1614](https://issues.apache.org/jira/browse/ZEPPELIN-1614)

              1. How should this be tested?

          Some functional tests are included.

              1. Screenshots (if appropriate)
              1. Questions:
          • Does the licenses files need update? - YES
          • Is there breaking changes for older versions? - NO
          • Does this needs documentation? - YES

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/1ambda/zeppelin feat/remove-markdown4j-dep

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1594.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1594


          commit 3247c675acf859b32ba00a3da19daaa327d424c1
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-03T16:36:15Z

          feat: Support webseq markdown plugin

          commit 3e9716da637f60d0abf3927e5b32b995210123cf
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-03T16:36:30Z

          feat: Yuml markdown plugin

          commit 98b28097c4d1d9c3b99e0bf593d4d66b713eeac4
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-03T16:58:31Z

          fix: Add missing docs

          commit cf19f0b94a82a85c1fc333d3235592dcce55f19d
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T02:34:51Z

          fix: Cleanup unused Markdown4j Parser

          commit 81fdfccb1a2b1d1464d31c9e7c86ee91205178c0
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T02:35:20Z

          docs: Remove markdown.parser.type option

          commit c48cc535ccd84e7b93fe84a0d29046e6327cdd33
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T02:50:23Z

          chore: Remove markdown4j dep and update license

          commit b43e14e97ec0cadf421d516f37cc4d503238f93f
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T03:51:26Z

          fix: Set {} to avoid 503

          commit dc4f110e9e605915815a729ae4fee81a88c67895
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T03:56:42Z

          fix: Parse style param optionally in webseq

          commit c656d08c4fc829a565c610bfc8dfa3e51df671e7
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T06:14:37Z

          fix: style and misspell in docs

          commit 1b7787f387f199b9f8110ecc66f23435056d4e26
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-04T06:28:44Z

          fix: Propagate exception in YUML plugin

          commit 73956e07364c4d1447d4d4e15a5e128f7e3fc830
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:22:30Z

          Revert "fix: Propagate exception in YUML plugin"

          This reverts commit f704d3ef6558f1a4c82caebed5e4c6e7ba3bb825.

          commit 8cfb2c81a6a5d360772ff9b52efeae496b66b44e
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:22:48Z

          Revert "fix: style and misspell in docs"

          This reverts commit a9c619d842db7e37aea525a77dac36cddd2d4924.

          commit 4e4893352f1b75c2786797aafd7ca9043f01fe13
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:23:10Z

          Revert "fix: Parse style param optionally in webseq"

          This reverts commit 580233fb715fdf141adb3ea0920c143327720ef7.

          commit a59ebbd531282a51f2336ab4dce82a83f50ef63a
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:24:14Z

          Revert "fix: Set {} to avoid 503"

          This reverts commit cd45d85a1e3260569b4e94e26a9b494de01f6821.

          commit fddc45940415a5600df03e20c66be59c1a80dd6b
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:24:28Z

          Revert "chore: Remove markdown4j dep and update license"

          This reverts commit 226c1e67c8b44e22c6c68679e80b0d497d5343d4.

          commit 33fb800bf3727e55d2cbcf509d7e5399438ea790
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:24:47Z

          Revert "docs: Remove markdown.parser.type option"

          This reverts commit a36c86c1828ae33d967a9847d604dd539a005ff7.

          commit 9268695ea02949bdf1031f98d4d072de5f55db6f
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:25:10Z

          Revert "fix: Cleanup unused Markdown4j Parser"

          This reverts commit e9fb0df57b7b5b3737b467c7c0d9ab3de852f5e8.

          commit 8831ca1fd33e7df9bde53b932de74bcc4d107929
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:33:32Z

          fix: Wrap exceptions in catch stmt

          commit 7c5d41e308bf6988f9a3bb2188517b624e4ea3c4
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:34:54Z

          fix: Parse style param optionally in webseq

          commit de3549d8a9e3e55998f48045f0763c396fbc96ae
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:36:47Z

          chore: Cleanup duplicated markdown4j license

          commit 13e0dc42a703dcc90500894c2ca4fcb4c1807580
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:44:11Z

          Update: interpreter setting and docs

          commit a1e779d648aadd73416154195755dcae13c028bb
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:47:09Z

          style: Use zeppelin checkstyle.xml

          commit 5c622362425455de14e88ab662cbbd42567d898c
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-07T05:57:06Z

          docs: Update upgrade.md for '%md'

          commit c57fdcb8214068af9b69e3417c230807e878b01c
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-10T04:34:12Z

          docs: Update markdown.md

          commit 5af160743ecef96e4a6fd8dfbfe6c187f90d4fe9
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-11-10T09:03:27Z

          fix: Failed tests in InterpreterRestApiTest


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1594 ZEPPELIN-1614 Remove markdown4j dep What is this PR for? Remove unmanaged, old library markdown4j dep which exists just for Websequence and YUML plugins. (related to https://github.com/apache/zeppelin/pull/1384 ) By adding Websequence and YUML plugins to pegdown Removing markdown4j dependency which is unmanaged library currently. Addtionally, we can remove `markdown.parser.type` options in * markdown interpreter * Fixing some bugs in Websequence and YUML plugins Enable others to add more plugins using pegdown sytnax. What type of PR is it? Improvement Todos Nothing What is the Jira issue? [JIRA - ZEPPELIN-1614] ( https://issues.apache.org/jira/browse/ZEPPELIN-1614 ) How should this be tested? Some functional tests are included. Screenshots (if appropriate) Questions: Does the licenses files need update? - YES Is there breaking changes for older versions? - NO Does this needs documentation? - YES You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin feat/remove-markdown4j-dep Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1594.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1594 commit 3247c675acf859b32ba00a3da19daaa327d424c1 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-03T16:36:15Z feat: Support webseq markdown plugin commit 3e9716da637f60d0abf3927e5b32b995210123cf Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-03T16:36:30Z feat: Yuml markdown plugin commit 98b28097c4d1d9c3b99e0bf593d4d66b713eeac4 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-03T16:58:31Z fix: Add missing docs commit cf19f0b94a82a85c1fc333d3235592dcce55f19d Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T02:34:51Z fix: Cleanup unused Markdown4j Parser commit 81fdfccb1a2b1d1464d31c9e7c86ee91205178c0 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T02:35:20Z docs: Remove markdown.parser.type option commit c48cc535ccd84e7b93fe84a0d29046e6327cdd33 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T02:50:23Z chore: Remove markdown4j dep and update license commit b43e14e97ec0cadf421d516f37cc4d503238f93f Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T03:51:26Z fix: Set {} to avoid 503 commit dc4f110e9e605915815a729ae4fee81a88c67895 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T03:56:42Z fix: Parse style param optionally in webseq commit c656d08c4fc829a565c610bfc8dfa3e51df671e7 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T06:14:37Z fix: style and misspell in docs commit 1b7787f387f199b9f8110ecc66f23435056d4e26 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-04T06:28:44Z fix: Propagate exception in YUML plugin commit 73956e07364c4d1447d4d4e15a5e128f7e3fc830 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:22:30Z Revert "fix: Propagate exception in YUML plugin" This reverts commit f704d3ef6558f1a4c82caebed5e4c6e7ba3bb825. commit 8cfb2c81a6a5d360772ff9b52efeae496b66b44e Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:22:48Z Revert "fix: style and misspell in docs" This reverts commit a9c619d842db7e37aea525a77dac36cddd2d4924. commit 4e4893352f1b75c2786797aafd7ca9043f01fe13 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:23:10Z Revert "fix: Parse style param optionally in webseq" This reverts commit 580233fb715fdf141adb3ea0920c143327720ef7. commit a59ebbd531282a51f2336ab4dce82a83f50ef63a Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:24:14Z Revert "fix: Set {} to avoid 503" This reverts commit cd45d85a1e3260569b4e94e26a9b494de01f6821. commit fddc45940415a5600df03e20c66be59c1a80dd6b Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:24:28Z Revert "chore: Remove markdown4j dep and update license" This reverts commit 226c1e67c8b44e22c6c68679e80b0d497d5343d4. commit 33fb800bf3727e55d2cbcf509d7e5399438ea790 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:24:47Z Revert "docs: Remove markdown.parser.type option" This reverts commit a36c86c1828ae33d967a9847d604dd539a005ff7. commit 9268695ea02949bdf1031f98d4d072de5f55db6f Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:25:10Z Revert "fix: Cleanup unused Markdown4j Parser" This reverts commit e9fb0df57b7b5b3737b467c7c0d9ab3de852f5e8. commit 8831ca1fd33e7df9bde53b932de74bcc4d107929 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:33:32Z fix: Wrap exceptions in catch stmt commit 7c5d41e308bf6988f9a3bb2188517b624e4ea3c4 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:34:54Z fix: Parse style param optionally in webseq commit de3549d8a9e3e55998f48045f0763c396fbc96ae Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:36:47Z chore: Cleanup duplicated markdown4j license commit 13e0dc42a703dcc90500894c2ca4fcb4c1807580 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:44:11Z Update: interpreter setting and docs commit a1e779d648aadd73416154195755dcae13c028bb Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:47:09Z style: Use zeppelin checkstyle.xml commit 5c622362425455de14e88ab662cbbd42567d898c Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-07T05:57:06Z docs: Update upgrade.md for '%md' commit c57fdcb8214068af9b69e3417c230807e878b01c Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-10T04:34:12Z docs: Update markdown.md commit 5af160743ecef96e4a6fd8dfbfe6c187f90d4fe9 Author: 1ambda <1amb4a@gmail.com> Date: 2016-11-10T09:03:27Z fix: Failed tests in InterpreterRestApiTest
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1594

          @Leemoonsoo @felixcheung @bzz test is now green

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1594 @Leemoonsoo @felixcheung @bzz test is now green
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1594

          @bzz Please let me know if you need anything to merge this PR

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1594 @bzz Please let me know if you need anything to merge this PR
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bzz commented on the issue:

          https://github.com/apache/zeppelin/pull/1594

          Looks great to me,
          merging to master if there is no further discussion

          Show
          githubbot ASF GitHub Bot added a comment - Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1594 Looks great to me, merging to master if there is no further discussion
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/1594

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1594
          Hide
          bzz Alexander Bezzubov added a comment - - edited

          Hoon Park I took the liberty of seting 'fix version' and 'affect version' and Assigning it to you to keep attribution - could you please double-check?

          Next time, if you could fill in those fields yourself - that would be of a great help to Release Manager, next time it produces the change-log for release.

          Show
          bzz Alexander Bezzubov added a comment - - edited Hoon Park I took the liberty of seting 'fix version' and 'affect version' and Assigning it to you to keep attribution - could you please double-check? Next time, if you could fill in those fields yourself - that would be of a great help to Release Manager, next time it produces the change-log for release.

            People

            • Assignee:
              1ambda Hoon Park
              Reporter:
              1ambda Hoon Park
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development