Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: None
    • Labels:
      None

      Description

      This enables two different users to change the view of the same paragraph's result with different view even owner change paragraph and run it again.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user jongyoul opened a pull request:

          https://github.com/apache/zeppelin/pull/1660

          [WIP]ZEPPELIN-1594 Personalized mode

              1. What is this PR for?
                Support personalized mode in multi user environments.
              1. What type of PR is it?
                [Feature]
              1. Todos
          • [x] - Add the method to send the result to specific user
          • [ ] - Add the UI to toggle "personlized mode" in a note
              1. What is the Jira issue?
              1. How should this be tested?
                1. Apply this patch
                2. Enable shiro
                3. note.config.personalizedMode = true in a note.json to be tested
              1. Screenshots (if appropriate)
              1. Questions:
          • Does the licenses files need update? No
          • Is there breaking changes for older versions? No
          • Does this needs documentation? Yes

          This covers the first Todo only. @cloverhearts @1ambda Can you help me implement in a front-side?

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1594

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1660.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1660


          commit f23e4f34d07c18405d3a7b05d8903dd5c1973354
          Author: Jongyoul Lee <jongyoul@gmail.com>
          Date: 2016-11-20T22:01:30Z

          Added the logic to check if personalized mode turns on or not
          Added the method to send note update to specific user


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/1660 [WIP] ZEPPELIN-1594 Personalized mode What is this PR for? Support personalized mode in multi user environments. What type of PR is it? [Feature] Todos [x] - Add the method to send the result to specific user [ ] - Add the UI to toggle "personlized mode" in a note What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1594 How should this be tested? 1. Apply this patch 2. Enable shiro 3. note.config.personalizedMode = true in a note.json to be tested Screenshots (if appropriate) Questions: Does the licenses files need update? No Is there breaking changes for older versions? No Does this needs documentation? Yes This covers the first Todo only. @cloverhearts @1ambda Can you help me implement in a front-side? You can merge this pull request into a Git repository by running: $ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1594 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1660.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1660 commit f23e4f34d07c18405d3a7b05d8903dd5c1973354 Author: Jongyoul Lee <jongyoul@gmail.com> Date: 2016-11-20T22:01:30Z Added the logic to check if personalized mode turns on or not Added the method to send note update to specific user
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1660

          @cloverhearts @1ambda Can you help me?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1660 @cloverhearts @1ambda Can you help me?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user cloverhearts commented on the issue:

          https://github.com/apache/zeppelin/pull/1660

          @jongyoul
          Sure, What part are you helping me with?

          Show
          githubbot ASF GitHub Bot added a comment - Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1660 @jongyoul Sure, What part are you helping me with?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1660

          I think we need to implement the second todo item.

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1660 I think we need to implement the second todo item.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user cloverhearts commented on the issue:

          https://github.com/apache/zeppelin/pull/1660

          @1ambda
          hmm.. But, this PR does not seem to have an implementation for the personalization toggle.
          This PR seems to be implemented only in the context of the per user send when personalization mode.
          hmm... I'm sorry.
          (perhaps).. i did missing part?

          Show
          githubbot ASF GitHub Bot added a comment - Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1660 @1ambda hmm.. But, this PR does not seem to have an implementation for the personalization toggle. This PR seems to be implemented only in the context of the per user send when personalization mode. hmm... I'm sorry. (perhaps).. i did missing part?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user khalidhuseynov commented on the issue:

          https://github.com/apache/zeppelin/pull/1660

          @jongyoul thanks for starting work on it! one more question. with current implementation in case of refreshing the page, user will get last run note right? so for example, if `user2` runs note and `user1` refreshes, he'll still get results of `user1`. any roadmap on that?

          Show
          githubbot ASF GitHub Bot added a comment - Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1660 @jongyoul thanks for starting work on it! one more question. with current implementation in case of refreshing the page, user will get last run note right? so for example, if `user2` runs note and `user1` refreshes, he'll still get results of `user1`. any roadmap on that?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1660

          @jongyoul Could you describe more about the personalized mode? I don't think current implementation is anywhere close to personalized mode discussed in https://issues.apache.org/jira/browse/ZEPPELIN-1236.

          I think Personalized mode should be

          • Keep boardcast every changes to every users who open the same note
          • Zeppelin personalize parts of the Note, which is
          • paragraph.result (output)
          • paragraph.config.graph (graph selections)
          • paragraph.settings (dynamic form)

          So, every changes, like paragraph addition, deletion, change the code, change width,
          everything is broadcasted, but only result / graph selection / dynamic form is personalized.

          Current implementation will have following limitations

          • Once user refresh the page, user will see the other result.
          • Once two users changes note at the same time (i.e. update paragraph code, change paragraph order, etc), the result is undefined.
          • Chart selection, dynamic form value is not personalized, which is major pain point that personalized mode try to resolve, i think.

          What do you think?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1660 @jongyoul Could you describe more about the personalized mode? I don't think current implementation is anywhere close to personalized mode discussed in https://issues.apache.org/jira/browse/ZEPPELIN-1236 . I think Personalized mode should be Keep boardcast every changes to every users who open the same note Zeppelin personalize parts of the Note, which is paragraph.result (output) paragraph.config.graph (graph selections) paragraph.settings (dynamic form) So, every changes, like paragraph addition, deletion, change the code, change width, everything is broadcasted, but only result / graph selection / dynamic form is personalized. Current implementation will have following limitations Once user refresh the page, user will see the other result. Once two users changes note at the same time (i.e. update paragraph code, change paragraph order, etc), the result is undefined. Chart selection, dynamic form value is not personalized, which is major pain point that personalized mode try to resolve, i think. What do you think?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1660

          @Leemoonsoo As we discussed before, the first version of personalized mode is to avoid changing note simultaneously while two user see a same note. I think this version fits it. one user want to change a paragraph or run a paragraph, and he has a proper permission, he can change it but the others doesn't see his change until they refresh their browser. but they refresh it, the newest one is adopted. Isn't it the first version of personalized mode?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1660 @Leemoonsoo As we discussed before, the first version of personalized mode is to avoid changing note simultaneously while two user see a same note. I think this version fits it. one user want to change a paragraph or run a paragraph, and he has a proper permission, he can change it but the others doesn't see his change until they refresh their browser. but they refresh it, the newest one is adopted. Isn't it the first version of personalized mode?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1660

          @Leemoonsoo I've not tested the graph. If you mean a dynamic change of graph, I'll check it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1660 @Leemoonsoo I've not tested the graph. If you mean a dynamic change of graph, I'll check it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1660

          @jongyoul I think key requirement of personalized mode is two or more different user want to keep their own dynamic form input and the output of paragraph. How can this be done without let user run paragraph?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1660 @jongyoul I think key requirement of personalized mode is two or more different user want to keep their own dynamic form input and the output of paragraph. How can this be done without let user run paragraph?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1660

          @Leemoonsoo Yes, I haven't check the front-side. I'll fix it

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1660 @Leemoonsoo Yes, I haven't check the front-side. I'll fix it
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul closed the pull request at:

          https://github.com/apache/zeppelin/pull/1660

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul closed the pull request at: https://github.com/apache/zeppelin/pull/1660
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user jongyoul opened a pull request:

          https://github.com/apache/zeppelin/pull/1753

          ZEPPELIN-1594 Supported personalized mode

              1. What is this PR for?
                Enabling "Personalized Mode" for specific note
              1. What type of PR is it?
                [Feature]
              1. Todos
          • [x] - Backend work for supporting that feature
          • [ ] - Develop front-end UI
              1. What is the Jira issue?
              1. How should this be tested?
                1. config.personalizedMode = true in note.json
                1. Navigate some jobs in two different browser
              1. Screenshots (if appropriate)
              1. Questions:
          • Does the licenses files need update? No
          • Is there breaking changes for older versions? No
          • Does this needs documentation? No

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1594

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1753.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1753


          commit 71b356464695a812900059b316e92f808bd70f3a
          Author: Jongyoul Lee <jl@jongyouls-macbook-pro.local>
          Date: 2016-12-13T15:52:15Z

          Supported personalized mode


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/1753 ZEPPELIN-1594 Supported personalized mode What is this PR for? Enabling "Personalized Mode" for specific note What type of PR is it? [Feature] Todos [x] - Backend work for supporting that feature [ ] - Develop front-end UI What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1594 How should this be tested? 1. config.personalizedMode = true in note.json 1. Navigate some jobs in two different browser Screenshots (if appropriate) Questions: Does the licenses files need update? No Is there breaking changes for older versions? No Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1594 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1753.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1753 commit 71b356464695a812900059b316e92f808bd70f3a Author: Jongyoul Lee <jl@jongyouls-macbook-pro.local> Date: 2016-12-13T15:52:15Z Supported personalized mode
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1753

          @cloverhearts @1ambda Can you guys help me to implement some frontend side? @Leemoonsoo Review this please. If I've missed something, let me know.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1753 @cloverhearts @1ambda Can you guys help me to implement some frontend side? @Leemoonsoo Review this please. If I've missed something, let me know.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user cloverhearts commented on the issue:

          https://github.com/apache/zeppelin/pull/1753

          Hello, @jongyoul.
          What do you think on this mockup?

          ![pmode](https://cloud.githubusercontent.com/assets/10525473/21179014/7d37a6ec-c235-11e6-9ea4-ab10c57570b7.png)

          Show
          githubbot ASF GitHub Bot added a comment - Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1753 Hello, @jongyoul. What do you think on this mockup? ! [pmode] ( https://cloud.githubusercontent.com/assets/10525473/21179014/7d37a6ec-c235-11e6-9ea4-ab10c57570b7.png )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user cloverhearts commented on the issue:

          https://github.com/apache/zeppelin/pull/1753

          ![123123ppp](https://cloud.githubusercontent.com/assets/10525473/21213045/44013a82-c2d5-11e6-82e6-5c7591069516.gif)

          support `live mode share `
          the notes about using the user-to-user mode are reflected in real time.
          corrected invalid log name.
          only `owner` can modify personalized mode.

          Show
          githubbot ASF GitHub Bot added a comment - Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1753 ! [123123ppp] ( https://cloud.githubusercontent.com/assets/10525473/21213045/44013a82-c2d5-11e6-82e6-5c7591069516.gif ) support `live mode share ` the notes about using the user-to-user mode are reflected in real time. corrected invalid log name. only `owner` can modify personalized mode.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1753

          @minahlee @Leemoonsoo Please test it. @cloverhearts and I have tested but I want to check it again.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1753 @minahlee @Leemoonsoo Please test it. @cloverhearts and I have tested but I want to check it again.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user cloverhearts commented on the issue:

          https://github.com/apache/zeppelin/pull/1753

          CI failed.
          However, this is a not relate to modifications.
          ```
          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project zeppelin-pig: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
          [ERROR] Command was /bin/sh -c cd /home/travis/build/apache/zeppelin/pig && /usr/lib/jvm/java-7-oracle/jre/bin/java -Xmx2g -Xms1g -Dfile.encoding=UTF-8 -jar /home/travis/build/apache/zeppelin/pig/target/surefire/surefirebooter6134435344985761979.jar /home/travis/build/apache/zeppelin/pig/target/surefire/surefire308229830701668274tmp /home/travis/build/apache/zeppelin/pig/target/surefire/surefire_331449743848135082457tmp
          [ERROR] -> [Help 1]
          [ERROR]
          [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [ERROR]
          [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
          [ERROR]
          [ERROR] After correcting the problems, you can resume the build with the command
          [ERROR] mvn <goals> -rf :zeppelin-pig
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1753 CI failed. However, this is a not relate to modifications. ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project zeppelin-pig: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called? [ERROR] Command was /bin/sh -c cd /home/travis/build/apache/zeppelin/pig && /usr/lib/jvm/java-7-oracle/jre/bin/java -Xmx2g -Xms1g -Dfile.encoding=UTF-8 -jar /home/travis/build/apache/zeppelin/pig/target/surefire/surefirebooter6134435344985761979.jar /home/travis/build/apache/zeppelin/pig/target/surefire/surefire308229830701668274tmp /home/travis/build/apache/zeppelin/pig/target/surefire/surefire_331449743848135082457tmp [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :zeppelin-pig ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1753

          Great!!!

          I checked this branch and found dynamic form is not being displayed in personalized mode.
          Could you check?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1753 Great!!! I checked this branch and found dynamic form is not being displayed in personalized mode. Could you check?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1753

          Except the comment that I left in the above, working well as expected

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1753 Except the comment that I left in the above, working well as expected
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1753

          It's related AngularObject, isn't it? I'll check it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1753 It's related AngularObject, isn't it? I'll check it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1753

          @Leemoonsoo @minahlee Review it, please.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1753 @Leemoonsoo @minahlee Review it, please.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1753

          I think it has implemented basic function what we intended. Merging if there's no more discussion and will fix some bugs if we find any minor wrong behaviour.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1753 I think it has implemented basic function what we intended. Merging if there's no more discussion and will fix some bugs if we find any minor wrong behaviour.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1753

          @jongyoul @cloverhearts Did you have any chance to check [my comment](https://github.com/apache/zeppelin/pull/1753#pullrequestreview-13267973)?

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1753 @jongyoul @cloverhearts Did you have any chance to check [my comment] ( https://github.com/apache/zeppelin/pull/1753#pullrequestreview-13267973)?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1753

          @jongyoul @cloverhearts Didn't saw the last commit. Please ignore my last comment

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1753 @jongyoul @cloverhearts Didn't saw the last commit. Please ignore my last comment
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1753

          @AhyoungRyu Yes, AFAIK, @cloverhearts has changed it

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1753 @AhyoungRyu Yes, AFAIK, @cloverhearts has changed it
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user jongyoul opened a pull request:

          https://github.com/apache/zeppelin/pull/1793

          [MINOR] Refactoring Job and Paragraph

              1. What is this PR for?
                Job class has only two sub classes. I don't think we need Job abstraction class anymore, then I'll move all function of Job into Paragraph and InterpretJob. Paragraph is used into zeppelin-server and InterpretJob is done by remoteInterpreterServer. I think what we disconnect those two different classes is better to maintain each side of codes. This PR moves two variable - result and results - from Job to Paragraph in order to remove Job class. It also based on ZEPPELIN-1594(#1753), thus all reviewers click the last commit and review it.
              1. What type of PR is it?
                [Refactoring]
              1. Todos
          • [x] - Moved these variables into Paragraph
              1. What is the Jira issue?
                N/A
              1. How should this be tested?
                All things are same as before
              1. Screenshots (if appropriate)
                N/A
              1. Questions:
          • Does the licenses files need update? No
          • Is there breaking changes for older versions? No
          • Does this needs documentation? No

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/jongyoul/zeppelin minor/refactoring-job-paragraph

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1793.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1793


          commit f62727839154532287f44567807319c180b8942c
          Author: Jongyoul Lee <jl@jongyouls-macbook-pro.local>
          Date: 2016-12-13T15:52:15Z

          Supported personalized mode

          commit a7c91f1ba037a1642eab2cf1f5719d0cb56f58a0
          Author: Jongyoul Lee <jl@jongyouls-macbook-pro.local>
          Date: 2016-12-13T16:12:50Z

          Fixed the bug while not using personalized mode

          commit 4fabd8872f1c40265e4a4036b0ed60c15717c870
          Author: Jongyoul Lee <jl@jongyouls-macbook-pro.local>
          Date: 2016-12-14T14:29:29Z

          Fixed style

          commit 20425e7ef3205748e8d0606eeade84f3f00848fd
          Author: CloverHearts <cloverheartsdev@gmail.com>
          Date: 2016-12-14T16:07:31Z

          add toggleNotePersonalizedMode and ui

          commit 9fcb7f8ef487382b4ab847e55fde39f4c2f34c7a
          Author: CloverHearts <cloverheartsdev@gmail.com>
          Date: 2016-12-14T19:18:36Z

          implement ui

          commit f59d26a34ac23b2ff9cf3d03cd8198b6176d9e94
          Author: CloverHearts <cloverheartsdev@gmail.com>
          Date: 2016-12-14T19:19:40Z

          implement update personalized mode websocket event in backend

          commit 2c7bd398c381ebbc84d1b1b2ff2b08912ffae36e
          Author: CloverHearts <cloverheartsdev@gmail.com>
          Date: 2016-12-15T05:45:52Z

          broadcast bugfix

          commit 70f68d88dc7b71e5bca194a8eb476ecf2eb0c10e
          Author: Jongyoul Lee <jl@jongyouls-macbook-pro.local>
          Date: 2016-12-20T07:10:19Z

          Fixed dynamic forms
          Fixed NPE while broadcasting userParagraphsMap

          commit a9d8f7ee04c65b7c444cb71a7429b80239932104
          Author: CloverHearts <cloverhearts@users.noreply.github.com>
          Date: 2016-12-20T07:26:26Z

          change mode name shared to collaboration and dialog message (#5)

          • change mode name shared to collaboration and dialog message
          • change dialog message Collaboration -> collaborate,

          commit 893fbbc176641b9cd36bcd26bd66330c234fee78
          Author: Jongyoul Lee <jongyoul@gmail.com>
          Date: 2016-12-22T14:53:04Z

          Moved result(s) from Job into Paragraph


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/1793 [MINOR] Refactoring Job and Paragraph What is this PR for? Job class has only two sub classes. I don't think we need Job abstraction class anymore, then I'll move all function of Job into Paragraph and InterpretJob. Paragraph is used into zeppelin-server and InterpretJob is done by remoteInterpreterServer. I think what we disconnect those two different classes is better to maintain each side of codes. This PR moves two variable - result and results - from Job to Paragraph in order to remove Job class. It also based on ZEPPELIN-1594 (#1753), thus all reviewers click the last commit and review it. What type of PR is it? [Refactoring] Todos [x] - Moved these variables into Paragraph What is the Jira issue? N/A How should this be tested? All things are same as before Screenshots (if appropriate) N/A Questions: Does the licenses files need update? No Is there breaking changes for older versions? No Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/jongyoul/zeppelin minor/refactoring-job-paragraph Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1793.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1793 commit f62727839154532287f44567807319c180b8942c Author: Jongyoul Lee <jl@jongyouls-macbook-pro.local> Date: 2016-12-13T15:52:15Z Supported personalized mode commit a7c91f1ba037a1642eab2cf1f5719d0cb56f58a0 Author: Jongyoul Lee <jl@jongyouls-macbook-pro.local> Date: 2016-12-13T16:12:50Z Fixed the bug while not using personalized mode commit 4fabd8872f1c40265e4a4036b0ed60c15717c870 Author: Jongyoul Lee <jl@jongyouls-macbook-pro.local> Date: 2016-12-14T14:29:29Z Fixed style commit 20425e7ef3205748e8d0606eeade84f3f00848fd Author: CloverHearts <cloverheartsdev@gmail.com> Date: 2016-12-14T16:07:31Z add toggleNotePersonalizedMode and ui commit 9fcb7f8ef487382b4ab847e55fde39f4c2f34c7a Author: CloverHearts <cloverheartsdev@gmail.com> Date: 2016-12-14T19:18:36Z implement ui commit f59d26a34ac23b2ff9cf3d03cd8198b6176d9e94 Author: CloverHearts <cloverheartsdev@gmail.com> Date: 2016-12-14T19:19:40Z implement update personalized mode websocket event in backend commit 2c7bd398c381ebbc84d1b1b2ff2b08912ffae36e Author: CloverHearts <cloverheartsdev@gmail.com> Date: 2016-12-15T05:45:52Z broadcast bugfix commit 70f68d88dc7b71e5bca194a8eb476ecf2eb0c10e Author: Jongyoul Lee <jl@jongyouls-macbook-pro.local> Date: 2016-12-20T07:10:19Z Fixed dynamic forms Fixed NPE while broadcasting userParagraphsMap commit a9d8f7ee04c65b7c444cb71a7429b80239932104 Author: CloverHearts <cloverhearts@users.noreply.github.com> Date: 2016-12-20T07:26:26Z change mode name shared to collaboration and dialog message (#5) change mode name shared to collaboration and dialog message change dialog message Collaboration -> collaborate, commit 893fbbc176641b9cd36bcd26bd66330c234fee78 Author: Jongyoul Lee <jongyoul@gmail.com> Date: 2016-12-22T14:53:04Z Moved result(s) from Job into Paragraph
          Hide
          jongyoul Jongyoul Lee added a comment -

          Issue resolved by pull request 1753
          https://github.com/apache/zeppelin/pull/1753

          Show
          jongyoul Jongyoul Lee added a comment - Issue resolved by pull request 1753 https://github.com/apache/zeppelin/pull/1753
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/1753

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1753
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/1793

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1793

            People

            • Assignee:
              jongyoul Jongyoul Lee
              Reporter:
              jongyoul Jongyoul Lee
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development