Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-1566

Make paragraph editable with double click

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: GUI
    • Labels:
      None

      Description

      Add editOnDoubleClick field in interpreter-setting.json

      If it is set to true:

      • doubleclick on paragraph will show editor and make paragraph editable
      • hide output after running paragraph

      If it is set to false it will behave same as now

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user minahlee opened a pull request:

          https://github.com/apache/zeppelin/pull/1540

          [WIP]ZEPPELIN-1566 Make paragraph editable with double click

              1. What is this PR for?
                This PR enables edit on double click for markdown/angular paragraph. Users can change `editOnDblClick` field to be `false` by editting `interpreter/md/interpreter-setting.json` or `conf/interpreter.json`. In the same context, users can set other type paragraphs to be editable on double click by setting `editOnDblClick` to be true.

          This PR also fixes bug that syntax highlight doesn't work on pasted code.

              1. What type of PR is it?
                Feature
              1. Todos
          • [ ] Create test
          • [ ] Update docs
              1. What is the Jira issue?
                ZEPPELIN-1566(https://issues.apache.org/jira/browse/ZEPPELIN-1566)
              1. How should this be tested?
                1. Create new markdown interpreter
                2. Create notebook and run markdown paragraph
                3. Double click markdown paragraph to edit
              1. Screenshots (if appropriate)

          *Edit on double click and hide editor on paragraph run*
          ![oct-20-2016 12-28-54](https://cloud.githubusercontent.com/assets/8503346/19545401/ca2a69a8-96c0-11e6-9e70-ca930fd7cc8e.gif)

          *Syntax highlight on paste*

          Before
          ![oct-20-2016 12-24-54](https://cloud.githubusercontent.com/assets/8503346/19545333/46a2f2a8-96c0-11e6-910a-2a216da5603b.gif)

          After
          ![oct-20-2016 12-25-06](https://cloud.githubusercontent.com/assets/8503346/19545338/4d3bb852-96c0-11e6-8dc4-ff839234876a.gif)

              1. Questions:
          • Does the licenses files need update? no
          • Is there breaking changes for older versions? no
          • Does this needs documentation? yes

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1566

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1540.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1540


          commit b6720c097f2ffd53a808ae5aead5605f996bb2c8
          Author: Mina Lee <minalee@apache.org>
          Date: 2016-10-19T08:41:14Z

          Split getAndSetEditorSetting method into getEditorSetting and setEditorLanguage method

          commit e934aaee4ccdc406a6dfa27491a6a386bcd4cca9
          Author: Mina Lee <minalee@apache.org>
          Date: 2016-10-20T03:17:02Z

          Make paragraph editable on doubleclick if editOnDblClick set true in interpreter-setting.json

          commit 41f6a92dd88fafc555f4a2102bae1d98cdd9498f
          Author: Mina Lee <minalee@apache.org>
          Date: 2016-10-20T03:54:08Z

          Add editOnDblClick field in interpreter-setting.json


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user minahlee opened a pull request: https://github.com/apache/zeppelin/pull/1540 [WIP] ZEPPELIN-1566 Make paragraph editable with double click What is this PR for? This PR enables edit on double click for markdown/angular paragraph. Users can change `editOnDblClick` field to be `false` by editting `interpreter/md/interpreter-setting.json` or `conf/interpreter.json`. In the same context, users can set other type paragraphs to be editable on double click by setting `editOnDblClick` to be true. This PR also fixes bug that syntax highlight doesn't work on pasted code. What type of PR is it? Feature Todos [ ] Create test [ ] Update docs What is the Jira issue? ZEPPELIN-1566 ( https://issues.apache.org/jira/browse/ZEPPELIN-1566 ) How should this be tested? 1. Create new markdown interpreter 2. Create notebook and run markdown paragraph 3. Double click markdown paragraph to edit Screenshots (if appropriate) * Edit on double click and hide editor on paragraph run * ! [oct-20-2016 12-28-54] ( https://cloud.githubusercontent.com/assets/8503346/19545401/ca2a69a8-96c0-11e6-9e70-ca930fd7cc8e.gif ) * Syntax highlight on paste * Before ! [oct-20-2016 12-24-54] ( https://cloud.githubusercontent.com/assets/8503346/19545333/46a2f2a8-96c0-11e6-910a-2a216da5603b.gif ) After ! [oct-20-2016 12-25-06] ( https://cloud.githubusercontent.com/assets/8503346/19545338/4d3bb852-96c0-11e6-8dc4-ff839234876a.gif ) Questions: Does the licenses files need update? no Is there breaking changes for older versions? no Does this needs documentation? yes You can merge this pull request into a Git repository by running: $ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1566 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1540.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1540 commit b6720c097f2ffd53a808ae5aead5605f996bb2c8 Author: Mina Lee <minalee@apache.org> Date: 2016-10-19T08:41:14Z Split getAndSetEditorSetting method into getEditorSetting and setEditorLanguage method commit e934aaee4ccdc406a6dfa27491a6a386bcd4cca9 Author: Mina Lee <minalee@apache.org> Date: 2016-10-20T03:17:02Z Make paragraph editable on doubleclick if editOnDblClick set true in interpreter-setting.json commit 41f6a92dd88fafc555f4a2102bae1d98cdd9498f Author: Mina Lee <minalee@apache.org> Date: 2016-10-20T03:54:08Z Add editOnDblClick field in interpreter-setting.json
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1540

          How about making editOnDblClick false by default?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1540 How about making editOnDblClick false by default?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user minahlee commented on the issue:

          https://github.com/apache/zeppelin/pull/1540

          @jongyoul Thank you for suggestion!
          As you might see I set `editOnDblClick` to be `true` for angular, markdown.

          I think make markdown paragraph editable with double click is quite common behavior. Jupyter notebook and databricks cloud would be the example. Also in ux point of view, I think it would be rare to show both editor and output at the same time for markdown paragraph.

          But not sure what would be better for angular paragraph.

          What do you think?

          Show
          githubbot ASF GitHub Bot added a comment - Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1540 @jongyoul Thank you for suggestion! As you might see I set `editOnDblClick` to be `true` for angular, markdown. I think make markdown paragraph editable with double click is quite common behavior. Jupyter notebook and databricks cloud would be the example. Also in ux point of view, I think it would be rare to show both editor and output at the same time for markdown paragraph. But not sure what would be better for angular paragraph. What do you think?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1540

          It looks good to hide editor on md. And I'm not good at ui, but in case of angular, I think it's better to hide it, too.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1540 It looks good to hide editor on md. And I'm not good at ui, but in case of angular, I think it's better to hide it, too.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user anthonycorbacho commented on the issue:

          https://github.com/apache/zeppelin/pull/1540

          Awesome, *LGTM*

          Show
          githubbot ASF GitHub Bot added a comment - Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1540 Awesome, * LGTM *
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user minahlee commented on the issue:

          https://github.com/apache/zeppelin/pull/1540

          @jongyoul @anthonycorbacho Thank you for review! Merging if there is no more discussion.

          Show
          githubbot ASF GitHub Bot added a comment - Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1540 @jongyoul @anthonycorbacho Thank you for review! Merging if there is no more discussion.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tae-jun commented on the issue:

          https://github.com/apache/zeppelin/pull/1540

          Wow, this is a really cool feature for me. Thanks! 👍

          Show
          githubbot ASF GitHub Bot added a comment - Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1540 Wow, this is a really cool feature for me. Thanks! 👍
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/1540

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1540

            People

            • Assignee:
              Mina Lee Mina Lee
              Reporter:
              Mina Lee Mina Lee
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development