GitHub user minahlee opened a pull request:

https://github.com/apache/zeppelin/pull/1540

[WIP]ZEPPELIN-1566 Make paragraph editable with double click

1. 1. 1. What is this PR for?
         This PR enables edit on double click for markdown/angular paragraph. Users can change `editOnDblClick` field to be `false` by editting `interpreter/md/interpreter-setting.json` or `conf/interpreter.json`. In the same context, users can set other type paragraphs to be editable on double click by setting `editOnDblClick` to be true.

This PR also fixes bug that syntax highlight doesn't work on pasted code.

1. 1. 1. What type of PR is it?
         Feature

1. 1. 1. Todos

• [ ] Create test
• [ ] Update docs

1. 1. 1. What is the Jira issue?
         ZEPPELIN-1566(https://issues.apache.org/jira/browse/ZEPPELIN-1566)

1. 1. 1. How should this be tested?
         1. Create new markdown interpreter
         2. Create notebook and run markdown paragraph
         3. Double click markdown paragraph to edit

1. 1. 1. Screenshots (if appropriate)

*Edit on double click and hide editor on paragraph run*

*Syntax highlight on paste*

Before

After

1. 1. 1. Questions:

• Does the licenses files need update? no
• Is there breaking changes for older versions? no
• Does this needs documentation? yes

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1566

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1540.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1540

commit b6720c097f2ffd53a808ae5aead5605f996bb2c8
Author: Mina Lee <minalee@apache.org>
Date: 2016-10-19T08:41:14Z

Split getAndSetEditorSetting method into getEditorSetting and setEditorLanguage method

commit e934aaee4ccdc406a6dfa27491a6a386bcd4cca9
Author: Mina Lee <minalee@apache.org>
Date: 2016-10-20T03:17:02Z

Make paragraph editable on doubleclick if editOnDblClick set true in interpreter-setting.json

commit 41f6a92dd88fafc555f4a2102bae1d98cdd9498f
Author: Mina Lee <minalee@apache.org>
Date: 2016-10-20T03:54:08Z

Add editOnDblClick field in interpreter-setting.json

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1540

How about making editOnDblClick false by default?

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1540

@jongyoul Thank you for suggestion!
As you might see I set `editOnDblClick` to be `true` for angular, markdown.

I think make markdown paragraph editable with double click is quite common behavior. Jupyter notebook and databricks cloud would be the example. Also in ux point of view, I think it would be rare to show both editor and output at the same time for markdown paragraph.

But not sure what would be better for angular paragraph.

What do you think?

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1540

It looks good to hide editor on md. And I'm not good at ui, but in case of angular, I think it's better to hide it, too.

Github user anthonycorbacho commented on the issue:

https://github.com/apache/zeppelin/pull/1540

Awesome, *LGTM*

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1540

@jongyoul @anthonycorbacho Thank you for review! Merging if there is no more discussion.

Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/1540

Wow, this is a really cool feature for me. Thanks! 👍

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1540