Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-1537

Elasticsearch interpreter improvement for aggregations

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.6.0, 0.6.1
    • Fix Version/s: 0.7.0
    • Component/s: Interpreters
    • Labels:
      None

      Description

      The result of an aggregation query returned by the interpreter contains only "key" and "doc_count" in case of a multi-buckets aggregations.
      But the result returned by Elasticsearch can contain more data according to the query.
      The result returned by the interpreter must return the same values as elasticsearch.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user bbonnin opened a pull request:

          https://github.com/apache/zeppelin/pull/1508

          ZEPPELIN-1537 Elasticsearch improvement for results of aggregations

              1. What is this PR for?
                The result of an aggregation query returned by the interpreter contains only "key" and "doc_count" in case of a multi-buckets aggregations.
                But the result returned by Elasticsearch can contain more data according to the query.
                This PR is an improvement of the result returned by the interpreter.
              1. What type of PR is it?
                [Improvement]
              1. Todos
          • [X] - Dev of the improvement in the interpreter
          • [X] - Add a test case
              1. What is the Jira issue?
                https://issues.apache.org/jira/browse/ZEPPELIN-1537
              1. How should this be tested?
                In a paragraph, enter a query with multiple aggregations:
                search /logs { "aggs" : {
                "length" : { "terms": { "field": "status" }

                ,
                "aggs" : { "sum_length" :

                Unknown macro: { "sum" }

                } } }

              1. Screenshots (if appropriate)
              1. Questions:
          • Does the licenses files need update? No
          • Is there breaking changes for older versions? No
          • Does this needs documentation? No

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/bbonnin/zeppelin master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1508.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1508


          commit a0a7bb9f3773340b9916f650fcbee5af8178fc21
          Author: Bruno Bonnin <bbonnin@gmail.com>
          Date: 2016-10-12T21:20:25Z

          Elasticsearch improvement for results of aggregations


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user bbonnin opened a pull request: https://github.com/apache/zeppelin/pull/1508 ZEPPELIN-1537 Elasticsearch improvement for results of aggregations What is this PR for? The result of an aggregation query returned by the interpreter contains only "key" and "doc_count" in case of a multi-buckets aggregations. But the result returned by Elasticsearch can contain more data according to the query. This PR is an improvement of the result returned by the interpreter. What type of PR is it? [Improvement] Todos [X] - Dev of the improvement in the interpreter [X] - Add a test case What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1537 How should this be tested? In a paragraph, enter a query with multiple aggregations: search /logs { "aggs" : { "length" : { "terms": { "field": "status" } , "aggs" : { "sum_length" : Unknown macro: { "sum" } } } } Screenshots (if appropriate) Questions: Does the licenses files need update? No Is there breaking changes for older versions? No Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbonnin/zeppelin master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1508.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1508 commit a0a7bb9f3773340b9916f650fcbee5af8178fc21 Author: Bruno Bonnin <bbonnin@gmail.com> Date: 2016-10-12T21:20:25Z Elasticsearch improvement for results of aggregations
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bzz commented on the issue:

          https://github.com/apache/zeppelin/pull/1508

          Looks good to me, 👍 for tests!

          Merging if there is no further discussion.

          Show
          githubbot ASF GitHub Bot added a comment - Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1508 Looks good to me, 👍 for tests! Merging if there is no further discussion.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/1508

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1508

            People

            • Assignee:
              bbonnin Bruno Bonnin
              Reporter:
              bbonnin Bruno Bonnin
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development