Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.6.1
    • Fix Version/s: 0.7.0
    • Component/s: Core
    • Labels:
      None

      Description

      It looks the markdown table is not supported when using the markdown interpreter.

      Concrete example:

      %md
      || H1 || H2 ||
      | a | b |
      | c | d |
      

      The raw result is returned

      || H1 || H2 || 
      | a | b | 
      | c | d |
      

      instead of a nice table like this

      H1 H2
      a b
      c d

        Issue Links

          Activity

          Hide
          1ambda Hoon Park added a comment - - edited

          The markdown4j library doesn't support table syntax currently. (https://github.com/JustinSDK/markdown4j/blob/wiki/ProjectHome.md)

          Maybe we could implement a table plugin for markdown4j based on the existing work like https://github.com/zhenchuan/txtmark/commit/178486805e78e3d572b071ca8b9f8887a066edef

          I think it would be more easier and reliable way to use well-managed markdown libraries such as pegdown if the license doesn't matter (https://github.com/sirthias/pegdown/)

          Show
          1ambda Hoon Park added a comment - - edited The markdown4j library doesn't support table syntax currently. ( https://github.com/JustinSDK/markdown4j/blob/wiki/ProjectHome.md ) Maybe we could implement a table plugin for markdown4j based on the existing work like https://github.com/zhenchuan/txtmark/commit/178486805e78e3d572b071ca8b9f8887a066edef I think it would be more easier and reliable way to use well-managed markdown libraries such as pegdown if the license doesn't matter ( https://github.com/sirthias/pegdown/ )
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user 1ambda opened a pull request:

          https://github.com/apache/zeppelin/pull/1384

          ZEPPELIN-1387 Support table in markdown interpreter

              1. What is this PR for?

          Support markdown syntax issued by ZEPPELIN-1387(https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN)

              1. What type of PR is it?
                [Bug Fix | Improvement]

          This PR can be categorized as bug fix and improvement since it not only resolves the above issue but also support other markdown syntaxes.

              1. Todos
              1. What is the Jira issue?

          ZEPPELIN-1387(https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN)

              1. How should this be tested?

          Write markdown texts and compare them with expected html DOMs

              1. Screenshots (if appropriate)

          <img width="708" alt="markdown" src="https://cloud.githubusercontent.com/assets/4968473/18061274/1f2be526-6e5d-11e6-9f1a-3528f3958d2c.png">

              1. Questions:
          • Does the licenses files need update?
          • Does coding style is appropriate?

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/1ambda/zeppelin fix-zeppelin-1387

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1384.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1384


          commit 029f550a04721c786b1d0021ac9551f2a6e62aed
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-08-29T17:44:21Z

          ZEPPELIN-1387 Support table in markdown interpreter


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1384 ZEPPELIN-1387 Support table in markdown interpreter What is this PR for? Support markdown syntax issued by ZEPPELIN-1387 ( https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN ) What type of PR is it? [Bug Fix | Improvement] This PR can be categorized as bug fix and improvement since it not only resolves the above issue but also support other markdown syntaxes. Todos [ ] - Check the license issue of the [pegdown] ( https://github.com/sirthias/pegdown ) library introduced by this PR What is the Jira issue? ZEPPELIN-1387 ( https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN ) How should this be tested? Write markdown texts and compare them with expected html DOMs Screenshots (if appropriate) <img width="708" alt="markdown" src="https://cloud.githubusercontent.com/assets/4968473/18061274/1f2be526-6e5d-11e6-9f1a-3528f3958d2c.png"> Questions: Does the licenses files need update? Does coding style is appropriate? You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin fix-zeppelin-1387 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1384.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1384 commit 029f550a04721c786b1d0021ac9551f2a6e62aed Author: 1ambda <1amb4a@gmail.com> Date: 2016-08-29T17:44:21Z ZEPPELIN-1387 Support table in markdown interpreter
          Hide
          1ambda Hoon Park added a comment -

          I proposed PR for this issue. Could anyone review it?

          Show
          1ambda Hoon Park added a comment - I proposed PR for this issue. Could anyone review it? https://github.com/apache/zeppelin/pull/1384
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bzz commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @1ambda thank you for improvement! Let me review and get back to you with it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1384 @1ambda thank you for improvement! Let me review and get back to you with it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @1ambda Thank you for the contribution! I just shortly look through the screenshot in the description, but comparing to Github markdown support it seems Zeppelin's table doesn't have a table border. If I make the below table in Github,

          ```

          Tables Are Cool
          ---------- :-------------: ------:
          col 1 is left-aligned $1600
          col 2 is centered $12
          col 3 is right-aligned $1

          ```

          it will be shown like this.

          <img width="313" alt="screen shot 2016-08-30 at 11 10 51 am" src="https://cloud.githubusercontent.com/assets/10060731/18073629/8b893116-6ea2-11e6-9166-46e246acbc04.png">

          But in Zeppelin it doesn't have the border.
          <img width="446" alt="screen shot 2016-08-30 at 11 17 57 am" src="https://cloud.githubusercontent.com/assets/10060731/18073791/7681b1ca-6ea3-11e6-9229-3104a33332dc.png">

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1384 @1ambda Thank you for the contribution! I just shortly look through the screenshot in the description, but comparing to Github markdown support it seems Zeppelin's table doesn't have a table border. If I make the below table in Github, ``` Tables Are Cool ---------- :-------------: ------: col 1 is left-aligned $1600 col 2 is centered $12 col 3 is right-aligned $1 ``` it will be shown like this. <img width="313" alt="screen shot 2016-08-30 at 11 10 51 am" src="https://cloud.githubusercontent.com/assets/10060731/18073629/8b893116-6ea2-11e6-9166-46e246acbc04.png"> But in Zeppelin it doesn't have the border. <img width="446" alt="screen shot 2016-08-30 at 11 17 57 am" src="https://cloud.githubusercontent.com/assets/10060731/18073791/7681b1ca-6ea3-11e6-9229-3104a33332dc.png">
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bzz commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          The change of library looks great to me, πŸ‘ for having a test case!

          Few things to take care of, before merging it:

          • for all the code, please make sure it follows project [styleguide\code conventions](https://github.com/apache/zeppelin/blob/master/CONTRIBUTING.md#code-convention)
          • as you add a new dependency - it will become a part of the next release convenience binary for Zeppelin and in order to be included, we need to verify it's licence compatibility. Can you please add it to `zeppelin-distribution/src/licence_bin/LICENSE`
          • also, applying some styles for such tables, as noted by @AhyoungRyu sounds like a good improvement as well
          Show
          githubbot ASF GitHub Bot added a comment - Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1384 The change of library looks great to me, πŸ‘ for having a test case! Few things to take care of, before merging it: for all the code, please make sure it follows project [styleguide\code conventions] ( https://github.com/apache/zeppelin/blob/master/CONTRIBUTING.md#code-convention ) as you add a new dependency - it will become a part of the next release convenience binary for Zeppelin and in order to be included, we need to verify it's licence compatibility. Can you please add it to `zeppelin-distribution/src/licence_bin/LICENSE` also, applying some styles for such tables, as noted by @AhyoungRyu sounds like a good improvement as well
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          I will refine this PR.

          Thanks for the detailed and significant review @AhyoungRyu @bzz

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 I will refine this PR. Thanks for the detailed and significant review @AhyoungRyu @bzz
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          Thanks @1ambda for the improvement.

          Regarding license, 'markdown4j' section in the `zeppelin-distribution/src/licence_bin/LICENSE` should be removed while the library is no longer included in the binary package.

          Also `pegdown` library does have some transitive dependencies and they also need to be addressed in `zeppelin-distribution/src/licence_bin/LICENSE`. @1ambda Could you take care of them if they're not already addressed in `zeppelin-distribution/src/licence_bin/LICENSE`?

          ```
          [INFO] +- org.pegdown:pegdown:jar:1.6.0:compile
          [INFO] | - org.parboiled:parboiled-java:jar:1.1.7:compile
          [INFO] | +- org.parboiled:parboiled-core:jar:1.1.7:compile
          [INFO] | +- org.ow2.asm:asm:jar:5.0.3:compile
          [INFO] | +- org.ow2.asm:asm-tree:jar:5.0.3:compile
          [INFO] | +- org.ow2.asm:asm-analysis:jar:5.0.3:compile
          [INFO] | - org.ow2.asm:asm-util:jar:5.0.3:compile
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1384 Thanks @1ambda for the improvement. Regarding license, 'markdown4j' section in the `zeppelin-distribution/src/licence_bin/LICENSE` should be removed while the library is no longer included in the binary package. Also `pegdown` library does have some transitive dependencies and they also need to be addressed in `zeppelin-distribution/src/licence_bin/LICENSE`. @1ambda Could you take care of them if they're not already addressed in `zeppelin-distribution/src/licence_bin/LICENSE`? ``` [INFO] +- org.pegdown:pegdown:jar:1.6.0:compile [INFO] | - org.parboiled:parboiled-java:jar:1.1.7:compile [INFO] | +- org.parboiled:parboiled-core:jar:1.1.7:compile [INFO] | +- org.ow2.asm:asm:jar:5.0.3:compile [INFO] | +- org.ow2.asm:asm-tree:jar:5.0.3:compile [INFO] | +- org.ow2.asm:asm-analysis:jar:5.0.3:compile [INFO] | - org.ow2.asm:asm-util:jar:5.0.3:compile ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @Leemoonsoo Thanks!

          I'v added missing transitive deps and removed unused markdown4j dep.

          I also found that `org.ow2.asm:asm:jar:3.0.1` is described in `zeppelin-distribution/src/licence_bin/LICENSE` But already denoted license is different version (3.0.1) compared to pegdown's dependency (5.0.3).

          Should I updated `org.ow2.asm:asm:jar:3.0.1` to `org.ow2.asm:asm:jar:5.0.3`?

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @Leemoonsoo Thanks! I'v added missing transitive deps and removed unused markdown4j dep. I also found that `org.ow2.asm:asm:jar:3.0.1` is described in `zeppelin-distribution/src/licence_bin/LICENSE` But already denoted license is different version (3.0.1) compared to pegdown's dependency (5.0.3). Should I updated `org.ow2.asm:asm:jar:3.0.1` to `org.ow2.asm:asm:jar:5.0.3`?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user felixcheung commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          MArkdown4j supports YUML and Websequence, does this support the same?

          Show
          githubbot ASF GitHub Bot added a comment - Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1384 MArkdown4j supports YUML and Websequence, does this support the same?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @felixcheung

          Pegdown doesn't support YUML, Websequence and Include plugins according to [Pegdown Extensions](https://github.com/sirthias/pegdown/blob/master/src/main/java/org/pegdown/Extensions.java)

          I think we have 2 options. (or more)

          1. Use markdown4j and implement [table plugins](https://github.com/jdcasey/markdown4j/blob/master/src/main/java/org/markdown4j/TablePlugin.java) correctly.

            • we might need small effort, but we will depend on markdown4j which is not actively developed.
            • and other markdown syntaxes might be implemented if necessary.

          2. Use pegdown and implement [YUML](https://github.com/billy1380/markdown4j-gwt/blob/master/src/main/java/org/markdown4j/YumlPlugin.java), [Websequence](https://github.com/jdcasey/markdown4j/blob/master/src/main/java/org/markdown4j/WebSequencePlugin.java).

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @felixcheung Pegdown doesn't support YUML, Websequence and Include plugins according to [Pegdown Extensions] ( https://github.com/sirthias/pegdown/blob/master/src/main/java/org/pegdown/Extensions.java ) I think we have 2 options. (or more) 1. Use markdown4j and implement [table plugins] ( https://github.com/jdcasey/markdown4j/blob/master/src/main/java/org/markdown4j/TablePlugin.java ) correctly. we might need small effort, but we will depend on markdown4j which is not actively developed. and other markdown syntaxes might be implemented if necessary. 2. Use pegdown and implement [YUML] ( https://github.com/billy1380/markdown4j-gwt/blob/master/src/main/java/org/markdown4j/YumlPlugin.java ), [Websequence] ( https://github.com/jdcasey/markdown4j/blob/master/src/main/java/org/markdown4j/WebSequencePlugin.java ).
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @AhyoungRyu In regard to table style,

          Using CSS (e.g [github-markdown-css](https://github.com/sindresorhus/github-markdown-css)) would be better solution rather than adding inline style to DOMs such as`table`, `thead`, `tbody`, `tr`, `td` while parsing.

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @AhyoungRyu In regard to table style, Using CSS (e.g [github-markdown-css] ( https://github.com/sindresorhus/github-markdown-css )) would be better solution rather than adding inline style to DOMs such as`table`, `thead`, `tbody`, `tr`, `td` while parsing.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          Now markdown table looks like

          <img width="338" alt="screen shot 2016-09-01 at 3 03 02 am" src="https://cloud.githubusercontent.com/assets/4968473/18141148/54414ab6-6ff3-11e6-897d-94dab08e6516.png">

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 Now markdown table looks like <img width="338" alt="screen shot 2016-09-01 at 3 03 02 am" src="https://cloud.githubusercontent.com/assets/4968473/18141148/54414ab6-6ff3-11e6-897d-94dab08e6516.png">
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user felixcheung commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          Personally YUML and Websequence is very handy - I use them quite a bit.
          What do other think about this?

          Show
          githubbot ASF GitHub Bot added a comment - Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1384 Personally YUML and Websequence is very handy - I use them quite a bit. What do other think about this?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @1ambda Yeah it's good idea to apply github markdown style to Zeppelin. I tested again and it works well. Definitely better than before!

          But I found little bit wired behavior when I made a title.

          ```

            1. This is second level title
              1. This is third level title
                ```

          This title code makes a link and it's connected to Zeppelin home. Is it intended?
          ![markdown_test](https://cloud.githubusercontent.com/assets/10060731/18164413/ad36f698-707a-11e6-91ad-3639a5f1dd7f.gif)

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1384 @1ambda Yeah it's good idea to apply github markdown style to Zeppelin. I tested again and it works well. Definitely better than before! But I found little bit wired behavior when I made a title. ``` This is second level title This is third level title ``` This title code makes a link and it's connected to Zeppelin home. Is it intended? ! [markdown_test] ( https://cloud.githubusercontent.com/assets/10060731/18164413/ad36f698-707a-11e6-91ad-3639a5f1dd7f.gif )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @AhyoungRyu

          It was due to the `ANCHORLINK` option in pegdown. I removed it.

          ![markdown gif](https://cloud.githubusercontent.com/assets/4968473/18173464/a18a4d66-70a4-11e6-95b7-7d030e93cf2b.gif)

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @AhyoungRyu It was due to the `ANCHORLINK` option in pegdown. I removed it. ! [markdown gif] ( https://cloud.githubusercontent.com/assets/4968473/18173464/a18a4d66-70a4-11e6-95b7-7d030e93cf2b.gif )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          Regarding @felixcheung's comment,

          I think keeping backward compatibility is always very important.
          If i add more possible options after @1ambda 's

          • Create new interpreter %pd that uses pegdown and restore %md to use markdown4j
          • Add a interpreter property that selects markdown library pegdown/markdown4j.
          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1384 Regarding @felixcheung's comment, I think keeping backward compatibility is always very important. If i add more possible options after @1ambda 's Create new interpreter %pd that uses pegdown and restore %md to use markdown4j Add a interpreter property that selects markdown library pegdown/markdown4j.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @1ambda Yeah tested again and it looks goodπŸ‘ Thanks!
          (One more thing: [Zeppelin's Java block indentation size](https://google.github.io/styleguide/javaguide.html#s4.2-block-indentation) is `2 spaces` )

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1384 @1ambda Yeah tested again and it looks goodπŸ‘ Thanks! (One more thing: [Zeppelin's Java block indentation size] ( https://google.github.io/styleguide/javaguide.html#s4.2-block-indentation ) is `2 spaces` )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @Leemoonsoo

          I think *option 2* (Adding a property) is a better solution. because

          1) Adding a new interpreter just for support another markdown parser might be confusing to users
          2) Pegdown parser will be able to replace markdown4j parser soon if we implement YUML and Websequence. At that time, we can just modify the parser property of `md` interpreter instead of requesting for users to change their interpreter type

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @Leemoonsoo I think * option 2 * (Adding a property) is a better solution. because 1) Adding a new interpreter just for support another markdown parser might be confusing to users 2) Pegdown parser will be able to replace markdown4j parser soon if we implement YUML and Websequence. At that time, we can just modify the parser property of `md` interpreter instead of requesting for users to change their interpreter type
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          I'v restored markdown4j parser and add `markdown.parser.type` property to `md` group. Pegdown parser will be used only if user specify `pegdown` property value.

          <img width="516" alt="screen shot 2016-09-03 at 1 54 12 am" src="https://cloud.githubusercontent.com/assets/4968473/18211602/66b9cf9c-7179-11e6-8506-9ae6fcfbfe3b.png">

          One more question. It seems that `description` does't show even if i already provide in `markdown/src/main/resources/interpreter-setting.json` like

          ```json
          [
          {
          "group": "md",
          "name": "md",
          "className": "org.apache.zeppelin.markdown.MarkdownInterpreter",
          "properties": {
          "markdown.parser.type":

          { "envName": "MARKDOWN_PARSER_TYPE", "propertyName": "markdown.parser.type", "defaultValue": "markdown4j", "description": "Markdown Parser Type. Available values: markdown4j, pegdown. Default = markdown4j" }

          }
          }
          ]
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 I'v restored markdown4j parser and add `markdown.parser.type` property to `md` group. Pegdown parser will be used only if user specify `pegdown` property value. <img width="516" alt="screen shot 2016-09-03 at 1 54 12 am" src="https://cloud.githubusercontent.com/assets/4968473/18211602/66b9cf9c-7179-11e6-8506-9ae6fcfbfe3b.png"> One more question. It seems that `description` does't show even if i already provide in `markdown/src/main/resources/interpreter-setting.json` like ```json [ { "group": "md", "name": "md", "className": "org.apache.zeppelin.markdown.MarkdownInterpreter", "properties": { "markdown.parser.type": { "envName": "MARKDOWN_PARSER_TYPE", "propertyName": "markdown.parser.type", "defaultValue": "markdown4j", "description": "Markdown Parser Type. Available values: markdown4j, pegdown. Default = markdown4j" } } } ] ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @1ambda Great! It works well as expected πŸ‘

          If you want to add the interpreter property(`markdown.parser.type`) to the markdown interpreter, it would be better to provide that information via [Zeppelin markdown interpreter docs](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/markdown.html) with configuration table as like the other interpreters do. Nothing much needed. You can just add the below conf table to `markdown.md`.
          ```

            1. Configuration
              <table class="table-configuration">
              <tr>
              <th>Name</th>
              <th>Default Value</th>
              <th>Description</th>
              </tr>
              <tr>
              <td>markdown.parser.type</td>
              <td>markdown4j </td>
              <td>Markdown Parser Type. <br/> Available values: markdown4j, pegdown.</td>
              </tr>
              </table>
              ```

          Also the below sentences in [Overview section](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/markdown.html#overview) need to be updated accordingly.
          >Markdown is a plain text formatting syntax designed so that it can be converted to HTML. Apache Zeppelin uses markdown4j. For more examples and extension support, please checkout here.

          FYI, `markdown.md` file is under `ZEPPELIN_HOME/docs/interpreter/`

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1384 @1ambda Great! It works well as expected πŸ‘ If you want to add the interpreter property(`markdown.parser.type`) to the markdown interpreter, it would be better to provide that information via [Zeppelin markdown interpreter docs] ( https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/markdown.html ) with configuration table as like the other interpreters do. Nothing much needed. You can just add the below conf table to `markdown.md`. ``` Configuration <table class="table-configuration"> <tr> <th>Name</th> <th>Default Value</th> <th>Description</th> </tr> <tr> <td>markdown.parser.type</td> <td>markdown4j </td> <td>Markdown Parser Type. <br/> Available values: markdown4j, pegdown.</td> </tr> </table> ``` Also the below sentences in [Overview section] ( https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/markdown.html#overview ) need to be updated accordingly. >Markdown is a plain text formatting syntax designed so that it can be converted to HTML. Apache Zeppelin uses markdown4j. For more examples and extension support, please checkout here. FYI, `markdown.md` file is under `ZEPPELIN_HOME/docs/interpreter/`
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @AhyoungRyu Thanks for for your review and comments

          I'v updated docs and added missing license declaration in some java files.

          Now docs/markdown looks like

          <img width="791" alt="docs-markdown-update-1" src="https://cloud.githubusercontent.com/assets/4968473/18229076/06d5b834-72a5-11e6-994c-585def006adc.png">

          <img width="466" alt="docs-markdown-update-2" src="https://cloud.githubusercontent.com/assets/4968473/18229096/80ba7a22-72a5-11e6-8c8c-46a105e2bf96.png">

          <img width="539" alt="docs-markdown-update-3" src="https://cloud.githubusercontent.com/assets/4968473/18229083/0b7b6bcc-72a5-11e6-9688-c1f0238634c4.png">

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @AhyoungRyu Thanks for for your review and comments I'v updated docs and added missing license declaration in some java files. Now docs/markdown looks like <img width="791" alt="docs-markdown-update-1" src="https://cloud.githubusercontent.com/assets/4968473/18229076/06d5b834-72a5-11e6-994c-585def006adc.png"> <img width="466" alt="docs-markdown-update-2" src="https://cloud.githubusercontent.com/assets/4968473/18229096/80ba7a22-72a5-11e6-8c8c-46a105e2bf96.png"> <img width="539" alt="docs-markdown-update-3" src="https://cloud.githubusercontent.com/assets/4968473/18229083/0b7b6bcc-72a5-11e6-9688-c1f0238634c4.png">
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @1ambda Looks good! πŸ‘πŸ‘ for adding screenshot images.

          >It seems that description does't show even though i provide it to markdown/src/main/resources/interpreter-setting.json like

          yeah I also felt uncomfortable when create/edit a interpreter. There is no way to get information what these properties are working for. It would be better to add `description` column separately to the interpreter setting table I think. But it can be handled in the different PR

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1384 @1ambda Looks good! πŸ‘πŸ‘ for adding screenshot images. >It seems that description does't show even though i provide it to markdown/src/main/resources/interpreter-setting.json like yeah I also felt uncomfortable when create/edit a interpreter. There is no way to get information what these properties are working for. It would be better to add `description` column separately to the interpreter setting table I think. But it can be handled in the different PR
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @1ambda Usually to include external source css, we would use the `assets/styles` folder.

          However in this case, you can use bower to have it part of the build instead of the source code, by using `bower install --save github-markdown-css`

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1384 @1ambda Usually to include external source css, we would use the `assets/styles` folder. However in this case, you can use bower to have it part of the build instead of the source code, by using `bower install --save github-markdown-css`
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @corneadoug Thanks!

          I'v installed github markdown css and added it to `bower.json` using the command you provided.
          It is definitely better to use bower if possible

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @corneadoug Thanks! I'v installed github markdown css and added it to `bower.json` using the command you provided. It is definitely better to use bower if possible
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @Leemoonsoo @felixcheung Are we good on that PR?
          CI is failing on tests, not related to this PR as its happening to other PRs.
          But would be better to merge this one after CI is fixed

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1384 @Leemoonsoo @felixcheung Are we good on that PR? CI is failing on tests, not related to this PR as its happening to other PRs. But would be better to merge this one after CI is fixed
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user felixcheung commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          looks fine to me, I'd defer to others on licensing. thanks for the great contribution!

          Show
          githubbot ASF GitHub Bot added a comment - Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1384 looks fine to me, I'd defer to others on licensing. thanks for the great contribution!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          Because now github-markdown-css is downloaded on build time instead of packed in the source tree, related license now need to moved back to under bin_licenses.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1384 Because now github-markdown-css is downloaded on build time instead of packed in the source tree, related license now need to moved back to under bin_licenses.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bzz commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @1ambda πŸ‘ fot tests, looks great to me except for licensing issue raised by Moon and small comment above.

          If you could let me know you user name in ASF JIRA I'll be happy to help assigning ZEPPELIN-1387 to you.

          Show
          githubbot ASF GitHub Bot added a comment - Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1384 @1ambda πŸ‘ fot tests, looks great to me except for licensing issue raised by Moon and small comment above. If you could let me know you user name in ASF JIRA I'll be happy to help assigning ZEPPELIN-1387 to you.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @Leemoonsoo I'v fixed license description. Also, now I understand when to describe licenses to `licenses` or `bin_licenses`. Thanks.

          @bzz I think it is better to use more specific exception types in catch block as you pointed out. Could you review e08929a again?

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @Leemoonsoo I'v fixed license description. Also, now I understand when to describe licenses to `licenses` or `bin_licenses`. Thanks. @bzz I think it is better to use more specific exception types in catch block as you pointed out. Could you review e08929a again?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          Thanks @1ambda. Looks great to me.
          Merge if there're no further discussions.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1384 Thanks @1ambda. Looks great to me. Merge if there're no further discussions.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @1ambda Sadly the conflict needs to be resolved first before merging. But only for `docs/interpreter/markdown.md` this file

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1384 @1ambda Sadly the conflict needs to be resolved first before merging. But only for `docs/interpreter/markdown.md` this file
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @AhyoungRyu

          I'v resolved the merge conflict with 8f344db. Could you try again?

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @AhyoungRyu I'v resolved the merge conflict with 8f344db. Could you try again?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          <img width="1094" alt="screen shot 2016-09-21 at 1 39 41 am" src="https://cloud.githubusercontent.com/assets/4968473/18679870/5ae08dec-7f9c-11e6-8c61-91e87bad5ed9.png">

          CI is failing on only the last job.

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 <img width="1094" alt="screen shot 2016-09-21 at 1 39 41 am" src="https://cloud.githubusercontent.com/assets/4968473/18679870/5ae08dec-7f9c-11e6-8c61-91e87bad5ed9.png"> CI is failing on only the last job.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @1ambda Yeah tested locally and looks good. Thanks for your quick response! Now it's really ready to be merged I think πŸ‘
          The other PRs' CI are failing in Selenium test because of the same reason. Currently it's tracked in ZEPPELIN-1449(https://issues.apache.org/jira/browse/ZEPPELIN-1449).

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1384 @1ambda Yeah tested locally and looks good. Thanks for your quick response! Now it's really ready to be merged I think πŸ‘ The other PRs' CI are failing in Selenium test because of the same reason. Currently it's tracked in ZEPPELIN-1449 ( https://issues.apache.org/jira/browse/ZEPPELIN-1449 ).
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          That CI failure is being handled in #1444, you should be able to rebase and have a green CI soon

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1384 That CI failure is being handled in #1444, you should be able to rebase and have a green CI soon
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          @1ambda You can rebase now

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1384 @1ambda You can rebase now
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          Now CI is failing on the third build job.

          I checked out `zeppelin/master` and merged it on `1ambda/fix-zeppelin-1387`.
          Should I have use git `rebase` command instead? I thought using `rebase` command will overwrite
          this PR history (comments, etc...)

          <img width="1080" alt="screen shot 2016-09-21 at 11 00 10 am" src="https://cloud.githubusercontent.com/assets/4968473/18695206/2afb0c0c-7feb-11e6-8d94-119a456876a0.png">
          <img width="1100" alt="screen shot 2016-09-21 at 11 00 26 am" src="https://cloud.githubusercontent.com/assets/4968473/18695207/2cd2ce8e-7feb-11e6-961d-5292d58513cf.png">

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 Now CI is failing on the third build job. I checked out `zeppelin/master` and merged it on `1ambda/fix-zeppelin-1387`. Should I have use git `rebase` command instead? I thought using `rebase` command will overwrite this PR history (comments, etc...) <img width="1080" alt="screen shot 2016-09-21 at 11 00 10 am" src="https://cloud.githubusercontent.com/assets/4968473/18695206/2afb0c0c-7feb-11e6-8d94-119a456876a0.png"> <img width="1100" alt="screen shot 2016-09-21 at 11 00 26 am" src="https://cloud.githubusercontent.com/assets/4968473/18695207/2cd2ce8e-7feb-11e6-961d-5292d58513cf.png">
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          Close PR to re-trigger CI

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 Close PR to re-trigger CI
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda closed the pull request at:

          https://github.com/apache/zeppelin/pull/1384

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1384
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          Open PR to re-trigger CI

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 Open PR to re-trigger CI
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user 1ambda reopened a pull request:

          https://github.com/apache/zeppelin/pull/1384

          ZEPPELIN-1387 Support table syntax in markdown interpreter

              1. What is this PR for?

          Support table markdown syntax issued by ZEPPELIN-1387(https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN)

              1. What type of PR is it?
                [Bug Fix | Improvement]

          This PR can be categorized as bug fix and improvement since it not only resolves the above issue but also support other markdown syntaxes.

              1. Todos
              1. What is the Jira issue?

          ZEPPELIN-1387(https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN)

              1. How should this be tested?

          Write markdown texts and compare them with expected html DOMs. I'v also included some tests for this PR.

              1. Screenshots (if appropriate)

          <img width="708" alt="markdown" src="https://cloud.githubusercontent.com/assets/4968473/18061274/1f2be526-6e5d-11e6-9f1a-3528f3958d2c.png">

              1. Questions:
          • Does the licenses files need update?
          • Does coding style is appropriate?
              1. Additional Comments

          We might solve this issue by implementing custom table plugin for markdown4j by referring [the existing work of txtmark](https://github.com/zhenchuan/txtmark/commit/178486805e78e3d572b071ca8b9f8887a066edef).
          But I think it is not good idea in regard to coverage, maintainability and efficiency since markdown4j is currently not developed actively and it costs to implement all markdown plugins which is not supported by markdown4j.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/1ambda/zeppelin fix-zeppelin-1387

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1384.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1384


          commit 029f550a04721c786b1d0021ac9551f2a6e62aed
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-08-29T17:44:21Z

          ZEPPELIN-1387 Support table in markdown interpreter

          commit fa14b3ed75c051ad6da0e3955ef8debf4d231b13
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-08-30T15:44:13Z

          style: Apply google java code style guide

          commit 7aecdcb536a7561fb67f2e1404d4bcb3921774da
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-08-30T15:55:47Z

          chore: Add pegdown to the binary license list

          commit 603d3db4068f1eed5a8647489da80c945ac23cfb
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-08-31T04:18:25Z

          fix: Add missing transitive deps for pegdown

          commit f7419492adde2ad0d71e8f189b3a4ace9a80a9a8
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-08-31T18:19:20Z

          fix: Add styles for markdown

          commit 9cf31d0bbc9db4b8be2ab1e1ca62b72c7d596cca
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-01T14:25:26Z

          fix: Use markdown-body class (default)

          commit c33c71590ae8dd5fbe09091d95d6f81614bf3e43
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-01T15:28:24Z

          fix: Remove the ANCHORLINKS option

          • added some markdown syntax tests

          commit 55a2f1025483b8be705bfd94734c968a6acfa9ce
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-02T14:24:35Z

          fix: Add MarkdownParser interface to support mulitple parsers

          commit bf9100de31fb630ea19c61eda0f9b89f8382dd20
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-02T14:25:03Z

          chore: Restore markdown4j dependency

          commit d2d4455118191dfc89fc789dfefecfccc4c210cb
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-02T14:28:50Z

          style: Reformat using intellij-java-google-style

          commit 2b6516cad31b08d12d0f2e76d3bca3a1c8209eb7
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-02T16:49:06Z

          feat: Support markdown.parser.type attr in md

          commit d228423d636c2d7d9ca4d8c7b7c211433c5c0706
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-04T04:33:49Z

          docs: Update markdown docs config, examples

          commit 947a92acf7cfef8744b28ae65695410a28179b52
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-04T04:36:23Z

          chore: Add license to newly created java files

          commit 297733f196aac4f0cec1077b8d6ec7a5deb09220
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-04T14:10:37Z

          fix: Modify github-markdown-css license

          • move the license file from `bin_license/` to `license/`
          • extract source code from `interpreter.css` to clarify
          • add css description to `markdown.css` like `font-awesome.min.css`

          commit 85a5e3ac8cac3e98d1f71413ddf47b57150d1dd7
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-05T08:15:28Z

          fix: Use bower to install github-markdown-css

          commit 4d1cb3cb989cc1ef31fef9f0bca6f5a5f9fb0355
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-05T14:32:40Z

          fix: Typo in docs/interpreter/markdown.md

          commit 8b1e0170aa0964c26656aa126a67f417b78678bd
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-07T15:17:33Z

          chore: Move github-markdown-css license to bin_licenses

          commit e08929a093f6b85df2a7f2137cda2dc205433512
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-07T15:24:49Z

          fix: Handle more specific exception in catch block

          commit e6d41c8a92d27ca87ee83f4c5479c848d59c45e0
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-20T15:23:27Z

          fix: Resolve merge conflict with 8f344db

          commit 16cda72ca3f36f10238bbfc2d578f6e1469fc728
          Author: 1ambda <1amb4a@gmail.com>
          Date: 2016-09-21T01:20:58Z

          fix: Merge with 3c8158 to resolve CI failure


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1384 ZEPPELIN-1387 Support table syntax in markdown interpreter What is this PR for? Support table markdown syntax issued by ZEPPELIN-1387 ( https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN ) What type of PR is it? [Bug Fix | Improvement] This PR can be categorized as bug fix and improvement since it not only resolves the above issue but also support other markdown syntaxes. Todos [ ] - Check the license issue of the [pegdown] ( https://github.com/sirthias/pegdown ) library introduced by this PR What is the Jira issue? ZEPPELIN-1387 ( https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN ) How should this be tested? Write markdown texts and compare them with expected html DOMs. I'v also included some tests for this PR. Screenshots (if appropriate) <img width="708" alt="markdown" src="https://cloud.githubusercontent.com/assets/4968473/18061274/1f2be526-6e5d-11e6-9f1a-3528f3958d2c.png"> Questions: Does the licenses files need update? Does coding style is appropriate? Additional Comments We might solve this issue by implementing custom table plugin for markdown4j by referring [the existing work of txtmark] ( https://github.com/zhenchuan/txtmark/commit/178486805e78e3d572b071ca8b9f8887a066edef ). But I think it is not good idea in regard to coverage, maintainability and efficiency since markdown4j is currently not developed actively and it costs to implement all markdown plugins which is not supported by markdown4j. You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin fix-zeppelin-1387 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1384.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1384 commit 029f550a04721c786b1d0021ac9551f2a6e62aed Author: 1ambda <1amb4a@gmail.com> Date: 2016-08-29T17:44:21Z ZEPPELIN-1387 Support table in markdown interpreter commit fa14b3ed75c051ad6da0e3955ef8debf4d231b13 Author: 1ambda <1amb4a@gmail.com> Date: 2016-08-30T15:44:13Z style: Apply google java code style guide commit 7aecdcb536a7561fb67f2e1404d4bcb3921774da Author: 1ambda <1amb4a@gmail.com> Date: 2016-08-30T15:55:47Z chore: Add pegdown to the binary license list commit 603d3db4068f1eed5a8647489da80c945ac23cfb Author: 1ambda <1amb4a@gmail.com> Date: 2016-08-31T04:18:25Z fix: Add missing transitive deps for pegdown commit f7419492adde2ad0d71e8f189b3a4ace9a80a9a8 Author: 1ambda <1amb4a@gmail.com> Date: 2016-08-31T18:19:20Z fix: Add styles for markdown Wrap parsed DOM with div which has `markdown` class attr Style them with github flavored markdown style ( [github-markdown-css] ( https://github.com/sindresorhus/github-markdown-css )) add [github-markdown-css] ( https://github.com/sindresorhus/github-markdown-css ) license to `zeppelin-distribution` commit 9cf31d0bbc9db4b8be2ab1e1ca62b72c7d596cca Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-01T14:25:26Z fix: Use markdown-body class (default) commit c33c71590ae8dd5fbe09091d95d6f81614bf3e43 Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-01T15:28:24Z fix: Remove the ANCHORLINKS option added some markdown syntax tests commit 55a2f1025483b8be705bfd94734c968a6acfa9ce Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-02T14:24:35Z fix: Add MarkdownParser interface to support mulitple parsers commit bf9100de31fb630ea19c61eda0f9b89f8382dd20 Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-02T14:25:03Z chore: Restore markdown4j dependency commit d2d4455118191dfc89fc789dfefecfccc4c210cb Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-02T14:28:50Z style: Reformat using intellij-java-google-style commit 2b6516cad31b08d12d0f2e76d3bca3a1c8209eb7 Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-02T16:49:06Z feat: Support markdown.parser.type attr in md commit d228423d636c2d7d9ca4d8c7b7c211433c5c0706 Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-04T04:33:49Z docs: Update markdown docs config, examples commit 947a92acf7cfef8744b28ae65695410a28179b52 Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-04T04:36:23Z chore: Add license to newly created java files commit 297733f196aac4f0cec1077b8d6ec7a5deb09220 Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-04T14:10:37Z fix: Modify github-markdown-css license move the license file from `bin_license/` to `license/` extract source code from `interpreter.css` to clarify add css description to `markdown.css` like `font-awesome.min.css` commit 85a5e3ac8cac3e98d1f71413ddf47b57150d1dd7 Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-05T08:15:28Z fix: Use bower to install github-markdown-css commit 4d1cb3cb989cc1ef31fef9f0bca6f5a5f9fb0355 Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-05T14:32:40Z fix: Typo in docs/interpreter/markdown.md commit 8b1e0170aa0964c26656aa126a67f417b78678bd Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-07T15:17:33Z chore: Move github-markdown-css license to bin_licenses commit e08929a093f6b85df2a7f2137cda2dc205433512 Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-07T15:24:49Z fix: Handle more specific exception in catch block commit e6d41c8a92d27ca87ee83f4c5479c848d59c45e0 Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-20T15:23:27Z fix: Resolve merge conflict with 8f344db commit 16cda72ca3f36f10238bbfc2d578f6e1469fc728 Author: 1ambda <1amb4a@gmail.com> Date: 2016-09-21T01:20:58Z fix: Merge with 3c8158 to resolve CI failure
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          Usually we prefer rebase since it doesn't pollute the commit history. But its fine, the end result is the same. We sometimes have flaky tests, I will check once the build is finished

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1384 Usually we prefer rebase since it doesn't pollute the commit history. But its fine, the end result is the same. We sometimes have flaky tests, I will check once the build is finished
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          Finally, CI is green!

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 Finally, CI is green!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1384

          Awesome, Merging if there is no more discussions

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1384 Awesome, Merging if there is no more discussions
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/1384

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1384

            People

            • Assignee:
              1ambda Hoon Park
              Reporter:
              francois.rosiere@gmail.com François Rosière
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development