Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-1371

Add flexible text/numeric conversion dropdown menu on table display

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7.0
    • Fix Version/s: 0.7.0
    • Component/s: front-end, GUI
    • Labels:
    • Flags:
      Patch

      Description

      We people in Twitter have great demand of adding a flexible dropdown menu for the columns in the tables which enables the text/numeric conversion.
      This is because people want some columns to be of string type which, for example, fits to the underlying DB definition.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Peilin-Yang opened a pull request:

          https://github.com/apache/zeppelin/pull/1363

          ZEPPELIN-1371add text/numeric conversion support to table display

              1. What is this PR for?
                We people in Twitter have great demand of adding a flexible drop down menu for the columns in the tables which enables the text/numeric conversion.
                This is because people want some columns to be of string type which, for example, fits to the underlying DB definition.
              1. What type of PR is it?
                [Improvement | Feature]
              1. Todos
              1. What is the Jira issue?
                https://issues.apache.org/jira/browse/ZEPPELIN-1371
              1. How should this be tested?

          1. Click on the dropdown menu would convert the text/number of that column.
          2. Other functionalities esp. the sorting function should not be affected.

              1. Screenshots (if appropriate)
                https://drive.google.com/a/twitter.com/file/d/0B9QN74Rceec8djV6UXpUeFNyUWM/view?ts=57bf2c11
              1. Questions:
          • Does the licenses files need update? No
          • Is there breaking changes for older versions? Probably a noticeable change in UI
          • Does this needs documentation? No

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Peilin-Yang/zeppelin ypeilin/table_num_cell_format

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1363.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1363


          commit b92e92ff8821a58c47d7510818ec518414499c83
          Author: Peilin Yang <peiliny@twitter.com>
          Date: 2016-08-25T17:06:23Z

          add text/numeric conversion support to table display


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Peilin-Yang opened a pull request: https://github.com/apache/zeppelin/pull/1363 ZEPPELIN-1371 add text/numeric conversion support to table display What is this PR for? We people in Twitter have great demand of adding a flexible drop down menu for the columns in the tables which enables the text/numeric conversion. This is because people want some columns to be of string type which, for example, fits to the underlying DB definition. What type of PR is it? [Improvement | Feature] Todos What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1371 How should this be tested? 1. Click on the dropdown menu would convert the text/number of that column. 2. Other functionalities esp. the sorting function should not be affected. Screenshots (if appropriate) https://drive.google.com/a/twitter.com/file/d/0B9QN74Rceec8djV6UXpUeFNyUWM/view?ts=57bf2c11 Questions: Does the licenses files need update? No Is there breaking changes for older versions? Probably a noticeable change in UI Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/Peilin-Yang/zeppelin ypeilin/table_num_cell_format Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1363.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1363 commit b92e92ff8821a58c47d7510818ec518414499c83 Author: Peilin Yang <peiliny@twitter.com> Date: 2016-08-25T17:06:23Z add text/numeric conversion support to table display
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang closed the pull request at:

          https://github.com/apache/zeppelin/pull/1363

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang closed the pull request at: https://github.com/apache/zeppelin/pull/1363
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Peilin-Yang reopened a pull request:

          https://github.com/apache/zeppelin/pull/1363

          ZEPPELIN-1371add text/numeric conversion support to table display

              1. What is this PR for?
                We people in Twitter have great demand of adding a flexible drop down menu for the columns in the tables which enables the text/numeric conversion.
                This is because people want some columns to be of string type which, for example, fits to the underlying DB definition.
              1. What type of PR is it?
                [Improvement | Feature]
              1. Todos
              1. What is the Jira issue?
                https://issues.apache.org/jira/browse/ZEPPELIN-1371
              1. How should this be tested?

          1. Click on the dropdown menu would convert the text/number of that column.
          2. Other functionalities esp. the sorting function should not be affected.

              1. Screenshots (if appropriate)
                https://drive.google.com/a/twitter.com/file/d/0B9QN74Rceec8djV6UXpUeFNyUWM/view?ts=57bf2c11
              1. Questions:
          • Does the licenses files need update? No
          • Is there breaking changes for older versions? Probably a noticeable change in UI
          • Does this needs documentation? No

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Peilin-Yang/zeppelin ypeilin/table_num_cell_format

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1363.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1363


          commit b92e92ff8821a58c47d7510818ec518414499c83
          Author: Peilin Yang <peiliny@twitter.com>
          Date: 2016-08-25T17:06:23Z

          add text/numeric conversion support to table display


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Peilin-Yang reopened a pull request: https://github.com/apache/zeppelin/pull/1363 ZEPPELIN-1371 add text/numeric conversion support to table display What is this PR for? We people in Twitter have great demand of adding a flexible drop down menu for the columns in the tables which enables the text/numeric conversion. This is because people want some columns to be of string type which, for example, fits to the underlying DB definition. What type of PR is it? [Improvement | Feature] Todos What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1371 How should this be tested? 1. Click on the dropdown menu would convert the text/number of that column. 2. Other functionalities esp. the sorting function should not be affected. Screenshots (if appropriate) https://drive.google.com/a/twitter.com/file/d/0B9QN74Rceec8djV6UXpUeFNyUWM/view?ts=57bf2c11 Questions: Does the licenses files need update? No Is there breaking changes for older versions? Probably a noticeable change in UI Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/Peilin-Yang/zeppelin ypeilin/table_num_cell_format Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1363.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1363 commit b92e92ff8821a58c47d7510818ec518414499c83 Author: Peilin Yang <peiliny@twitter.com> Date: 2016-08-25T17:06:23Z add text/numeric conversion support to table display
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          @Peilin-Yang Thanks for the contribution.
          Small tip: Instead of hosting your screenshot, you can drop the image directly in the input of the PR description and the image will be hosted by github and shown.

          Could you add more information on what is the benefit of changing the text/numeric conversion?
          There is no example on what is happening when you actually switch the type and why it is useful.

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1363 @Peilin-Yang Thanks for the contribution. Small tip: Instead of hosting your screenshot, you can drop the image directly in the input of the PR description and the image will be hosted by github and shown. Could you add more information on what is the benefit of changing the text/numeric conversion? There is no example on what is happening when you actually switch the type and why it is useful.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          @corneadoug thanks for your advice!
          I updated the contents of PR so that it includes the use cases of this change.
          Please let me know whether they make any sense.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1363 @corneadoug thanks for your advice! I updated the contents of PR so that it includes the use cases of this change. Please let me know whether they make any sense.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bzz commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          So cool - this should solve sorting issue for numeric columns! Thank you @Peilin-Yang!

          One question - do you guys think it could be possible to detect numeric columns automatically using some heuristics and apply proper renderer on table creation time, rather than make user choose?

          Show
          githubbot ASF GitHub Bot added a comment - Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1363 So cool - this should solve sorting issue for numeric columns! Thank you @Peilin-Yang! One question - do you guys think it could be possible to detect numeric columns automatically using some heuristics and apply proper renderer on table creation time, rather than make user choose?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          @bzz Actually I am currently look into that and I think it is possible because numbers are automatically detected and that is why the commas are inserted.
          But I think even we could have the initial sorting for numbers it is still nice to let the users change it on the fly.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1363 @bzz Actually I am currently look into that and I think it is possible because numbers are automatically detected and that is why the commas are inserted. But I think even we could have the initial sorting for numbers it is still nice to let the users change it on the fly.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bzz commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          Go it! It would be really nice to have such defaults for numbers, that make them sort numerically.

          As for letting user change it - it sounds good, am it looks like the main use case for it is basically, removing commas?

          Show
          githubbot ASF GitHub Bot added a comment - Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1363 Go it! It would be really nice to have such defaults for numbers, that make them sort numerically. As for letting user change it - it sounds good, am it looks like the main use case for it is basically, removing commas?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          Well, consider it alone, yes it is.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1363 Well, consider it alone, yes it is.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          Added another PR #1371 that may have impact on this one.
          i.e. if you guys think that one is reasonable then this one should be adjusted so that when user changes the datatype of the column the sorting order is changing at the same time.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1363 Added another PR #1371 that may have impact on this one. i.e. if you guys think that one is reasonable then this one should be adjusted so that when user changes the datatype of the column the sorting order is changing at the same time.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bzz commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          Let's merge #1371 first, and then it makes perfect sense to adjust this one to match user expectations of sorting changes according to column type (so it lets user override auto-detection).

          @corneadoug what do you think?

          Show
          githubbot ASF GitHub Bot added a comment - Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1363 Let's merge #1371 first, and then it makes perfect sense to adjust this one to match user expectations of sorting changes according to column type (so it lets user override auto-detection). @corneadoug what do you think?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          @bzz I agree

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1363 @bzz I agree
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          Let's try to rebase this one, and review it

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1363 Let's try to rebase this one, and review it
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          I made several changes for this commit:

          1. put the style from notebook.css to paragraph.css
          2. do not make any assumption/auto-detection of the original type of the data. Basically I drop the changes made in #1371
          3. now the data type is column based. I added the validators for numbers and dates. Cells that fail to be converted to the required type will be shown with red background.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1363 I made several changes for this commit: 1. put the style from notebook.css to paragraph.css 2. do not make any assumption/auto-detection of the original type of the data. Basically I drop the changes made in #1371 3. now the data type is column based. I added the validators for numbers and dates. Cells that fail to be converted to the required type will be shown with red background.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          @corneadoug can we get this reviewed?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1363 @corneadoug can we get this reviewed?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          @Peilin-Yang Thanks for the ping, I will look into that.
          Any specific reason to drop #1371?

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1363 @Peilin-Yang Thanks for the ping, I will look into that. Any specific reason to drop #1371?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          @corneadoug I just found that Handsontable has its intrinsic data type detection/conversion which we can rely on for the type conversion and is thus safer. More details at http://docs.handsontable.com/0.28.0/Options.html#type
          I think it is more convenient to this and make the data type on column basis so we do not worry about each individual cell.
          With the dropdown menu we provide users are more aware of the fact that the data type is based on column, not the cell.
          Does this make any sense?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1363 @corneadoug I just found that Handsontable has its intrinsic data type detection/conversion which we can rely on for the type conversion and is thus safer. More details at http://docs.handsontable.com/0.28.0/Options.html#type I think it is more convenient to this and make the data type on column basis so we do not worry about each individual cell. With the dropdown menu we provide users are more aware of the fact that the data type is based on column, not the cell. Does this make any sense?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          @Peilin-Yang I tested this PR and found one bug.

          • Change a column that wouldn't order properly to Numerical type (balance in bank table for example)
          • Order that column in descending order
          • Switch the graph type (let's say bar chart)
          • Switch Back to Table Viz
          • The previous column still has the Numerical type, however if you try ordering again, it won't order properly
          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1363 @Peilin-Yang I tested this PR and found one bug. Change a column that wouldn't order properly to Numerical type (balance in bank table for example) Order that column in descending order Switch the graph type (let's say bar chart) Switch Back to Table Viz The previous column still has the Numerical type, however if you try ordering again, it won't order properly
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          @corneadoug I have fixed the bug you mentioned. Testing was done and it seems ok.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1363 @corneadoug I have fixed the bug you mentioned. Testing was done and it seems ok.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          @corneadoug merged your PR.
          Do you think now it is the good time to merge this one?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1363 @corneadoug merged your PR. Do you think now it is the good time to merge this one?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          @Peilin-Yang Yes, you will need to rebase first though

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1363 @Peilin-Yang Yes, you will need to rebase first though
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          @corneadoug I have trouble with the rebase ... can you help a little bit?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1363 @corneadoug I have trouble with the rebase ... can you help a little bit?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          @Peilin-Yang Actually it's a bit hard for me to help since I can't rebase for you (Don't have the rights on your branch), but I can see that it is a pretty messy conflict you got.

          For the Rebase process, you need to do a:
          ```
          git fetch apache-github
          git rebase apache-github/master
          ```
          (apache-github being a remote for this official repo)

          At the first round of conflicts on `paragraph.controller.js`, I would advise to copy paste the file from master, and replace your local file with conflict with it.
          Then to copy paste the changes of your first commit into it (you can see the first commit diff [Here](https://github.com/apache/zeppelin/pull/1492/commits/b92e92ff8821a58c47d7510818ec518414499c83))

          After that first round, the other conflicts should be easier

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1363 @Peilin-Yang Actually it's a bit hard for me to help since I can't rebase for you (Don't have the rights on your branch), but I can see that it is a pretty messy conflict you got. For the Rebase process, you need to do a: ``` git fetch apache-github git rebase apache-github/master ``` (apache-github being a remote for this official repo) At the first round of conflicts on `paragraph.controller.js`, I would advise to copy paste the file from master, and replace your local file with conflict with it. Then to copy paste the changes of your first commit into it (you can see the first commit diff [Here] ( https://github.com/apache/zeppelin/pull/1492/commits/b92e92ff8821a58c47d7510818ec518414499c83 )) After that first round, the other conflicts should be easier
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang closed the pull request at:

          https://github.com/apache/zeppelin/pull/1363

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang closed the pull request at: https://github.com/apache/zeppelin/pull/1363
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Peilin-Yang opened a pull request:

          https://github.com/apache/zeppelin/pull/1500

          ZEPPELIN-1371add text/numeric conversion support to table display

              1. What is this PR for?
                We people in Twitter have great demand of adding a flexible drop down menu for the columns in the tables which enables the text/numeric conversion.
                This is because people want some columns to be of string type which, for example, fits to the underlying DB definition.
                The use cases of the change include:

          1. For now sorting on the columns is always lexicographically because Zeppelin front end treats the data as strings. It the values in the table can be convertible between string and number then we can sort the column by numeric values. I have filed another ticket for this: https://issues.apache.org/jira/browse/ZEPPELIN-1372
          2. Since the users know more about their data than us it would be nice if we let the users decide what is the real type of their data. It is annoying if user wants the column to be strings but the front end forcefully inserts commas in it. In some scenarios, users may also want to copy/paste the table to somewhere else. If people want to remove the commas before other actions then that will be a nightmare....

              1. What type of PR is it?
                [Improvement | Feature]
              1. Todos
          • [ ] - Task
              1. What is the Jira issue?
              1. How should this be tested?

          1. Click on the dropdown menu would convert the text/number of that column.
          2. Other functionalities esp. the sorting function should not be affected.

              1. Screenshots (if appropriate)
                ![image](https://cloud.githubusercontent.com/assets/3334391/18445617/76071f8e-78ec-11e6-93a6-fdcf7b85b6e9.png)
                ![image](https://cloud.githubusercontent.com/assets/3334391/18446601/16cff4f0-78f1-11e6-9fd6-4010b5d77f17.png)
              1. Questions:
          • Does the licenses files need update? No
          • Is there breaking changes for older versions? Probably a noticeable change in UI
          • Does this needs documentation? No

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Peilin-Yang/zeppelin ypeilin/table_num_cell_format

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1500.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1500


          commit 3f1d12078704c20b92f3845d0dced41e2c668a45
          Author: Peilin Yang <yangpeilyn@gmail.com>
          Date: 2016-10-10T16:35:04Z

          add dropdown menu applied on the latest branch


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Peilin-Yang opened a pull request: https://github.com/apache/zeppelin/pull/1500 ZEPPELIN-1371 add text/numeric conversion support to table display What is this PR for? We people in Twitter have great demand of adding a flexible drop down menu for the columns in the tables which enables the text/numeric conversion. This is because people want some columns to be of string type which, for example, fits to the underlying DB definition. The use cases of the change include: 1. For now sorting on the columns is always lexicographically because Zeppelin front end treats the data as strings. It the values in the table can be convertible between string and number then we can sort the column by numeric values. I have filed another ticket for this: https://issues.apache.org/jira/browse/ZEPPELIN-1372 2. Since the users know more about their data than us it would be nice if we let the users decide what is the real type of their data. It is annoying if user wants the column to be strings but the front end forcefully inserts commas in it. In some scenarios, users may also want to copy/paste the table to somewhere else. If people want to remove the commas before other actions then that will be a nightmare.... What type of PR is it? [Improvement | Feature] Todos [ ] - Task What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1371 How should this be tested? 1. Click on the dropdown menu would convert the text/number of that column. 2. Other functionalities esp. the sorting function should not be affected. Screenshots (if appropriate) ! [image] ( https://cloud.githubusercontent.com/assets/3334391/18445617/76071f8e-78ec-11e6-93a6-fdcf7b85b6e9.png ) ! [image] ( https://cloud.githubusercontent.com/assets/3334391/18446601/16cff4f0-78f1-11e6-9fd6-4010b5d77f17.png ) Questions: Does the licenses files need update? No Is there breaking changes for older versions? Probably a noticeable change in UI Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/Peilin-Yang/zeppelin ypeilin/table_num_cell_format Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1500.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1500 commit 3f1d12078704c20b92f3845d0dced41e2c668a45 Author: Peilin Yang <yangpeilyn@gmail.com> Date: 2016-10-10T16:35:04Z add dropdown menu applied on the latest branch
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @corneadoug It was really messy to rebase so I created this new PR. The previous one was closed.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1500 @corneadoug It was really messy to rebase so I created this new PR. The previous one was closed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @Peilin-Yang Selenium failure should now be fixed on Master, can you rebase?

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang Selenium failure should now be fixed on Master, can you rebase?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @corneadoug done

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1500 @corneadoug done
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @Peilin-Yang
          Have to fix a test, need to change the expected result in that test from `1,787` to `1787`
          ```
          Failed tests:
          SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of testSqlSpark result:
          Expected: "age\njob\nmarital\neducation\nbalance\n30 unemployed married primary 1,787"
          but: was "age\nâ–¼\njob\nâ–¼\nmarital\nâ–¼\neducation\nâ–¼\nbalance\nâ–¼\n30 unemployed married primary 1787"

          Tests run: 15, Failures: 1, Errors: 0, Skipped: 0
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang Have to fix a test, need to change the expected result in that test from `1,787` to `1787` ``` Failed tests: SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of testSqlSpark result: Expected: "age\njob\nmarital\neducation\nbalance\n30 unemployed married primary 1,787" but: was "age\nâ–¼\njob\nâ–¼\nmarital\nâ–¼\neducation\nâ–¼\nbalance\nâ–¼\n30 unemployed married primary 1787" Tests run: 15, Failures: 1, Errors: 0, Skipped: 0 ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @corneadoug I have changed the test case. Could you please review?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1500 @corneadoug I have changed the test case. Could you please review?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @Peilin-Yang The button we introduced in this PR, is breaking another test.
          Although the test looks funny, let's fix the expected result too

          ```
          Failed tests:
          SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of testSqlSpark result:
          Expected: "age\njob\nmarital\neducation\nbalance\n30 unemployed married primary 1787"
          but: was "age\nâ–¼\njob\nâ–¼\nmarital\nâ–¼\neducation\nâ–¼\nbalance\nâ–¼\n30 unemployed married primary 1787"
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang The button we introduced in this PR, is breaking another test. Although the test looks funny, let's fix the expected result too ``` Failed tests: SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of testSqlSpark result: Expected: "age\njob\nmarital\neducation\nbalance\n30 unemployed married primary 1787" but: was "age\nâ–¼\njob\nâ–¼\nmarital\nâ–¼\neducation\nâ–¼\nbalance\nâ–¼\n30 unemployed married primary 1787" ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @corneadoug It was very weird.
          Can you tell how to test?
          I have changed the numeric value 1,787 to 1787 but it seems that the failure is because of (maybe) some encoding/decoding at the first column.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1500 @corneadoug It was very weird. Can you tell how to test? I have changed the numeric value 1,787 to 1787 but it seems that the failure is because of (maybe) some encoding/decoding at the first column.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          Not really, there is no issue with the feature, the test itself is a bit weird because it transform to text whatever it find:
          https://github.com/apache/zeppelin/blob/b8755ebb25ad793daa6873acc2e00b8d69588188/zeppelin-server/src/test/java/org/apache/zeppelin/integration/SparkParagraphIT.java#L189

          Just need to change the expected value by adding that: `\nâ–¼` instead of `\n` in between the header column I guess

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 Not really, there is no issue with the feature, the test itself is a bit weird because it transform to text whatever it find: https://github.com/apache/zeppelin/blob/b8755ebb25ad793daa6873acc2e00b8d69588188/zeppelin-server/src/test/java/org/apache/zeppelin/integration/SparkParagraphIT.java#L189 Just need to change the expected value by adding that: `\nâ–¼` instead of `\n` in between the header column I guess
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @corneadoug updated

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1500 @corneadoug updated
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @Peilin-Yang Sorry that it takes so long, you will need to rebase

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang Sorry that it takes so long, you will need to rebase
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          Also there is still the selenium test error:
          ```
          Failed tests:
          SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of testSqlSpark result:
          Expected: "age\nâ–¼\njob\nâ–¼\nmarital\nâ–¼\neducation\nâ–¼\nbalance\nâ–¼\n30 unemployed married primary 1787"
          but: was "age\nâ–¼\njob\nâ–¼\nmarital\nâ–¼\neducation\nâ–¼\nbalance\nâ–¼\n30 unemployed married primary 1787"
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 Also there is still the selenium test error: ``` Failed tests: SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of testSqlSpark result: Expected: "age\nâ–¼\njob\nâ–¼\nmarital\nâ–¼\neducation\nâ–¼\nbalance\nâ–¼\n30 unemployed married primary 1787" but: was "age\n▼\njob\n▼\nmarital\n▼\neducation\n▼\nbalance\n▼\n30 unemployed married primary 1787" ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @corneadoug can you see whether it can pass the test now?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1500 @corneadoug can you see whether it can pass the test now?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          Current failure is really weird, can you try launching the CI again (close/re-open PR)?

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 Current failure is really weird, can you try launching the CI again (close/re-open PR)?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang closed the pull request at:

          https://github.com/apache/zeppelin/pull/1500

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang closed the pull request at: https://github.com/apache/zeppelin/pull/1500
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Peilin-Yang reopened a pull request:

          https://github.com/apache/zeppelin/pull/1500

          ZEPPELIN-1371add text/numeric conversion support to table display

              1. What is this PR for?
                We people in Twitter have great demand of adding a flexible drop down menu for the columns in the tables which enables the text/numeric conversion.
                This is because people want some columns to be of string type which, for example, fits to the underlying DB definition.
                The use cases of the change include:

          1. For now sorting on the columns is always lexicographically because Zeppelin front end treats the data as strings. It the values in the table can be convertible between string and number then we can sort the column by numeric values. I have filed another ticket for this: https://issues.apache.org/jira/browse/ZEPPELIN-1372
          2. Since the users know more about their data than us it would be nice if we let the users decide what is the real type of their data. It is annoying if user wants the column to be strings but the front end forcefully inserts commas in it. In some scenarios, users may also want to copy/paste the table to somewhere else. If people want to remove the commas before other actions then that will be a nightmare....

              1. What type of PR is it?
                [Improvement | Feature]
              1. Todos
          • [ ] - Task
              1. What is the Jira issue?
              1. How should this be tested?

          1. Click on the dropdown menu would convert the text/number of that column.
          2. Other functionalities esp. the sorting function should not be affected.

              1. Screenshots (if appropriate)
                ![image](https://cloud.githubusercontent.com/assets/3334391/18445617/76071f8e-78ec-11e6-93a6-fdcf7b85b6e9.png)
                ![image](https://cloud.githubusercontent.com/assets/3334391/18446601/16cff4f0-78f1-11e6-9fd6-4010b5d77f17.png)
              1. Questions:
          • Does the licenses files need update? No
          • Is there breaking changes for older versions? Probably a noticeable change in UI
          • Does this needs documentation? No

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Peilin-Yang/zeppelin ypeilin/table_num_cell_format

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1500.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1500


          commit e1ebfd34285a1ff68a345bedb83f830600dd62a5
          Author: Peilin Yang <yangpeilyn@gmail.com>
          Date: 2016-10-10T16:35:04Z

          add dropdown menu applied on the latest branch

          commit 7eb4f58d69a1dbc78191a981166508e464018d47
          Author: Peilin Yang <yangpeilyn@gmail.com>
          Date: 2016-10-13T10:30:42Z

          update the test case in SparkParagraphIT

          commit 2caf46e307eb6665aaddd3ef22c6e9aadaf7090e
          Author: Peilin Yang <yangpeilyn@gmail.com>
          Date: 2016-10-16T13:15:24Z

          update the test case

          commit 902fd900b141f4888f1a0c37db16ed5b2fba7890
          Author: Peilin Yang <yangpeilyn@gmail.com>
          Date: 2016-10-18T13:53:21Z

          update test case


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Peilin-Yang reopened a pull request: https://github.com/apache/zeppelin/pull/1500 ZEPPELIN-1371 add text/numeric conversion support to table display What is this PR for? We people in Twitter have great demand of adding a flexible drop down menu for the columns in the tables which enables the text/numeric conversion. This is because people want some columns to be of string type which, for example, fits to the underlying DB definition. The use cases of the change include: 1. For now sorting on the columns is always lexicographically because Zeppelin front end treats the data as strings. It the values in the table can be convertible between string and number then we can sort the column by numeric values. I have filed another ticket for this: https://issues.apache.org/jira/browse/ZEPPELIN-1372 2. Since the users know more about their data than us it would be nice if we let the users decide what is the real type of their data. It is annoying if user wants the column to be strings but the front end forcefully inserts commas in it. In some scenarios, users may also want to copy/paste the table to somewhere else. If people want to remove the commas before other actions then that will be a nightmare.... What type of PR is it? [Improvement | Feature] Todos [ ] - Task What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1371 How should this be tested? 1. Click on the dropdown menu would convert the text/number of that column. 2. Other functionalities esp. the sorting function should not be affected. Screenshots (if appropriate) ! [image] ( https://cloud.githubusercontent.com/assets/3334391/18445617/76071f8e-78ec-11e6-93a6-fdcf7b85b6e9.png ) ! [image] ( https://cloud.githubusercontent.com/assets/3334391/18446601/16cff4f0-78f1-11e6-9fd6-4010b5d77f17.png ) Questions: Does the licenses files need update? No Is there breaking changes for older versions? Probably a noticeable change in UI Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/Peilin-Yang/zeppelin ypeilin/table_num_cell_format Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1500.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1500 commit e1ebfd34285a1ff68a345bedb83f830600dd62a5 Author: Peilin Yang <yangpeilyn@gmail.com> Date: 2016-10-10T16:35:04Z add dropdown menu applied on the latest branch commit 7eb4f58d69a1dbc78191a981166508e464018d47 Author: Peilin Yang <yangpeilyn@gmail.com> Date: 2016-10-13T10:30:42Z update the test case in SparkParagraphIT commit 2caf46e307eb6665aaddd3ef22c6e9aadaf7090e Author: Peilin Yang <yangpeilyn@gmail.com> Date: 2016-10-16T13:15:24Z update the test case commit 902fd900b141f4888f1a0c37db16ed5b2fba7890 Author: Peilin Yang <yangpeilyn@gmail.com> Date: 2016-10-18T13:53:21Z update test case
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @corneadoug do you have chance to look at what is wrong with the commit? thx

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1500 @corneadoug do you have chance to look at what is wrong with the commit? thx
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @Peilin-Yang Sorry I just updated to Sierra and am having a few issues.
          From the log it seems there is some broken front-end tests (probably due to a rebase)
          You should be able to run it locally in zeppelin-web folder with `./grunt test`

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang Sorry I just updated to Sierra and am having a few issues. From the log it seems there is some broken front-end tests (probably due to a rebase) You should be able to run it locally in zeppelin-web folder with `./grunt test`
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @corneadoug I've tested using `./grunt test` and it passed the test. But CI check still failed.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1500 @corneadoug I've tested using `./grunt test` and it passed the test. But CI check still failed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user corneadoug commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @Peilin-Yang still the same test failing but asking for different value this time...
          ```
          Failed tests:
          SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of testSqlSpark result:
          Expected: "age\nâ–¼\njob\nâ–¼\nmarital\nâ–¼\neducation\nâ–¼\nbalance\nâ–¼\n30 unemployed married primary 1787"
          but: was "age\nâ–¼\njob\nâ–¼\nmarital\nâ–¼\neducation\nâ–¼\nbalance\nâ–¼\n30 unemployed married primary 1787"

          Tests run: 16, Failures: 1, Errors: 0, Skipped: 0
          ```

          I will see how we can change this test

          Show
          githubbot ASF GitHub Bot added a comment - Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang still the same test failing but asking for different value this time... ``` Failed tests: SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of testSqlSpark result: Expected: "age\nâ–¼\njob\nâ–¼\nmarital\nâ–¼\neducation\nâ–¼\nbalance\nâ–¼\n30 unemployed married primary 1787" but: was "age\n▼\njob\n▼\nmarital\n▼\neducation\n▼\nbalance\n▼\n30 unemployed married primary 1787" Tests run: 16, Failures: 1, Errors: 0, Skipped: 0 ``` I will see how we can change this test
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @corneadoug thanks, the error is really strange.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1500 @corneadoug thanks, the error is really strange.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bzz commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @Peilin-Yang I think it's very useful feature - do you think you will have some time to rebase and see if that helps? Just FIY - frontend tests got moved under `npm run test`

          Show
          githubbot ASF GitHub Bot added a comment - Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang I think it's very useful feature - do you think you will have some time to rebase and see if that helps? Just FIY - frontend tests got moved under `npm run test`
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @bzz done

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1500 @bzz done
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @bzz able to merge?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1500 @bzz able to merge?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bzz commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @Peilin-Yang CI is green now, awesome, thank you!
          Sorry for sloppy reply, let me try it.

          \cc @felizbear for a quick review as well

          Show
          githubbot ASF GitHub Bot added a comment - Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang CI is green now, awesome, thank you! Sorry for sloppy reply, let me try it. \cc @felizbear for a quick review as well
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user felizbear commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @Peilin-Yang a quick question: for some reason, when setting `value` to date type i get this

          <img width="574" alt="screen shot 2016-11-30 at 2 02 08 pm" src="https://cloud.githubusercontent.com/assets/5688346/20740396/03b9b9f2-b706-11e6-933c-9c963d6c6134.png">

          it looks somewhat inconsistent to me, but maybe i don't understand something

          Show
          githubbot ASF GitHub Bot added a comment - Github user felizbear commented on the issue: https://github.com/apache/zeppelin/pull/1500 @Peilin-Yang a quick question: for some reason, when setting `value` to date type i get this <img width="574" alt="screen shot 2016-11-30 at 2 02 08 pm" src="https://cloud.githubusercontent.com/assets/5688346/20740396/03b9b9f2-b706-11e6-933c-9c963d6c6134.png"> it looks somewhat inconsistent to me, but maybe i don't understand something
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Peilin-Yang commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          @felizbear
          The code of this PR uses `momentjs` to parse the string to date.
          Specifically, http://momentjs.com/docs/#/parsing/string/
          Integers are not of ISO8601 format so javascript's native method `Date` is called to parse the string.
          More details can be found at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/parse
          In your example, integer strings smaller than 13 are parsed as `nn/01/2001` and `44` is parsed as `01/01/2044`.
          To be honest I am also confusing why `23` and `24` are not parsed but it is definitely related to how `Date` parses them.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Peilin-Yang commented on the issue: https://github.com/apache/zeppelin/pull/1500 @felizbear The code of this PR uses `momentjs` to parse the string to date. Specifically, http://momentjs.com/docs/#/parsing/string/ Integers are not of ISO8601 format so javascript's native method `Date` is called to parse the string. More details can be found at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/parse In your example, integer strings smaller than 13 are parsed as `nn/01/2001` and `44` is parsed as `01/01/2044`. To be honest I am also confusing why `23` and `24` are not parsed but it is definitely related to how `Date` parses them.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bzz commented on the issue:

          https://github.com/apache/zeppelin/pull/1500

          Looks great to me and CI is green.

          Thank you @Peilin-Yang for prompt responce and @felizbear for reviews!

          Merging to master, if there is no further discussion.

          Show
          githubbot ASF GitHub Bot added a comment - Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1500 Looks great to me and CI is green. Thank you @Peilin-Yang for prompt responce and @felizbear for reviews! Merging to master, if there is no further discussion.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/1500

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1500
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user karuppayya commented on the issue:

          https://github.com/apache/zeppelin/pull/1363

          @Peilin-Yang Very useful feature!!
          let me know if i can help in taking this PR forward

          Show
          githubbot ASF GitHub Bot added a comment - Github user karuppayya commented on the issue: https://github.com/apache/zeppelin/pull/1363 @Peilin-Yang Very useful feature!! let me know if i can help in taking this PR forward

            People

            • Assignee:
              ypeilin Peilin Yang
              Reporter:
              ypeilin Peilin Yang
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 48h
                48h
                Remaining:
                Remaining Estimate - 48h
                48h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development