Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-1061

Select default interpreter while creating note

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.6, 0.6.0
    • Fix Version/s: 0.7.0
    • Labels:
      None

      Description

      When user create note in Zeppelin, default interpreter will be determined by system. This feature enables users to choose default interpreter when they create note

        Issue Links

          Activity

          Hide
          kavinkumarks Kavin Kumar added a comment -

          Jongyoul Lee I am planning to work on this.Please let me know if you have any concerns.

          Thanks,
          Kavin
          MailTo: kavin.kumar@imaginea.com

          Show
          kavinkumarks Kavin Kumar added a comment - Jongyoul Lee I am planning to work on this.Please let me know if you have any concerns. Thanks, Kavin MailTo: kavin.kumar@imaginea.com
          Hide
          kavinkumarks Kavin Kumar added a comment -

          Looked into the codebase and here are the list of changes need to be done for this:

          • Update create notebook flow to list down the list of interpreter setting names.
          • User can choose the setting name in addition to the notebook name and there will be a default value selected in the drop down.
          • On cloning the notebook, ensure that the default interpreter is set.
          • Ensure on running a paragraph, the default interpreter is used when there is no interpreter specified.
          • Update the interpreter binding section to show the default interpreter and update the current text about the default interpreter shown above the list of interpreters.

          Open questions:

          • Should we allow the user to unbind the default interpreter? I think that we shouldn't allow it.
          • If we allow the above, can we use the default interpreter on running the paragraph when there is no interpreter specified?

          Please let me know if I am missing anything else.

          Thanks,
          Kavin
          MailTo: kavin.kumar@imaginea.com

          Show
          kavinkumarks Kavin Kumar added a comment - Looked into the codebase and here are the list of changes need to be done for this: Update create notebook flow to list down the list of interpreter setting names. User can choose the setting name in addition to the notebook name and there will be a default value selected in the drop down. On cloning the notebook, ensure that the default interpreter is set. Ensure on running a paragraph, the default interpreter is used when there is no interpreter specified. Update the interpreter binding section to show the default interpreter and update the current text about the default interpreter shown above the list of interpreters. Open questions: Should we allow the user to unbind the default interpreter? I think that we shouldn't allow it. If we allow the above, can we use the default interpreter on running the paragraph when there is no interpreter specified? Please let me know if I am missing anything else. Thanks, Kavin MailTo: kavin.kumar@imaginea.com
          Hide
          jongyoul Jongyoul Lee added a comment -

          Kavin Kumar I'm really happy of you to do it

          Show
          jongyoul Jongyoul Lee added a comment - Kavin Kumar I'm really happy of you to do it
          Hide
          kavinkumarks Kavin Kumar added a comment -

          Thanks!

          -Kavin

          Show
          kavinkumarks Kavin Kumar added a comment - Thanks! -Kavin
          Hide
          kavinkumarks Kavin Kumar added a comment -

          Guys, any updates on the open questions?

          Thanks,
          Kavin
          MailTo: kavin.kumar@imaginea.com

          Show
          kavinkumarks Kavin Kumar added a comment - Guys, any updates on the open questions? Thanks, Kavin MailTo: kavin.kumar@imaginea.com
          Hide
          jongyoul Jongyoul Lee added a comment -

          Hi Kavin,

          I think I can answer those questions.

          1. Users already unbind the default interpreter from note and change it. Please check the menu on your note.

          For now, if users create new note, all interpreter settings become bound that note with default setting. I think it's enough to change the default interpreter when user create it.

          How do you think of it?

          Show
          jongyoul Jongyoul Lee added a comment - Hi Kavin, I think I can answer those questions. 1. Users already unbind the default interpreter from note and change it. Please check the menu on your note. For now, if users create new note, all interpreter settings become bound that note with default setting. I think it's enough to change the default interpreter when user create it. How do you think of it?
          Hide
          kavinkumarks Kavin Kumar added a comment -

          Hi Jongyoul,

          Currently in the interpreter binding section, the first interpreter is chosen as the default one.If the user unbinds it then the next one is chosen as the default.But with this ticket we are going to have the default interpreter as fixed and store it in the note json file.If we allow the user to unbind it, how do we choose the interpreter to be used next to the default (if it is in unbind state) and show it in UI?

          Thanks,
          Kavin
          MailTo: kavin.kumar@imaginea.com

          Show
          kavinkumarks Kavin Kumar added a comment - Hi Jongyoul, Currently in the interpreter binding section, the first interpreter is chosen as the default one.If the user unbinds it then the next one is chosen as the default.But with this ticket we are going to have the default interpreter as fixed and store it in the note json file.If we allow the user to unbind it, how do we choose the interpreter to be used next to the default (if it is in unbind state) and show it in UI? Thanks, Kavin MailTo: kavin.kumar@imaginea.com
          Hide
          jongyoul Jongyoul Lee added a comment -

          Hi,

          The order of bound interpreter of note will be stored into conf/interpreter.json and we should keep it for backward compatibility. I think that if a user change the order of interpreter, that means as same as he/she wants to change the default interpreter. Thus we just make user select a specific interpreter when he/she create new note.

          How about this idea?

          Show
          jongyoul Jongyoul Lee added a comment - Hi, The order of bound interpreter of note will be stored into conf/interpreter.json and we should keep it for backward compatibility. I think that if a user change the order of interpreter, that means as same as he/she wants to change the default interpreter. Thus we just make user select a specific interpreter when he/she create new note. How about this idea?
          Hide
          kavinkumarks Kavin Kumar added a comment -

          If I have understood correctly, there is no need to store the default interpreter id separately in the note json file as what I thought to do.Instead of that currently we store the interpreter binding list on creating a note (due to the property org.apache.zeppelin.conf.ZeppelinConfiguration.ConfVars.ZEPPELIN_NOTEBOOK_AUTO_INTERPRETER_BINDING set to 'true') and we can edit the list & put the selected interpreter on creating the note at the top of the list.The rest of the default interpreter behavior everywhere else will work as now.And user can change the default interpreter if needed later too.

          Please correct if I am missing anything here.

          Thanks,
          Kavin
          MailTo: kavin.kumar@imaginea.com

          Show
          kavinkumarks Kavin Kumar added a comment - If I have understood correctly, there is no need to store the default interpreter id separately in the note json file as what I thought to do.Instead of that currently we store the interpreter binding list on creating a note (due to the property org.apache.zeppelin.conf.ZeppelinConfiguration.ConfVars.ZEPPELIN_NOTEBOOK_AUTO_INTERPRETER_BINDING set to 'true') and we can edit the list & put the selected interpreter on creating the note at the top of the list.The rest of the default interpreter behavior everywhere else will work as now.And user can change the default interpreter if needed later too. Please correct if I am missing anything here. Thanks, Kavin MailTo: kavin.kumar@imaginea.com
          Hide
          jongyoul Jongyoul Lee added a comment -

          Perfect!

          Show
          jongyoul Jongyoul Lee added a comment - Perfect!
          Hide
          kavinkumarks Kavin Kumar added a comment -

          Thanks!

          Show
          kavinkumarks Kavin Kumar added a comment - Thanks!
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user kavinkumarks opened a pull request:

          https://github.com/apache/zeppelin/pull/1520

          ZEPPELIN-1061 Select default interpreter while creating note

              1. What is this PR for?
                This handles setting the default interpreter on creating a note through the zeppelin UI.
              1. What type of PR is it?
                Feature
              1. Todos
                NA
              1. What is the Jira issue?
                https://issues.apache.org/jira/browse/ZEPPELIN-1061
              1. How should this be tested?
          • Go to the 'Create Note' dialog and provide the name with the default interpreter selected.After clicking on the Create button, the selected interpreter should be shown properly in the interpreter binding section.
          • If there is no interpreter selected, then the system default will be used.
              1. Screenshots (if appropriate)
                ![zeppelin-1061](https://cloud.githubusercontent.com/assets/20789766/19378611/200d9d50-920b-11e6-930a-6fdcf67c5215.png)
              1. Questions:
          • Does the licenses files need update? No
          • Is there breaking changes for older versions? No
          • Does this needs documentation? No

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/kavinkumarks/zeppelin zeppelin-1061-create-note-default-interpreter

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1520.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1520


          commit c0bd6fb983c40771bf5c6e619bd19c54c7142c1c
          Author: Kavin <kavin.kumar@imaginea.com>
          Date: 2016-10-13T11:02:15Z

          Added option to select the default interpreter on creating a note and
          added websocket APIs to get interpreter settings for the former.Added
          test cases too.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user kavinkumarks opened a pull request: https://github.com/apache/zeppelin/pull/1520 ZEPPELIN-1061 Select default interpreter while creating note What is this PR for? This handles setting the default interpreter on creating a note through the zeppelin UI. What type of PR is it? Feature Todos NA What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1061 How should this be tested? Go to the 'Create Note' dialog and provide the name with the default interpreter selected.After clicking on the Create button, the selected interpreter should be shown properly in the interpreter binding section. If there is no interpreter selected, then the system default will be used. Screenshots (if appropriate) ! [zeppelin-1061] ( https://cloud.githubusercontent.com/assets/20789766/19378611/200d9d50-920b-11e6-930a-6fdcf67c5215.png ) Questions: Does the licenses files need update? No Is there breaking changes for older versions? No Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/kavinkumarks/zeppelin zeppelin-1061-create-note-default-interpreter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1520.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1520 commit c0bd6fb983c40771bf5c6e619bd19c54c7142c1c Author: Kavin <kavin.kumar@imaginea.com> Date: 2016-10-13T11:02:15Z Added option to select the default interpreter on creating a note and added websocket APIs to get interpreter settings for the former.Added test cases too.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1520

          WIP?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1520 WIP?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kavinkumarks commented on the issue:

          https://github.com/apache/zeppelin/pull/1520

          The changes are done.

          Show
          githubbot ASF GitHub Bot added a comment - Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1520 The changes are done.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1520

          @kavinkumarks I'm looking into this.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1520 @kavinkumarks I'm looking into this.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kavinkumarks commented on the issue:

          https://github.com/apache/zeppelin/pull/1520

          @jongyoul any udpates on this?

          Show
          githubbot ASF GitHub Bot added a comment - Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1520 @jongyoul any udpates on this?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1520

          @kavinkumarks Backend codes looks good to me. @corneadoug Could you please look into it?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1520 @kavinkumarks Backend codes looks good to me. @corneadoug Could you please look into it?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1520

          @kavinkumarks Thanks for your contribution. Tested and it works well!

          Can we reset the selected interpreter in the note creation page? Currently the dialog keeps the previously selected one.
          ![interpreter_selection](https://cloud.githubusercontent.com/assets/10060731/19592458/d504e33e-97b6-11e6-9589-8a97399a8470.gif)

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1520 @kavinkumarks Thanks for your contribution. Tested and it works well! Can we reset the selected interpreter in the note creation page? Currently the dialog keeps the previously selected one. ! [interpreter_selection] ( https://cloud.githubusercontent.com/assets/10060731/19592458/d504e33e-97b6-11e6-9589-8a97399a8470.gif )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kavinkumarks commented on the issue:

          https://github.com/apache/zeppelin/pull/1520

          @jongyoul & @AhyoungRyu thanks for reviewing it. @AhyoungRyu I will look into the issue.
          @corneadoug any updates on this?

          Thanks,
          Kavin
          MailTo: kavin.kumar@imaginea.com

          Show
          githubbot ASF GitHub Bot added a comment - Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1520 @jongyoul & @AhyoungRyu thanks for reviewing it. @AhyoungRyu I will look into the issue. @corneadoug any updates on this? Thanks, Kavin MailTo: kavin.kumar@imaginea.com
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1520

          @kavinkumarks Currently there are some conflicts in here. Can you resolve them?

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1520 @kavinkumarks Currently there are some conflicts in here. Can you resolve them?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kavinkumarks commented on the issue:

          https://github.com/apache/zeppelin/pull/1520

          @AhyoungRyu I have resolved the conflicts and also fixed the issue "Can we reset the selected interpreter in the note creation page? Currently the dialog keeps the previously selected one."

          Waiting for the travis build to be success.

          Thanks,
          Kavin
          MailTo: kavin.kumar@imaginea.com

          Show
          githubbot ASF GitHub Bot added a comment - Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1520 @AhyoungRyu I have resolved the conflicts and also fixed the issue "Can we reset the selected interpreter in the note creation page? Currently the dialog keeps the previously selected one." Waiting for the travis build to be success. Thanks, Kavin MailTo: kavin.kumar@imaginea.com
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kavinkumarks commented on the issue:

          https://github.com/apache/zeppelin/pull/1520

          The travis build is green after fixing the test case failure.

          Thanks,
          Kavin
          MailTo: kavin.kumar@imaginea.com

          Show
          githubbot ASF GitHub Bot added a comment - Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1520 The travis build is green after fixing the test case failure. Thanks, Kavin MailTo: kavin.kumar@imaginea.com
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user AhyoungRyu commented on the issue:

          https://github.com/apache/zeppelin/pull/1520

          @kavinkumarks Tested and it works well as expected! Thanks again
          Merging this into master if there are no more discussions.

          Show
          githubbot ASF GitHub Bot added a comment - Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1520 @kavinkumarks Tested and it works well as expected! Thanks again Merging this into master if there are no more discussions.
          Hide
          jongyoul Jongyoul Lee added a comment -

          Issue resolved by pull request 1520
          https://github.com/apache/zeppelin/pull/1520

          Show
          jongyoul Jongyoul Lee added a comment - Issue resolved by pull request 1520 https://github.com/apache/zeppelin/pull/1520
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/1520

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1520

            People

            • Assignee:
              kavinkumarks Kavin Kumar
              Reporter:
              jongyoul Jongyoul Lee
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development