[ZEPPELIN-1024] Zeppelin Git commit fails if notebook folder is a git submodule

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.6.0
• Component/s: zeppelin-interpreter
• Labels: git

Environment

Ubuntu 14.04, Java 1.8 Git 1.9.1

• Assignee: Unassigned
• Reporter: John J. Howard
• Created: 16/Jun/16 18:07
• Updated: 20/Jun/16 17:15

Description

Steps to reproduce:

1. git clone zeppelin
2. git submodule add [e-mail]:user/my_notebook.git
3. Modify zeppelin-notebook-dir property in zeppelin-site.xml to point to my_notebook folder
4. Uncomment GitNotebookRepo value for zeppelin.notebook.storage property in zeppelin-site.xml
5. Attempt to do a git commit from zeppelin GUI

The following stacktrace is logged. I believe this has something to do with the fact that .git items in submodules are text files (not folders as they are in normal git repos) that point back to the parent repo's .git folder.

ERROR [2016-06-16 17:21:04,226] (

{qtp1856056345-17}

NotebookServer.java[onMessage]:210) - Can't handle message
org.eclipse.jgit.api.errors.JGitInternalException: Exception caught during execution of add command
at org.eclipse.jgit.api.AddCommand.call(AddCommand.java:211)
at org.apache.zeppelin.notebook.repo.GitNotebookRepo.checkpoint(GitNotebookRepo.java:84)
at org.apache.zeppelin.notebook.repo.NotebookRepoSync.checkpoint(NotebookRepoSync.java:363)
at org.apache.zeppelin.notebook.Notebook.checkpointNote(Notebook.java:321)
at org.apache.zeppelin.socket.NotebookServer.checkpointNotebook(NotebookServer.java:1047)
at org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:204)
at org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:56)
at org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:128)
at org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69)
at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65)
at org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextFrame(JettyListenerEventDriver.java:122)
at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161)
at org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309)
at org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214)
at org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220)
at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258)
at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632)
at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480)
at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.io.IOException: Creating directories for /usr/local/zeppelin/zeppelin-0.6.0-incubating-SNAPSHOT/my_notebook/.git failed
at org.eclipse.jgit.util.FileUtils.mkdirs(FileUtils.java:370)
at org.eclipse.jgit.internal.storage.file.LockFile.lock(LockFile.java:158)
at org.eclipse.jgit.dircache.DirCache.lock(DirCache.java:583)
at org.eclipse.jgit.dircache.DirCache.lock(DirCache.java:223)
at org.eclipse.jgit.dircache.DirCache.lock(DirCache.java:301)
at org.eclipse.jgit.dircache.DirCache.lock(DirCache.java:267)
at org.eclipse.jgit.lib.Repository.lockDirCache(Repository.java:1053)
at org.eclipse.jgit.api.AddCommand.call(AddCommand.java:142)
... 21 more