Uploaded image for project: 'Apache YuniKorn'
  1. Apache YuniKorn
  2. YUNIKORN-82

Wrong revision in docker image

    XMLWordPrintableJSON

    Details

      Description

      Reproduce steps

      1. from k8shim, build the scheduler docker image, such as: yunikorn/yunikorn-scheduler-k8s:latest
      2. then run "docker inspect yunikorn/yunikorn-scheduler-k8s:latest"
      3. check Labels

      "Labels": {     "BuildTimeStamp": "2020-04-07T10:17:10-0700",   "Version": "latest",   "yunikorn-core-revision": "20200403014952",   "yunikorn-k8shim-revision": "0c83fd7f5ff5",   "yunikorn-scheduler-interface-revision": "20200327234544" }

      Looks like the revision for yunikorn-core-revision and yunikorn-scheduler-interface-revision are incorrect. Code to set this is in Makefile

      ...
       @coreSHA=$$(go list -m "github.com/apache/incubator-yunikorn-core" | cut -d "-" -f4) ; \
       siSHA=$$(go list -m "github.com/apache/incubator-yunikorn-scheduler-interface" | cut -d "-" -f5) ; \
       shimSHA=$$(git rev-parse --short=12 HEAD) ; \
       docker build ./deployments/image/configmap -t ${REGISTRY}/yunikorn-scheduler-k8s:${VERSION} \
       --label "yunikorn-core-revision=$${coreSHA}" \
       --label "yunikorn-scheduler-interface-revision=$${siSHA}" \
       --label "yunikorn-k8shim-revision=$${shimSHA}" \
       --label "BuildTimeStamp=${DATE}" \
       --label "Version=${VERSION}"
      
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                taoyang Tao Yang
                Reporter:
                wwei Weiwei Yang
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m