[YUNIKORN-2964] Enhance the error message "node not eligible"

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Component/s: shim - kubernetes
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 05/Nov/24 14:28
• Updated: 05/Nov/24 14:35
• Resolved: 05/Nov/24 14:35

Description

When we run plugins in the prefilter phase, we maintain a list of nodes (called "mergedNodes") and we check if the current node is included or not after we run a plugin. 

If the node is not listed, we don't log which plugin made this decision. To enhance supportability, we should include the plugin name in the returned message:

mergedNodes = mergedNodes.Merge(nodes)
if !mergedNodes.AllNodes() && !mergedNodes.NodeNames.Has(node.Node().Name) {
    return framework.NewStatus(framework.UnschedulableAndUnresolvable, "node not eligible"), plugin, skip
} 

 

Issue Links

• duplicates: YUNIKORN-2575 Make logging for IsPodFitNode clear