[YUNIKORN-2724] Improve the signature of methods notifyTaskComplete() and ensureAppAndTaskCreated()

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: shim - kubernetes
• Labels: pull-request-available
• Target Version: 1.6.0
• Assignee: Hsien-Cheng(Ryan) Huang
• Reporter: Peter Bacsko
• Created: 04/Jul/24 20:38
• Updated: 10/Sep/24 20:58
• Resolved: 11/Aug/24 20:45

Description

From the review https://github.com/apache/yunikorn-k8shim/pull/864

Change notifyTaskComplete(string, string) to notifyTaskComplete(*Application, string). It removes a number of extra getApplication() calls we really do not need.
Similar for ensureAppAndTaskCreated() which is only ever called from this function. Add a parameter to it to make it: ensureAppAndTaskCreated(*v1.Pod, *Application) and only execute application creation if app == nil. 

Issue Links

• depends upon: YUNIKORN-2319 cache.Task: reference to old pod object is kept after update
• links to: GitHub Pull Request #873