[YUNIKORN-2666] Fix DeepEqual comparison in Test_fixedRule_ruleDAO

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: core - scheduler, test - unit
• Labels: pull-request-available
• Target Version: 1.6.0
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 06/Jun/24 12:54
• Updated: 06/Jun/24 14:31
• Resolved: 06/Jun/24 14:31

Description

The test case Test_fixedRule_ruleDAO/filter can randomly fail due to the non-deterministic nature of map key iteration:

fixed_rule_test.go:285: assertion failed: 
            --- tt.want
            +++ ruleDAO
              &dao.RuleDAO{
              	Name:       "fixed",
              	Parameters: {"create": "true", "qualified": "false", "queue": "default"},
              	Filter: &dao.FilterDAO{
              		Type:     "allow",
              		UserList: nil,
              		GroupList: []string{
            - 			"group1",
            + 			"group2",
            - 			"group2",
            + 			"group1",
              		},
              		UserExp:  "",
              		GroupExp: "",
              	},
              	ParentRule: nil,
              }

We use maps.Keys() when we create the user list and group list in FilterDAO.

Issue Links

• links to: GitHub Pull Request #887