[YUNIKORN-2621] CSINode informer is not started

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.5.2, 1.6.0
• Labels: pull-request-available
• Target Version: 1.5.2, 1.6.0
• Assignee: Jacob Salway
• Reporter: Jacob Salway
• Created: 10/May/24 23:22
• Updated: 20/May/24 21:02
• Resolved: 13/May/24 10:12

Description

The shared CSINode informer created in the shim is not started, meaning anything that uses CSINodes from the shared informer factory, such as any scheduler plugins like nodevolumelimits or the volume binder in Yunikorn itself.

Two symptoms of this that we observed at Rokt was Yunikorn not respecting the allocatable field on CSINode objects and error logs from the volume binder about not being able to find CSINode objects.

https://github.com/apache/yunikorn-k8shim/blob/master/pkg/client/apifactory.go#L91

https://github.com/apache/yunikorn-k8shim/blob/master/pkg/client/clients.go#L92-L101

https://github.com/kubernetes/kubernetes/blob/v1.30.0/pkg/scheduler/framework/plugins/nodevolumelimits/csi.go#L120

Issue Links

• relates to: YUNIKORN-2623 Create unit tests for Clients
• links to: GitHub Pull Request #838