[YUNIKORN-2590] Handler tests should check for nil request on create

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: core - common, test - unit
• Labels: newbie pull-request-available
• Target Version: 1.6.0
• Assignee: Hsien-Cheng(Ryan) Huang
• Reporter: Wilfred Spiegelenburg
• Created: 26/Apr/24 02:33
• Updated: 11/May/24 16:05
• Resolved: 11/May/24 16:05

Description

In the handler_test.go file we have an anti pattern showing a large number (40+) warnings in an IDE:

'req' might have 'nil' or other unexpected value as its corresponding error variable might be not 'nil'

The warning are due to the fact that we have the following pattern:

req, err = http.NewRequest("GET", "path", strings.NewReader(""))
req = req.WithContext(context.WithValue(req.Context(), httprouter.ParamsKey, httprouter.Params{}))

There is no error assertion after the request creation. We should add a simple assert.NilError(t, err, "HTTP request create failed") inserted between creating and using the request.

Issue Links

• links to: GitHub Pull Request #865