[YUNIKORN-2572] remove un-used conditional

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: core - common
• Labels: pull-request-available
• Target Version: 1.6.0
• Assignee: Hsien-Cheng(Ryan) Huang
• Reporter: Hsien-Cheng(Ryan) Huang
• Created: 20/Apr/24 18:26
• Updated: 21/Apr/24 09:01
• Resolved: 21/Apr/24 09:01

Description

look into this conditional:

if intValue < 0 {
            return nil, fmt.Errorf("negative resources not permitted: %v", configMap)
}

This will never be used because regrex defined here. not including "-" as a starting char

Thus, it will never omit error about negative resource, instead it will raise invalid quantity error at https://github.com/apache/yunikorn-core/blob/55e9fe650760bdf30d27a7ecf85b34d5f96c492f/pkg/common/resources/quantity.go#L74 .

Issue Links

• links to: GitHub Pull Request #850