[YUNIKORN-2552] Recursive locking when sending remove queue event

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0, 1.5.1
• Component/s: core - scheduler
• Labels: pull-request-available
• Target Version: 1.6.0, 1.5.1
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 11/Apr/24 13:33
• Updated: 15/Apr/24 11:41
• Resolved: 15/Apr/24 11:41

Description

When sending a queue event from queueEvents, we acquire the read lock again.

objects.(*Queue).IsManaged { sq.RLock() } <<<<<
objects.(*Queue).IsManaged { func (sq *Queue) IsManaged() bool { }
objects.(*queueEvents).sendRemoveQueueEvent { } }
objects.(*Queue).RemoveQueue { sq.queueEvents.sendRemoveQueueEvent() }
scheduler.(*partitionManager).cleanQueues { // all OK update the queue hierarchy and partition }
scheduler.(*partitionManager).cleanQueues { if children := queue.GetCopyOfChildren(); len(children) != 0 { }
scheduler.(*partitionManager).cleanRoot { manager.cleanQueues(manager.pc.root) }

RemoveQueue() already has the read lock.

Issue Links

• links to: GitHub Pull Request #841