[YUNIKORN-255] Cleanup code from event cache change

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9
• Component/s: core - common
• Labels: pull-request-available
• Target Version: 0.9
• Assignee: Adam Antal
• Reporter: Wilfred Spiegelenburg
• Created: 25/Jun/20 07:11
• Updated: 21/Jan/22 21:47
• Resolved: 22/Jul/20 07:38

Description

There are a number of places where the code for the event cache needs a cleanup:

• need comments throughout the code explaining assumptions made and behaviour
• add negative tests where they are missing

Code comments:

• entrypoint.go clean up if structure around lines 85-90
• rationalise event_cache startup around channel creation, service start and store cleanup on shutdown
• event_cache_test: document what the tests do, use loops to generate events, make sure test names cover what is being tested.
• event_publisher: remove isStopped and use atomic directly, data loss on send failure, error from SendEvent is a non nil value no need to check for ""
• event_publisher_test: mockEventPlugin is a failing plugin and should be reusable
• event_store: optimise collectevents by using a 3 param make call for array
• event_store_test: document what the tests do, use loops to generate events,

Issue Links

• links to: GitHub Pull Request #180