[YUNIKORN-2504] Support canonical labels and align metadata retrieving order in shim

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: core - scheduler, release-notes, shim - kubernetes
• Labels: pull-request-available release-notes
• Target Version: 1.6.0
• Assignee: Yu-Lin Chen
• Reporter: Yu-Lin Chen
• Created: 19/Mar/24 17:07
• Updated: 21/Aug/24 18:58
• Resolved: 21/Aug/24 18:58

Description

Currently, we support queue/applicationID set in both label and annotation.

Queue

• queue [label] → If set, ignore annotation’s value
• yunikorn.apache.org/queue [annotation]

ApplicationID

• applicationId [label]
• yunikorn.apache.org/app-id [annotation] → If set, ignore label’s value

According to the new policy defined in YUNIKORN-1351.

We will add canonical representation to Queue/ApplicationId:

• yunikorn.apache.org/queue [label]
• yunikorn.apache.org/app-id [label]

Also align the ordering when fetch app-id/queue from pod:

app-id should be fetched in below order:

1. Label: yunikorn.apache.org/app-id (New)
2. Annotation: yunikorn.apache.org/app-id
3. Label: applicationId
4. Label: spark-app-selector

queue name should be fetched in below order:

1. Label: yunikorn.apache.org/queue (New)
2. Annotation: yunikorn.apache.org/queue
3. Label: queue

 

Non-canonical format will be kept for backward compatibility.
However, If the same metadata (queue or applicationID) is specified in multiple locations and their values are inconsistent, the admission controller and scheduler should reject the pod. (Version 1.6.0 only prints out warnings; task rejection should occur in version 1.7.0.) This change is tracked by YUNIKORN-2810 and YUNIKORN-2811.

 

Please refer the changes in YUNIKORN-1351 for more details.

Issue Links

• is related to: YUNIKORN-2810 Throw a warning if a pod has inconsistent metadata
• is related to: YUNIKORN-2811 Reject task if a pod has inconsistent metadata in the shim
• relates to: YUNIKORN-2631 Support canonical labels for queue/applicationId in Admission Controller
• links to: GitHub Pull Request #893