[YUNIKORN-2320] Package-level loogging breaks custom logging configuration

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Component/s: core - common
• Labels: pull-request-available
• Target Version: 1.5.0
• Assignee: Ovidiu Feodorov
• Reporter: Ovidiu Feodorov
• Created: 09/Jan/24 17:11
• Updated: 20/Mar/24 14:32
• Resolved: 17/Jan/24 15:48

Description

objects.rateLimitedLog is initialized during package initialization phase, triggering log.once before log.InitializeLogger() has a chance to apply custom logging configuration. As result, the logging system does not accept custom configuration anymore.

entrypoint.TestCustomLoggingConfiguration() demonstrates the problem.

There are several ways to address the problem:

1. Lazy initialize the package-level logging variable objects.rateLimitedLog.

2. (preferred) Remove the package-level variable and replace it with an Application instance-level variable, which is also lazily initialized.

More details available here: https://yunikornworkspace.slack.com/archives/CLNUW68MU/p1704322291697499

Call stack that demonstrates the problem attached.

Issue Links

• is caused by: YUNIKORN-1985 possible log spew in application object in tryAllocate()
• links to: GitHub Pull Request #773