Uploaded image for project: 'Apache YuniKorn'
  1. Apache YuniKorn
  2. YUNIKORN-2218

It always requests apps from nonexistent queues after the e2e gets failed

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Test
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • None
    • None
    • None

    Description

      https://github.com/apache/yunikorn-k8shim/blob/master/test/e2e/wrappers.go#L112

       

      	for _, ns := range namespaces {
      		logErr := k8s.LogNamespaceInfo(ns)
      		Ω(logErr).NotTo(HaveOccurred())
      
      		pods, err := k.GetPodsByOptions(metav1.ListOptions{})
      		Ω(err).NotTo(HaveOccurred())
      		By("Pod count is " + strconv.Itoa(len(pods.Items)))
      		for _, pod := range pods.Items {
      			By("Pod name is " + pod.Name)
      			By("Pod details: " + pod.String())
      		}
      
      		logErr = restClient.LogAppsInfo(ns)
      		Ω(logErr).NotTo(HaveOccurred())
      	}
      

      `restClient.LogAppsInfo(ns)` tries to get apps from "root.$ns". However, these queues are nonexistent normally (https://github.com/apache/yunikorn-k8shim/blob/master/test/e2e/framework/helpers/yunikorn/rest_api_utils.go#L351)

      It logged all apps before https://github.com/apache/yunikorn-k8shim/pull/516 got merged. It seems to me previous behavior makes sense. Logging all apps is better than logging nothing

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            targetoee JiaChi Wang Assign to me
            chia7712 Chia-Ping Tsai
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment