[YUNIKORN-2161] Metrics code cleanup

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Component/s: core - scheduler
• Labels: pull-request-available
• Target Version: 1.5.0
• Assignee: Kuan Po Tseng
• Reporter: Peter Bacsko
• Created: 19/Nov/23 04:45
• Updated: 20/Mar/24 14:32
• Resolved: 21/Nov/23 02:37

Description

There are unused methods in the metrics subsystem:
AddQueuePendingResourceMetrics()
AddQueuePreemptingResourceMetrics()
AddQueueAllocatedResourceMetrics()
(there might be others)

The production code does not call these methods and there are no unit tests either.

We can also consider removing the interfaces. Right now there is just one implementation for everything (CoreQueueMetrics, CoreSchedulerMetrics, GoRuntimeMetrics). We don't need to mock metrics because it's very lightweight, resetting the state is trivial.

Issue Links

• links to: GitHub Pull Request #719