Details
-
Improvement
-
Status: Open
-
Major
-
Resolution: Unresolved
-
None
-
None
-
None
Description
The predicateCheckResult type should not be part of the preemption.go file.
All declarations and functions that have a predicateCheckResult as receiver or return value value should be moved. Unused functions should be removed.
Unneeded exports on functions / types should be removed. If exported the comments on the functions and types need to comply with standard go rules.
All remaining functions should get tests to make sure they are working correctly.
Additionally, implement Stringer interface so that zap.Any() calls can be replaced with zap.Stringer() to avoid reflection.
Attachments
Issue Links
- is related to
-
YUNIKORN-2152 Move QueuePreemptionSnapshot type and tests to their own files
- Open