[YUNIKORN-2124] Fix incorrect test in queue_test.go#TestNewConfiguredQueue

• Type: Task
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Component/s: core - scheduler, test - unit
• Labels: pull-request-available
• Target Version: 1.5.0
• Assignee: Kuan Po Tseng
• Reporter: Kuan Po Tseng
• Created: 06/Nov/23 02:57
• Updated: 20/Mar/24 14:32
• Resolved: 23/Nov/23 11:52

Description

in unit test queue_test.go#TestNewConfiguredQueue

// case 0: leaf can use template

https://github.com/apache/yunikorn-core/blob/284cc92974a7330c95ad3c6ecdf05ea68b9eee9d/pkg/scheduler/objects/queue_test.go#L2225-L2226

This test is flawed as it erroneously allows managed leaf queues to utilize child template and it consistently passes because the getResourceConf function lacks the required randomness. (https://github.com/apache/yunikorn-core/blob/284cc92974a7330c95ad3c6ecdf05ea68b9eee9d/pkg/scheduler/objects/queue_test.go#L1728) 

Issue Links

• links to: GitHub Pull Request #696