Uploaded image for project: 'Apache YuniKorn'
  1. Apache YuniKorn
  2. YUNIKORN-1978

Add e2e test for node sorting with the fairness policy

Details

    • Test
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • test - e2e

    Description

      Currently, there are no test cases for Node sorting under the Fairness policy.
      As a result, we should create test cases for both the base case and the case with resource weights added.

      Attachments

        Issue Links

          Activity

            pbacsko Peter Bacsko added a comment - - edited

            Just a question... I just reviewed this test, but do we really need want to test this on e2e level? It feels unnecessary. There's a separate MockScheduler in the scheduler-core where this can be tested easily with isolation.

            First we need to ensure proper unit test coverage. If we have that, we can step up to higher integration test levels, eg. the ones in partition_test.go. Then next is MockScheduler with the core. Then MockScheduler with k8shim+core. This should be the way to go. In general, I think we skip the integration and move to e2e too quickly. It's a general problem, something that needs to be discussed IMO.

            pbacsko Peter Bacsko added a comment - - edited Just a question... I just reviewed this test, but do we really need want to test this on e2e level? It feels unnecessary. There's a separate MockScheduler in the scheduler-core where this can be tested easily with isolation. First we need to ensure proper unit test coverage. If we have that, we can step up to higher integration test levels, eg. the ones in partition_test.go . Then next is MockScheduler with the core. Then MockScheduler with k8shim+core. This should be the way to go. In general, I think we skip the integration and move to e2e too quickly. It's a general problem, something that needs to be discussed IMO.
            samhxwu Hsuan Zong Wu added a comment -

            pbacsko  Thank you for your comment. I will make sure to ensure proper unit test coverage before moving on to higher levels of integration testing.

            samhxwu Hsuan Zong Wu added a comment - pbacsko   Thank you for your comment. I will make sure to ensure proper unit test coverage before moving on to higher levels of integration testing.

            People

              samhxwu Hsuan Zong Wu
              samhxwu Hsuan Zong Wu
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: