[YUNIKORN-1807] Remove error check from createEventRecord()

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: core - scheduler
• Labels: pull-request-available
• Target Version: 1.4.0
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 10/Jun/23 07:15
• Updated: 20/Nov/23 16:42
• Resolved: 13/Jun/23 19:46

Description

Currently, createEventRecord() performs an error check:

	if objectID == "" {
		return nil, fmt.Errorf("objectID should not be nil")
	}
	if reason == "" {
		return nil, fmt.Errorf("reason should not be nil")
	}

These error checks are not necessary. Everything is in our hands here, the two strings are not user-supplied input. We'll have tons of tests, both unit and e2e, such classic defensive coding is not needed.

Issue Links

• links to: GitHub Pull Request #564