[YUNIKORN-1723] Remove string comparison from hasReadyCondition() function

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Component/s: shim - kubernetes
• Labels: pull-request-available
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 05/May/23 08:40
• Updated: 20/Jun/23 14:41
• Resolved: 09/May/23 16:11

Description

Kubemark testing identified an expensive method in the shim, which is called for every node update.

func hasReadyCondition(node *v1.Node) bool {
   if node != nil && node.Status.String() != "nil" {
      for _, condition := range node.Status.Conditions {
         if condition.Type == v1.NodeReady && condition.Status == v1.ConditionTrue {
            return true
         }
      }
   }
   return false
} 

 

node.Status cannot be nil, and Status.String() builds a decently sized string. The check against "nil" should be deleted.

 

 

Issue Links

• links to: GitHub Pull Request #586