[YUNIKORN-1720] Improve the performance of node.preAllocateCheck()

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Labels: pull-request-available
• Assignee: Eli Schiff
• Reporter: Eli Schiff
• Created: 03/May/23 17:17
• Updated: 20/Jun/23 14:41
• Resolved: 04/May/23 09:49

Description

The node.preAllocateCheck() function gets run a lot during the scheduling cycle. The function is effectively a boolean function, either the node can be allocated on or it cannot. Instead of returning a bool it returns nil for true and a full error message for false. The thing is, that error message is never read anywhere. From what I can tell, the only thing the code does is check if there is an error message but not the contents. By removing the error message code, it should improve performance.

Issue Links

• links to: GitHub Pull Request #536