[YUNIKORN-1578] Use zap.Stringer instead of calling String on object

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Component/s: core - common, shim - kubernetes
• Labels: pull-request-available
• Target Version: 1.3.0
• Assignee: Qi Zhu
• Reporter: Wilfred Spiegelenburg
• Created: 12/Feb/23 23:00
• Updated: 20/Nov/23 17:00
• Resolved: 22/Feb/23 07:45

Description

Throughout the code we have lots of places where we use the following call structure:

zap.String("text here", object.String()) 

This causes the object.String() call to happen before we even consider if it needs to be logged. Zap has a lazy way of doing this that removes the call to create the string  until it is needed, after the level checks etc. The above call becomes:

zap.Stringer("text here", object) 

Affect core and k8shim

Issue Links

• links to: GitHub Pull Request #506
• links to: GitHub Pull Request #534