[YUNIKORN-1533] Fix Admission Controller test user auth failures

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: test - e2e
• Labels: newbie
• Assignee: Manikandan R
• Reporter: Manikandan R
• Created: 10/Jan/23 07:09
• Updated: 18/May/23 00:23

Description

AdmissionController
Check that deployment is rejected when controller users are not trusted
/home/runner/work/yunikorn-k8shim/yunikorn-k8shim/test/e2e/admission_controller/admission_controller_test.go:248
STEP: Retrieve existing configmap
STEP: Update configmap
STEP: Create a deployment
STEP: Check for sleep pods (should time out)
Error: <nil>
STEP: Delete deployment sleepjob
STEP: Forcibly deleting pods
STEP: Check YuniKorn's health

• Failure [2.137 seconds]
AdmissionController
/home/runner/work/yunikorn-k8shim/yunikorn-k8shim/test/e2e/admission_controller/admission_controller_test.go:67
Check that deployment is rejected when controller users are not trusted [It]
/home/runner/work/yunikorn-k8shim/yunikorn-k8shim/test/e2e/admission_controller/admission_controller_test.go:248

Expected an error to have occurred. Got:
<nil>: nil

/home/runner/work/yunikorn-k8shim/yunikorn-k8shim/test/e2e/admission_controller/admission_controller_test.go:278
------------------------------
AdmissionController
Check that deployment is rejected when external user is not trusted
/home/runner/work/yunikorn-k8shim/yunikorn-k8shim/test/e2e/admission_controller/admission_controller_test.go:306
STEP: Retrieve existing configmap
STEP: Update configmap
STEP: Create a deployment
Error received from API server: admission webhook "admission-webhook.yunikorn.mutate-pods" denied the request: user kubernetes-admin with groups [system:masters,system:authenticated] is not allowed to set user annotation
STEP: Changing allowed externalUser setting
STEP: Submit deployment again
STEP: Check for sleep pod
STEP: Delete deployment sleepjob
STEP: Forcibly deleting pods
make: *** [Makefile:408: e2e_test] Error 1
STEP: Check YuniKorn's health

• Failure [64.042 seconds]
AdmissionController
/home/runner/work/yunikorn-k8shim/yunikorn-k8shim/test/e2e/admission_controller/admission_controller_test.go:67
Check that deployment is rejected when external user is not trusted [It]
/home/runner/work/yunikorn-k8shim/yunikorn-k8shim/test/e2e/admission_controller/admission_controller_test.go:306

Unexpected error:
<*errors.errorString | 0xc00023c330>:

{ s: "timed out waiting for the condition", }

timed out waiting for the condition
occurred

/home/runner/work/yunikorn-k8shim/yunikorn-k8shim/test/e2e/admission_controller/admission_controller_test.go:356
------------------------------
STEP: Deleting test namepsace admission-controller-test
STEP: Removing priority class yk-test-non-yk
STEP: Removing priority class yk-test-non-preempt
STEP: Removing priority class yk-test-preempt
STEP: Restore the old config maps

Summarizing 2 Failures:

[Fail] AdmissionController [It] Check that deployment is rejected when controller users are not trusted
/home/runner/work/yunikorn-k8shim/yunikorn-k8shim/test/e2e/admission_controller/admission_controller_test.go:278

Please refer https://github.com/apache/yunikorn-k8shim/actions/runs/3880467313/jobs/6618670698 for more details.