[YETUS-721] personalities shouldn't directly set repository information

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.8.0
• Fix Version/s: 0.9.0
• Component/s: Precommit

Release Note

<!-- markdown -->
Personalities should no longer directly set GITHUB_REPO or GITLAB_REPO. Instead, they should set GITHUB_REPO_DEFAULT and GITLAB_REPO_DEFAULT. This will allow for certain CI environments to proper auto-determine the place where the build is coming from.

• Flags: Important
• Assignee: Allen Wittenauer
• Reporter: Allen Wittenauer
• Created: 16/Nov/18 18:12
• Updated: 07/Jan/19 04:01
• Resolved: 07/Jan/19 04:01

Description

One of the key learnings from YETUS-681 is that it's pretty harmful for forks if the personality specifically sets the github repo:

1) User forks apache/yetus
2) User configures Travis CI to run their local yetus repo
3) User makes a pull request against their local yetus repo
4) test-patch reads the github info from Travis CI to know the repo location
5) User sets --project=yetus, which then changes the github information to apache/yetus
6) Pull request test fails because that PR doesn't exist in apache/yetus