[YETUS-443] github pull request regular expression in the jira plugin should be more complete

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.4.0
• Fix Version/s: 0.4.0
• Component/s: Precommit
• Assignee: Casey Brotherton
• Reporter: Casey Brotherton
• Created: 18/Aug/16 15:16
• Updated: 04/Sep/16 22:05
• Resolved: 25/Aug/16 15:59

Description

The JIRA plugin ( jira.sh ) uses a regular expression to determine
if there is a github pull request that contains a patch.

There is a duplicate regular expression in github_jira_bridge in
github.sh that is similar, as well as multiple regular expressions
in github_locate_patch that look for slightly different patterns.

The regular expression can wrongly determine that some links are
github pull requests, as it looks for starting with GITHUB_BASE_URL
and just that there are no spaces until the string "patch"

This regular expression should be modified, as well as consideration to whether the regexes should be combined in some way.

Issue Links

• breaks: YETUS-447 invalid byte in cut