[YETUS-309] pylint plugin false positives

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.1.0
• Fix Version/s: 0.4.0
• Component/s: Precommit
• Release Note: The precommit plugin for pylint now ignores messages at the INFO level, which includes locally disabled warnings.
• Assignee: Dima Spivak
• Reporter: Sean Busbey
• Created: 16/Feb/16 15:19
• Updated: 18/Aug/16 16:39
• Resolved: 18/Aug/16 16:39

Description

the pylint plugin is flagging some changes as failures when the pylint utility returns a success return code because of INFO level messages about local disables.

e.g. in a patch that removes all outstanding issues but has to use local disables in some cases, test-patch returns a -1 and the diff contains only:

some/path/to/script.py:53: [I0011(locally-disabled), ] Locally disabling no-member (E1101)
some/path/to/script.py:54: [I0011(locally-disabled), ] Locally disabling no-member (E1101)
some/path/to/script.py:55: [I0011(locally-disabled), ] Locally disabling no-member (E1101)
some/path/to/script.py:56: [I0011(locally-disabled), ] Locally disabling no-member (E1101)
some/path/to/script.py:57: [I0011(locally-disabled), ] Locally disabling no-member (E1101)
some/path/to/script.py:58: [I0011(locally-disabled), ] Locally disabling no-member (E1101)

In this particular case, the code uses dynamic attributes, which pylint in python 2.x can't handle. In general, things at the INFO level (IXXXX) shouldn't cause a failure. Or at a minimum personalities should be able to opt-in to it not failing without overriding the log output filter.