Uploaded image for project: 'Yetus'
  1. Yetus
  2. YETUS-221

asflicense check exits multi-module Maven build early if there are pre-existing license problems.

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.1.0
    • 0.2.0
    • Precommit
    • None

    Description

      The asflicense check runs mvn apache-rat:check from the root of the project (unless told otherwise). For a multi-module build, the build exits with failure after the first occurrence of a module with a license problem. It won't check subsequent modules. If the patch in question is touching one of those subsequent modules, then asflicense won't check it. A reviewer might incorrectly conclude that the patch is fine, because the pre-existing license problems are unrelated.

      Attachments

        1. YETUS-221.00.patch
          0.9 kB
          Allen Wittenauer
        2. YETUS-221.01.patch
          0.9 kB
          Allen Wittenauer

        Issue Links

          Activity

            People

              aw Allen Wittenauer
              cnauroth Chris Nauroth
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: